•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-759-1 15 Nov 2019

RESOLVED in CODE WALKTHROUGH.

HD-DEN-759-1 14 Nov 2019

There is no need to check in *.pyc files, these are compiled Python files at run time.

HD-DEN-752-1 08 Nov 2019

RESOLVED in CODE WALKTHROUGH.

HD-DEN-752-1 08 Nov 2019

What are U, S, and F used for in the case of alarms?

DG-DEN-1125-1 20 Dec 2019

RESOLVED IN CODE WALKTHROUGH

HD-DEN-759-1 15 Nov 2019

RESOLVED in CODE WALKTHROUGH.

HD-DEN-752-1 08 Nov 2019

RESOLVED in CODE WALKTHROUGH.

HD-DEN-759-1 07 Nov 2019

How do we know the ramp rate? Is it fixed or parameterized?

HD-DEN-759-1 08 Nov 2019

RESOLVED in CODE WALKTHROUGH.

HD-DEN-759-1 07 Nov 2019

Do we foresee a scenario where the blood pump would be run in reverse? If not, we should lock the direction and not allow it to change.

HD-DEN-759-1 14 Nov 2019

Are we reviewing vector cast unit testing and integration testing? if that is the case, we are not doing it via text, are we?

HD-DEN-759-1 14 Nov 2019

Value "38", which is ...?

HD-MASTER-1 15 Nov 2019

RESOLVED IN CODE WALKTHROUGH

HD-DEN-759-1 15 Nov 2019

RESOLVED in CODE WALKTHROUGH.

HD-DEN-759-1 15 Nov 2019

RESOLVED in CODE WALKTHROUGH.

HD-SPR3-1 15 Nov 2019

RESOLVED IN CODE WALKTHROUGH

HD-DEN-759-1 14 Nov 2019

Value "28", which is ...?

HD-SPR3-1 15 Nov 2019

RESOLVED IN CODE WALKTHROUGH

HD-DEN-759-1 15 Nov 2019

RESOLVED in CODE WALKTHROUGH.

HD-DEN-759-1 14 Nov 2019

Value "27", which is ...?

HD-DEN-759-1 15 Nov 2019

RESOLVED in CODE WALKTHROUGH.

HD-DEN-759-1 15 Nov 2019

RESOLVED in CODE WALKTHROUGH.

HD-DEN-759-1 14 Nov 2019

Value "24", which is ...?

HD-DEN-759-1 14 Nov 2019

Value "18", which is ...?

HD-SPR4-1 24 Oct 2019

do not use address++ in calculation. It is confusing. Use it after.

UI-DEN-608-1 28 Oct 2019

How was this made a more general component without any code being added?

UI-DEN-608-1 28 Oct 2019

RESOLVED.

HD-SPR4-1 24 Oct 2019

Is this a convention we want to impose? I have "data" in many places already.

TEST-1 28 Oct 2019

Resolved

UI-DEN-625-1 24 Oct 2019

Added as usual but seems like out current display is not supporting it.
I kept it as a reminder since we are changing our display and maybe our driver later.
At that time I'll decide to keep or remove it.

HD-DEN-759-1 14 Nov 2019

Here it takes value "6", which is ...?

UI-DEN-3605-4 05 Oct 2020

RESOLVED

HD-SPR4-1 25 Oct 2019

RESOLVED IN CODE WALKTHROUGH

HD-SPR4-1 24 Oct 2019

Because this is a calculation, add how many bits are you shifting. SHIFT_5_BITS_IN_BYTE to make it more readable.

HD-SPR4-1 25 Oct 2019

RESOLVED IN CODE WALKTHROUGH

HD-SPR4-1 24 Oct 2019

Can you revert the order? output should be on the left, input to the right.

HD-SPR4-1 30 Oct 2019

RESOLVED in CODE WALKTHROUGH.

HD-SPR4-1 24 Oct 2019

Is this a convention we want to impose? Why should output be on left?

HD-SPR4-1 25 Oct 2019

As is. RESOLVED IN CODE WALKTHROUGH

HD-DEN-759-1 14 Nov 2019

Value "11", which is ...?

HD-SPR3-1 25 Oct 2019

RESOLVED IN CODE WALKTHROUGH

HD-SPR5-1 31 Oct 2019

Incomplete, if so, please comment correctly.

HD-SPR3-1 25 Oct 2019

RESOLVED IN CODE WALKTHROUGH

HD-DEN-759-1 11 Nov 2019

I fixed issue with release build that Dara brought up. In doing so, a new "release" folder was created when I did a build and got committed with the fix. I checked my .gitignore and saw that the "debug" folder was ignored so I removed the "release" folder before pushing. For some reason, I still see the "debug" folder in my git repo so maybe the .gitignore isn't even working.

HD-MASTER-1 25 Oct 2019

RESOLVED IN CODE WALKTHROUGH

HD-SPR5-1 01 Nov 2019

RESOLVED in CODE WALKTHROUGH.

HD-MASTER-1 25 Oct 2019

RESOLVED IN CODE WALKTHROUGH

HD-MASTER-1 25 Oct 2019

RESOLVED IN CODE WALKTHROUGH

HD-DEN-759-1 14 Nov 2019

Value "16", which is ...?

TEST-1 04 Nov 2019

I don't know about this file...