•  

Comment Results

Review Name Created Custom Fields Content
UI-DEN-1090-1 19 Dec 2019

Thanks.
Since it's going to be as part of the sdd in doxygen I tried to be descriptive.

HD-DEN-431-1 30 Dec 2019

Software fault if invalid state.

DG-DEN-1125-1 12 Dec 2019

This is an enum, not sure what you mean to initialize. MSG_ID_OFF_BUTTON_PRESS, is set to 1

HD-DEN-759-1 11 Dec 2019

Spaces between 0s.

UI-DEN-1090-1 19 Dec 2019

These are connection which I align to with the other once to make sure I'm connecting ti the correct Signal/slot.
It helps me to identify the problem very quick.

DIALIN-1 12 Dec 2019

Done

UI-DEN-1090-1 19 Dec 2019

Some Constants are one time use and doesn't add any value to the code to collect them in one place.
And also since it is the unit test class the constants have been tweaked and modified to get errors to test the code.
So even if it's look like the other one it has some slight changes.

UI-DEN-1090-1 19 Dec 2019

fixed ...

UI-DEN-1090-1 19 Dec 2019

RESOLVED.

UI-DEN-1090-1 19 Dec 2019

Same here, These are aligned parameters as I mentioned to better identify the code bugs.

UI-DEN-704-1 20 Dec 2019

RESOLVED

DG-DEN-1125-1 10 Dec 2019

Body brackets should be on separate line per our coding standard.

HD-DEN-759-1 25 Nov 2019

What is the 2 for?

HD-DEN-759-1 15 Nov 2019

Explicitly explain 0, 1, and 2 in words.

HD-DEN-759-1 23 Nov 2019

Was this created by VectorCAST directly?

HD-DEN-759-1 15 Nov 2019

RESOLVED in CODE WALKTHROUGH.

HD-DEN-759-1 25 Nov 2019

General coding standard: space between arithmetic signs...

HD-DEN-759-1 15 Nov 2019

RESOLVED in CODE WALKTHROUGH.

HD-DEN-759-1 25 Nov 2019

Space between arithmetic sign and arguments.

HD-DEN-759-1 15 Nov 2019

RESOLVED in CODE WALKTHROUGH.

HD-DEN-759-1 25 Nov 2019

Space between arithmetic signs and arguments.

HD-DEN-759-1 15 Nov 2019

RESOLVED in CODE WALKTHROUGH.

HD-DEN-759-1 25 Nov 2019

Space between arithmetic signs and arguments.

HD-DEN-759-1 15 Nov 2019

RESOLVED in CODE WALKTHROUGH.

HD-DEN-759-1 25 Nov 2019

Space between arithmetic signs and arguments.

HD-DEN-759-1 15 Nov 2019

RESOLVED in CODE WALKTHROUGH.

HD-DEN-759-1 25 Nov 2019

Space between arithmetic signs and arguments.

HD-DEN-759-1 15 Nov 2019

RESOLVED in CODE WALKTHROUGH.

HD-DEN-759-1 25 Nov 2019

Space between arithmetic signs and arguments.

HD-DEN-759-1 15 Nov 2019

RESOLVED in CODE WALKTHROUGH.

UI-DEN-704-1 25 Nov 2019

eChild?

HD-DEN-759-1 15 Nov 2019

RESOLVED in CODE WALKTHROUGH.

HD-DEN-759-1 11 Nov 2019

Why were all these *.mk files removed from the repo? More importantly, how and why were they created to being with?

UI-DEN-704-1 25 Nov 2019

eChild?

HD-DEN-759-1 15 Nov 2019

RESOLVED in CODE WALKTHROUGH.

DIALIN-1 26 Nov 2019

Make 2000 a centralized parameter at the top of the file or class.

HD-DEN-759-1 03 Dec 2019

Same.

HD-SPR3-1 15 Nov 2019

This is CLASS C code that needs to be reviewed in a group setting.

DIALIN-1 06 Dec 2019

RESOLVED.

HD-DEN-759-1 20 Nov 2019

The other sys_main.c was outdated and I deleted it.

HD-DEN-759-1 20 Nov 2019

RESOLVED in CODE WALKTHROUGH.

DIALIN-1 06 Dec 2019

RESOLVED.

HD-DEN-759-1 20 Nov 2019

RESOLVED in CODE WALKTHROUGH.

DD-LDT-1873-4 02 Sep 2025

Removed.

HD-DEN-759-1 20 Nov 2019

RESOLVED in CODE WALKTHROUGH.

HD-DEN-759-1 20 Nov 2019

RESOLVED in CODE WALKTHROUGH.

HD-DEN-431-1 06 Jan 2020

setMibSPIBufferLength() checks the range.

HD-DEN-431-1 06 Jan 2020

Done!

HD-DEN-759-1 24 Nov 2019

This was something I temporarily added to handle the problem of trying to access RM46 registers while running in MinGW where such an attempt would cause a memory access error and crash the test case. Jim from VC finally gave me a way to do this from inside VC so I don't have to add this code - so I've since removed it.

HD-DEN-759-1 25 Nov 2019

I considered that. The flow rate ultimately needs to be converted to an unsigned PWM duty cycle for pump speed and a direction signal to the motor controller. This seemed to be a more natural way to achieve these ends. Also, with this approach there is no ambiguity about which direction is being commanded.