•  

Comment Results

Review Name Created Custom Fields Content
DIALIN-1 26 Nov 2019

Make 200 a centralized parameter at the top of the file or class.

DIALIN-1 30 Dec 2019

RESOLVED

DIALIN-1 17 Dec 2019

Used constant.

DIALIN-1 05 Dec 2019

There is no CRC implemented yet. Len can go all the way to 255. Each message is broken in 8-byte packets.

LEAHI-DD-FIRMWARE-LDT-2198-1 11 Sep 2025

removed headers

DIALIN-1 10 Dec 2019

The 5th byte is where the payload starts. I copied this from some code Leo had - but I agree we should clean this up a bit.

UI-DEN-1090-1 19 Dec 2019

RESOLVED.

DIALIN-1 11 Dec 2019

RESOLVED.

DIALIN-1 11 Dec 2019

RESOLVED.

UI-DEN-1090-1 19 Dec 2019

Convert 3 to LETTER_CONST and centralize all consts on top of code.

DIALIN-1 11 Dec 2019

RESOLVED.

DG-DEN-1125-1 06 Jan 2020

Done

HD-DEN-1404-1 16 Jan 2020

Done

UI-DEN-1090-1 19 Dec 2019

Fixed.

HD-DEN-431-1 06 Jan 2020

Done

UI-DEN-1090-1 19 Dec 2019

RESOLVED.

UI-DEN-1090-1 19 Dec 2019

RESOLVED.

UI-DEN-1090-1 19 Dec 2019

Purpose of extra spacing?

UI-DEN-1090-1 19 Dec 2019

Make this a LETTER_CONSTANT and centralize all of them on top of code.

HD-DEN-431-1 06 Jan 2020

Done!

UI-DEN-1090-1 19 Dec 2019

RESOLVED.

UI-DEN-1090-1 19 Dec 2019

RESOLVED.

DG-DEN-1125-1 07 Jan 2020

RESOLVED IN CODE WALKTHROUGH.

HD-DEN-431-1 07 Jan 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-704-1 20 Dec 2019

RESOLVED

UI-DEN-704-1 20 Dec 2019

RESOLVED

HD-DEN-431-1 30 Dec 2019

Consider moving these conversion functions to Utilities.c so any module can use them.

UI-DEN-704-1 05 Dec 2019

The message should be more along the lines that CAN interface is running...

DG-DEN-1125-1 11 Dec 2019

Space between = and 1000

DIALIN-1 26 Dec 2019

RESOLVED.

HD-DEN-431-1 07 Jan 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-431-1 30 Dec 2019

length should be range checked.

DIALIN-1 26 Nov 2019

How is the message Timeout!!!! related to received_message being equal to None?

HD-DEN-431-1 10 Jan 2020

RESOLVED in CODE WALKTHROUGH.

DIALIN-1 26 Nov 2019

We need to sleep, otherwise, we wouldn't let other tasks run.

LEAHI-TD-FIRMWARE-LDT-1903-8 24 Feb 2026

done

DIALIN-1 11 Dec 2019

RESOLVED.

DIALIN-1 13 Dec 2019

RESOLVED.

DIALIN-1 26 Nov 2019

How is the message Timeout!!!! related to received_message being equal to None?

HD-DEN-759-1 04 Dec 2019

RESOLVED in CODE WALKTHROUGH.

HD-DEN-759-1 26 Nov 2019

RESOLVED in CODE WALKTHROUGH.

HD-DEN-759-1 06 Dec 2019

What is the rule for arguments between [ ] ? Does it need spacing like ( ) ?

HD-DEN-759-1 26 Nov 2019

RESOLVED in CODE WALKTHROUGH.

DIALIN-1 30 Dec 2019

RESOLVED

UI-DEN-1396-1 09 Jan 2020

Indent the cases for legibility.

DIALIN-1 27 Nov 2019

payload is constrainted by definition as unsigned number from 0 to 255.

DIALIN-1 12 Dec 2019

RESOLVED.

DIALIN-1 13 Dec 2019

RESOLVED.

DIALIN-1 05 Dec 2019

1) If you are referring to keyword arguments, it is allowed per our code standards and it is a standard in python.
2) Documentation for the Messaging list is being done in the excel file that you are referring. You will find that channel IDs are located DenaliChannels class. We need to do some touch ups in the excel document
3) Having a line after each if blocks is part of pep8.

DIALIN-1 03 Dec 2019

reset is the integer value passed into the method. rst is the integer value converted to a byte array to be concatenated into the message.