•  

Comment Results

Review Name Created Custom Fields Content
DIALIN-1 13 Dec 2019

Blood flow can be negative, hence, it is handled.

HD-DEN-1906-1 02 Mar 2020

This is a doxygen "end of group" comment.

DIALIN-1 26 Nov 2019

Is the payload length constrained by its definition or it can accidentally become negative?

DIALIN-1 13 Dec 2019

RESOLVED.

DIALIN-1 10 Dec 2019

Done.

UI-DEN-608-4 04 Dec 2019

Same comment as above, make error more descriptive: Error: CanDevice cannot connect.

DG-DEN-1125-1 07 Jan 2020

RESOLVED IN CODE WALKTHROUGH.

DG-DEN-1125-1 11 Dec 2019

Done

DG-DEN-1125-1 30 Dec 2019

Remove extra line.

DIALIN-1 26 Nov 2019

""" Stop listening to the can interface """

UI-DEN-1090-1 19 Dec 2019

Why so much space?

DG-DEN-1125-1 16 Dec 2019

In the next DG story. I would line up DG with its implementation better.

HD-DEN-431-1 06 Jan 2020

initRTC() only sets the self test to start so it does not have to be in the beginning.

DIALIN-1 17 Dec 2019

RESOLVED

HD-DEN-1404-1 16 Jan 2020

I think the macro does the ';' so you don't need one.

DIALIN-1 17 Dec 2019

RESOLVED

HD-DEN-431-1 06 Jan 2020

Length is range checked in the above else if statement.

UI-DEN-1090-1 19 Dec 2019

Is this a magic number?

UI-DEN-1090-1 19 Dec 2019

Magic number?

DG-DEN-1125-1 26 Dec 2019

Add *.pyc files to .gitignore.

UI-DEN-608-4 04 Dec 2019

I believe these cases need indentation

UI-DEN-1090-1 19 Dec 2019

fixed...

DG-DEN-1125-1 07 Jan 2020

RESOLVED IN CODE WALKTHROUGH.

DG-DEN-1125-1 11 Dec 2019

Remove Off Button from DG.

UI-DEN-1090-1 19 Dec 2019

Fixed

UI-DEN-1090-1 19 Dec 2019

Comments take space between ; and //, also make comments consistent.

UI-DEN-1090-1 19 Dec 2019

What CONST is this 3? Replace with LETTER_CONST and centralize all of them on top of code.

UI-DEN-1090-1 19 Dec 2019

Again, what is the reason for inconsistent spacing throughout the entire code base?

DD-LDT-1873-4 02 Sep 2025

Done.

DG-DEN-1125-1 11 Dec 2019

This method is left empty. Purpose?

DG-DEN-1125-1 07 Jan 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-431-1 07 Jan 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-431-1 07 Jan 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-431-1 30 Dec 2019

Local variables should be declared at top of scope.

HD-DEN-431-1 07 Jan 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-431-1 30 Dec 2019

Definitions should come before function prototypes.

HD-DEN-431-1 07 Jan 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-431-1 07 Jan 2020

RESOLVED IN CODE WALKTHROUGH

HD-DEN-431-1 07 Jan 2020

Move the local variable into the scope.

DIALIN-ACK-1 01 Apr 2020

RESOLVED.

DG-RESTART-1 26 Feb 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-1312-1 10 Jan 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-1396-1 13 Jan 2020

Files has been modified many times manuallu on my branch as you asked a week or toow before 2020 and by Dara's script on master on 2019 and 2020.
It might be me merging files from my branch to master with 2019, since I think his script is running only on master branches.

LEAHI-DD-FIRMWARE-LDT-2198-1 11 Sep 2025

renamed.

UI-DEN-1396-1 13 Jan 2020

Files has been modified many times manuallu on my branch as you asked a week or toow before 2020 and by Dara's script on master on 2019 and 2020.
It might be me merging files from my branch to master with 2019, since I think his script is running only on master branches.

HD-DEN-1906-1 02 Mar 2020

Done.

UI-DEN-1396-1 13 Jan 2020

Files has been modified many times manuallu on my branch as you asked a week or toow before 2020 and by Dara's script on master on 2019 and 2020.
It might be me merging files from my branch to master with 2019, since I think his script is running only on master branches.

HD-DEN-1404-1 16 Jan 2020

Done

UI-DEN-1396-1 13 Jan 2020

Files has been modified many times manuallu on my branch as you asked a week or toow before 2020 and by Dara's script on master on 2019 and 2020.
It might be me merging files from my branch to master with 2019, since I think his script is running only on master branches.

UI-DEN-1396-1 14 Jan 2020

RESOLVED.