•  

Comment Results

Review Name Created Custom Fields Content
DIALIN-ACK-1 01 Apr 2020

RESOLVED.

HD-DEN-1312-1 10 Jan 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-1404-1 16 Jan 2020

Done

HD-DEN-1906-1 02 Mar 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-1404-1 16 Jan 2020

True, but for consistency, I put it

UI-DEN-1396-1 13 Jan 2020

Files has been modified many times manuallu on my branch as you asked a week or toow before 2020 and by Dara's script on master on 2019 and 2020.
It might be me merging files from my branch to master with 2019, since I think his script is running only on master branches.

HD-DEN-1906-1 02 Mar 2020

Remove extra lines at EOF.

UI-DEN-1396-1 13 Jan 2020

Files has been modified many times manuallu on my branch as you asked a week or toow before 2020 and by Dara's script on master on 2019 and 2020.
It might be me merging files from my branch to master with 2019, since I think his script is running only on master branches.

HD-DEN-1404-1 16 Jan 2020

Done

UI-DEN-1396-1 13 Jan 2020

Files has been modified many times manuallu on my branch as you asked a week or toow before 2020 and by Dara's script on master on 2019 and 2020.
It might be me merging files from my branch to master with 2019, since I think his script is running only on master branches.

HD-DEN-1404-1 15 Jan 2020

Put test code in a #ifdef blocks so it's clearer that it's test code and it's easier to turn on/off during development and it's easier to find and remove later.

HD-DEN-1906-1 02 Mar 2020

Remove extra lines at EOF.

HD-DEN-1404-1 16 Jan 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-1396-1 13 Jan 2020

Files has been modified many times manuallu on my branch as you asked a week or toow before 2020 and by Dara's script on master on 2019 and 2020.
It might be me merging files from my branch to master with 2019, since I think his script is running only on master branches.

HD-DEN-1404-1 16 Jan 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-1396-1 13 Jan 2020

Files has been modified many times manuallu on my branch as you asked a week or toow before 2020 and by Dara's script on master on 2019 and 2020.
It might be me merging files from my branch to master with 2019, since I think his script is running only on master branches.

HD-DEN-1404-1 15 Jan 2020

There is a similar #define in common.h. Use that one.

HD-DEN-1404-1 15 Jan 2020

I think this subtraction is backward. If range reduced control signal to maximum, windupError will be negative here and will end up making errorSum larger.

UI-DEN-1396-1 14 Jan 2020

RESOLVED.

HD-DEN-1404-1 16 Jan 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-1396-1 14 Jan 2020

RESOLVED.

UI-DEN-1396-1 13 Jan 2020
  • We are not at release point.
  • Some comments are Tests codes which will be (un)comment back/forth
  • Some codes are codes to help developer as an example of how to use the code in that specific section or matter.
  • Some codes are placeholder and will be removed when the actual implementation is done.

  • In this case it's a usage help.
UI-DEN-1396-1 09 Jan 2020

Date change?

UI-DEN-1396-1 09 Jan 2020

Same comment here.

UI-DEN-1434-1 10 Mar 2020

Remove extra line at EOF.

HD-DEN-1404-1 16 Jan 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-1404-1 16 Jan 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-1404-1 15 Jan 2020

semicolon missing

UI-DEN-1434-1 10 Mar 2020

applied .

HD-DEN-1404-1 17 Jan 2020

RESOLVED in CODE WALKTHROUGH

HD-DEN-1404-1 15 Jan 2020

I know I named this, but I'm regretting it. Outlet pump is not controlled per flow sensor like the others. I think DialOutUF or DialOutLoadCells or DialOutVolume would be better.

UI-DEN-1396-1 15 Jan 2020

RESOLVED.

HD-DEN-1404-1 17 Jan 2020

RESOLVED in CODE WALKTHROUGH

UI-DEN-1396-1 10 Jan 2020

We need to provide better description of each class at the beginning in order to make sense of the code.

UI-DEN-1434-1 10 Mar 2020

Space.

UI-DEN-1396-1 10 Jan 2020

I looked for time outs when a message is sent, not clear if it is implemented or not.

UI-DEN-1710-1 22 Jan 2020

OCD?
They where not aligned.

HD-DEN-431-BUG-FIXES-1 14 Feb 2020

RESOLVED in CODE WALKTHROUGH.

DG-RESTART-1 24 Feb 2020

Why removed?

DG-RESTART-1 25 Feb 2020

Removed for now.

DG-RESTART-1 26 Feb 2020

Looks like POSTs were being skipped. Fixed.

DG-RESTART-1 26 Feb 2020

Done.

DG-RESTART-1 26 Feb 2020

Done.

DG-RESTART-1 24 Feb 2020

What are we doing in transitionToStandbyMode?

DG-RESTART-1 26 Feb 2020

RESOLVED in CODE WALKTHROUGH.

DG-RESTART-1 24 Feb 2020

Is this module intended to process all sensor data or just load cells? If just load cells, this module seems too broadly named. If all sensor data, are you sure you want to process all sensor data in one module?

DG-RESTART-1 24 Feb 2020

What is this comment for?

DG-RESTART-1 28 Feb 2020

RESOLVED IN CODE WALKTHROUGH.

HD-DEN-1906-1 02 Mar 2020

This is a doxygen "end of group" comment.

HD-DEN-1906-1 02 Mar 2020

Needed for doxygen.