•  

Comment Results

Review Name Created Custom Fields Content
DG-RESTART-1 24 Feb 2020

What are these comments for?

UI-DEN-1434-1 10 Mar 2020

RESOLVED.

DG-RESTART-1 27 Feb 2020

Align numbers.

UI-DEN-1434-1 10 Mar 2020

Extra line needed at EOF.

HD-DEN-1906-1 02 Mar 2020

Removed.

UI-DEN-2086-1 06 Mar 2020

Remove extra line.

UI-DEN-2086-1 10 Mar 2020

RESOLVED.

UI-DEN-1434-1 11 Mar 2020

Should be 0, 1, 2, 3
Index 4 is out of bound.

UI-DEN-1434-1 11 Mar 2020

RESOLVED

HD-DEN-1778-1 19 Mar 2020

This #define is used for checking the number queues available. I changed it to MIN_QUEUE_NEEDED_FOR_DATA_LOG

HD-DEN-1778-1 19 Mar 2020

I didn't remove it but it only goes to fault if the state machine ends up in default. In that case, it set the SW fault alarm and go to default. Should I go to Idle instead?

HD-DEN-1778-1 19 Mar 2020

Changed it hours.

HD-DEN-1778-1 19 Mar 2020

It was my mistake. Fixed it.

HD-DEN-1778-1 17 Mar 2020

Should we get this job if the queue was empty above?

HD-DEN-1778-1 17 Mar 2020

Shouldn't this be checking if queue is empty?

HD-DEN-4308-3 05 Oct 2020

Done

HD-DEN-1906-1 02 Mar 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-1312-1 10 Jan 2020

Remove blank line.

UI-DEN-1396-1 13 Jan 2020

Files has been modified many times manuallu on my branch as you asked a week or toow before 2020 and by Dara's script on master on 2019 and 2020.
It might be me merging files from my branch to master with 2019, since I think his script is running only on master branches.

UI-DEN-1396-1 14 Jan 2020

RESOLVED.

UI-DEN-1396-1 09 Jan 2020

Date change?

HD-DEN-1404-1 16 Jan 2020

Done

UI-DEN-1396-1 14 Jan 2020

RESOLVED.

UI-DEN-1396-1 09 Jan 2020

Date change?

HD-DEN-1404-1 16 Jan 2020

Done.

UI-DEN-1396-1 15 Jan 2020

RESOLVED.

HD-DEN-1906-1 02 Mar 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-1396-1 15 Jan 2020

RESOLVED.

HD-DEN-1404-1 16 Jan 2020

Done

UI-DEN-1396-1 15 Jan 2020

RESOLVED.

HD-DEN-1404-1 16 Jan 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-2087-1 22 Apr 2020

RESOLVED.

HD-DEN-1404-1 16 Jan 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-1404-1 17 Jan 2020

RESOLVED in CODE WALKTHROUGH

DG-RESTART-1 24 Feb 2020

You will likely also need a function for other DG modules to get the current load cell weights. Some DG features like disinfection will probably require load cell feedback.

HD-DEN-431-DIA-1 20 Jan 2020

Needs function header.

HD-DEN-1906-1 02 Mar 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-1434-1 10 Mar 2020

applied.

UI-DEN-1434-1 10 Mar 2020

Remove unused #defines.

DG-RESTART-1 26 Feb 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-1434-1 10 Mar 2020

Add space between two if conditions.

DG-RESTART-1 26 Feb 2020

Because code got moved to common.

UI-DEN-1434-1 10 Mar 2020

Same here.

DG-RESTART-1 26 Feb 2020

RESOLVED in CODE WALKTHROUGH.

DG-RESTART-1 24 Feb 2020

Why removed?

DG-RESTART-1 25 Feb 2020

Good idea.
Make changes accordingly. Please review again.

DG-RESTART-1 24 Feb 2020

Consolidate all includes.

DG-RESTART-1 24 Feb 2020

Why 2 structures that appear to hold the same 4 load cell values?

DG-RESTART-1 26 Feb 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-2086-1 02 Mar 2020

Should these be equal?