•  

Comment Results

Review Name Created Custom Fields Content
DG-RESTART-1 28 Feb 2020

Done.

DG-RESTART-1 27 Feb 2020

Remove extra line at EOF.

UI-DEN-1434-1 10 Mar 2020

applied .

UI-DEN-1434-1 10 Mar 2020

Thanks.
Applied.

UI-DEN-1434-1 10 Mar 2020

Add space.

UI-DEN-1434-1 10 Mar 2020

Add extra line at EOF.

UI-DEN-1434-1 11 Mar 2020

RESOLVED

UI-DEN-1434-1 11 Mar 2020

it is in a loop with int i as loop variable.
inner loop should not use the same even if the outer loop variable in not use in inner.

HD-DEN-1778-1 17 Mar 2020

Looks like we're going to queue the job even if the queue was full. Seems wrong.

HD-DEN-1778-1 20 Mar 2020

Please elaborate on the comment related to //< No reason.

HD-DEN-1778-1 19 Mar 2020

Sean Nash Could you please respond?

HD-DEN-1778-1 19 Mar 2020

Done

HD-DEN-1778-1 19 Mar 2020

What if the queue is full, what does the caller of this function see? Just status = FALSE? Is this acceptable by the caller?

HD-DEN-1778-1 19 Mar 2020

What are we using TI's code generation tool for? (to generate what code?)

HD-DEN-1778-1 23 Mar 2020

Done.

HD-DEN-1778-1 23 Mar 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-1778-1 19 Mar 2020

This is dangerous, there should always be a reason why any action is rejected.

HD-DEN-1778-1 23 Mar 2020

Count needs thread protection too. Check enqueue for same issue.

HD-DEN-1778-1 23 Mar 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-1778-1 17 Mar 2020

Why is this a byte pointer instead of a SERVICE_DATA_T pointer?

HD-DEN-1778-1 23 Mar 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-1778-1 23 Mar 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-1778-1 17 Mar 2020

We are storing events in this one log, not data logs.

HD-DEN-2390-1 30 Mar 2020

Will do

UI-DEN-1396-1 14 Jan 2020

There is a line at the end of the file (always should be since the QtCreator add one anyway) seems like the Crucible is not showing it !!!

HD-DEN-1404-1 16 Jan 2020

Done

UI-DEN-1396-1 15 Jan 2020

RESOLVED.

HD-DEN-1404-1 15 Jan 2020

This change implies a lot of changes in vectorcast, even breaking most test. I believe the fact that we have a dialout and dialin is good enough to indicate which pump we are referring to. I suggest leaving it as is.

UI-DEN-1396-1 13 Jan 2020

Very good question.
I put the classes in threads by the producer consumer idea.
The class FrameInterface is a mediator between the two logics you explained.
So we have three threads :

CanInterface : Gets "Frames (QCanBusFrame)", directly from can device queue them and notify the FrameInterface.
FrameInterface : Gets "Frames" from CanInterface convert them into "array of bytes (QByteArray)" for each channel.
MessageDispatcher : Gets "Array of Bytes (QByteArray)" and [Build] them as "Messages" and wait for further data to make the Messages complete and then [Interpret/Validate] them and dispatch it to the responsible class.

So I have three threads.
It can be 2 but I preferred to put the mediator in its own thread.
I hope it explains.

UI-DEN-1396-1 13 Jan 2020

Files has been modified many times manuallu on my branch as you asked a week or toow before 2020 and by Dara's script on master on 2019 and 2020.
It might be me merging files from my branch to master with 2019, since I think his script is running only on master branches.

UI-DEN-2087-1 22 Apr 2020

RESOLVED.

UI-DEN-1396-1 13 Jan 2020

Files has been modified many times manuallu on my branch as you asked a week or toow before 2020 and by Dara's script on master on 2019 and 2020.
It might be me merging files from my branch to master with 2019, since I think his script is running only on master branches.

HD-DEN-1404-1 16 Jan 2020

So this function will be called at a set time interval? What is that interval? Should probably mention it in the function brief as a requirement for the function caller.

UI-DEN-1396-1 13 Jan 2020

Files has been modified many times manuallu on my branch as you asked a week or toow before 2020 and by Dara's script on master on 2019 and 2020.
It might be me merging files from my branch to master with 2019, since I think his script is running only on master branches.

HD-DEN-1404-1 16 Jan 2020

True, my original idea is not to create big math operation. I thought of signal as unsigned, most of them are. I think we could change it, but not in this round. I created this module for DG. When I get back to using it, we can move it to float.

UI-DEN-1396-1 13 Jan 2020

Files has been modified many times manuallu on my branch as you asked a week or toow before 2020 and by Dara's script on master on 2019 and 2020.
It might be me merging files from my branch to master with 2019, since I think his script is running only on master branches.

UI-DEN-1396-1 13 Jan 2020

Files has been modified many times manuallu on my branch as you asked a week or toow before 2020 and by Dara's script on master on 2019 and 2020.
It might be me merging files from my branch to master with 2019, since I think his script is running only on master branches.

UI-DEN-1396-1 13 Jan 2020

namespaces don't have indentation because it would be redundant and almost all the files have namespaces.

HD-DEN-1404-1 16 Jan 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-1396-1 15 Jan 2020

RESOLVED.

UI-DEN-1396-1 09 Jan 2020

Remove commented section.

UI-DEN-1396-1 13 Jan 2020
  • We are not at release point.
  • Some comments are Tests codes which will be (un)comment back/forth
  • Some codes are codes to help developer as an example of how to use the code in that specific section or matter.
  • Some codes are placeholder and will be removed when the actual implementation is done.


~ In this case it's the placeholder and is already removed in "Advanced Treatment" feature.
.
.

UI-DEN-1396-1 14 Jan 2020

RESOLVED.

UI-DEN-1396-1 09 Jan 2020

Changed date?

UI-DEN-1396-1 09 Jan 2020

Changed date?

UI-DEN-1396-1 09 Jan 2020

Date change?

UI-DEN-1396-1 09 Jan 2020

Date change?

HD-DEN-1404-1 16 Jan 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-1404-1 16 Jan 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-1404-1 15 Jan 2020

You have two magic numbers, I think we need #define for them