•  

Comment Results

Review Name Created Custom Fields Content
UI-DEN-2086-1 02 Mar 2020

RESOLVED

UI-DEN-1434-1 10 Mar 2020

It has EEL, Extra Empty Lines are not necessary shown up in crucible.

HD-DEN-431-DIA-1 20 Jan 2020

Needs function header

HD-DEN-1757-1 20 Jan 2020

Needs removal of UART?

HD-DEN-1757-1 22 Jan 2020

How did this even compile?

UI-DEN-1434-1 10 Mar 2020

Before the first if.

UI-DEN-1710-1 22 Jan 2020

RESOLVED.

DG-RESTART-1 24 Feb 2020

The LOAD_CELL_REPORT_PERIOD is 10 and this function gets called every 10ms - so this function produces and broadcasts a new set of averaged load cell weights every 100ms based on last 10 samples. This is what we talked about, but it took me a while to convince myself ot that. And if the priority task timing changes it will all fall apart.
There is a TASK_PRIORITY_INTERVAL defined in TaskPriority.h as 10 (10ms interval) - if the task timing changes, this definition would also be changed.
I would define LOAD_CELL_REPORT_PERIOD as ( 100 / TASK_PRIORITY_INTERVAL ) to couple it with task timing and clarify the desired report period is 100ms. I would also make a separate #define LOAD_CELL_SAMPLES_TO_AVERAGE and define it to be same as LOAD_CELL_REPORT_PERIOD just to clarify its other purpose (used in SensorProcess.h where it's folded into conversion factor).

DG-RESTART-1 24 Feb 2020

Space?

UI-DEN-1434-1 10 Mar 2020

Some of the comments about the spacing are in our c coding standards and not in our C++ coding standard.
From the beginning we discussed that these may/should be different.

DG-RESTART-1 26 Feb 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-1971-1 26 Feb 2020
UI-DEN-1434-1 10 Mar 2020

applied regardless.

UI-DEN-1971-1 26 Feb 2020
DG-RESTART-1 28 Feb 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-1434-1 10 Mar 2020

There is one.
Not visible here.

UI-DEN-1434-1 10 Mar 2020

RESOLVED.

UI-DEN-1434-1 10 Mar 2020

Add space before if condition.

UI-DEN-1434-1 10 Mar 2020

RESOLVED.

UI-DEN-1434-1 10 Mar 2020

RESOLVED.

UI-DEN-2087-1 22 Apr 2020

RESOLVED.

HD-DEN-1404-1 16 Jan 2020

Done

HD-DEN-1906-1 02 Mar 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-1404-1 16 Jan 2020

Because they are accessed from different interrupts functions.

HD-DEN-1312-1 10 Jan 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-1404-1 16 Jan 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-431-DIA-1 20 Jan 2020

Done

UI-DEN-2086-1 02 Mar 2020

uint QVariant::toUInt(bool *ok = nullptr) const
Returns the variant as an unsigned int if the variant has userType() QMetaType::UInt, QMetaType::Bool, QMetaType::QByteArray, QMetaType::QChar, QMetaType::Double, QMetaType::Int, QMetaType::LongLong, QMetaType::QString, or QMetaType::ULongLong; otherwise returns 0.

0 is fine with me.

UI-DEN-1396-1 13 Jan 2020

Regarding Sapna's request created a Class and set of cpp/h files for each feature so this generally named has been changed to "tst_canbus"

HD-DEN-431-DIA-1 21 Jan 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-1396-1 13 Jan 2020

Files has been modified many times manuallu on my branch as you asked a week or toow before 2020 and by Dara's script on master on 2019 and 2020.
It might be me merging files from my branch to master with 2019, since I think his script is running only on master branches.

UI-DEN-1396-1 13 Jan 2020

Files has been modified many times manuallu on my branch as you asked a week or toow before 2020 and by Dara's script on master on 2019 and 2020.
It might be me merging files from my branch to master with 2019, since I think his script is running only on master branches.

DIALIN-PENDING-APPROAVAL-1 22 Jan 2020

RESOLVED.

UI-DEN-1396-1 14 Jan 2020

RESOLVED.

UI-DEN-1396-1 14 Jan 2020

RESOLVED.

UI-DEN-1396-1 09 Jan 2020

Date change?

UI-DEN-1396-1 09 Jan 2020

Date change?

UI-DEN-1434-1 10 Mar 2020

RESOLVED.

UI-DEN-1396-1 14 Jan 2020

These are necessary QTest methods that I don't have any implementation for them yet.
I didn't like the fact that although I don't have anything implemented, it's still counts as a successful test, so I comment them out for now until I have an implementation for them.
In general I prefer not to remove thme to keep them as part of the standard QtTest class.

DG-RESTART-1 26 Feb 2020

Done.

UI-DEN-1396-1 15 Jan 2020

RESOLVED.

HD-DEN-1404-1 15 Jan 2020

Please leave space in paranthesis

DG-RESTART-1 26 Feb 2020

Because code got moved to common

UI-DEN-1434-1 10 Mar 2020

This value came out of no where.
It may change later and I don't currently know what value preferred.

DG-RESTART-1 26 Feb 2020

RESOLVED in CODE WALKTHROUGH.

DG-RESTART-1 24 Feb 2020

Why removed?

DG-RESTART-1 26 Feb 2020

Done.

UI-DEN-1434-1 10 Mar 2020

applied regardless.

DG-RESTART-1 26 Feb 2020

RESOLVED in CODE WALKTHROUGH.

DG-RESTART-1 26 Feb 2020

This file was in the wrong directory.