•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-1906-1 02 Mar 2020

This is a doxygen "end of group" comment.

UI-DEN-1434-1 10 Mar 2020

RESOLVED.

UI-DEN-1434-1 10 Mar 2020

Add space between two if conditions.

UI-DEN-1434-1 10 Mar 2020

RESOLVED.

UI-DEN-1434-1 11 Mar 2020

RESOLVED

UI-DEN-1434-1 11 Mar 2020

Should be 0, 1, 2, 3
Index 4 is out of bound.

UI-DEN-1434-1 11 Mar 2020

RESOLVED

HD-DEN-1778-1 17 Mar 2020

I thought the mfg. record would be stored in EEPROM (sector 0)?

DG-DEN-4217-1 17 Aug 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-1404-1 16 Jan 2020

Done

HD-DEN-1906-1 02 Mar 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-431-1 10 Jan 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-1404-1 16 Jan 2020

Done

UI-DEN-1396-1 13 Jan 2020

Files has been modified many times manuallu on my branch as you asked a week or toow before 2020 and by Dara's script on master on 2019 and 2020.
It might be me merging files from my branch to master with 2019, since I think his script is running only on master branches.

HD-DEN-1404-1 15 Jan 2020

Move this (and any other definitions that may be useful for other modules) to common.h.

UI-DEN-1396-1 14 Jan 2020

RESOLVED.

UI-DEN-1396-1 09 Jan 2020

Date change?

HD-DEN-1404-1 15 Jan 2020

Semicolon is missing

UI-DEN-1396-1 14 Jan 2020

RESOLVED.

UI-DEN-1396-1 09 Jan 2020

Same comment here.

HD-DEN-1404-1 15 Jan 2020

I would probably use a #define for the 0.0

UI-DEN-1396-1 14 Jan 2020

RESOLVED.

UI-DEN-1396-1 09 Jan 2020

Same comment here.

UI-DEN-1396-1 14 Jan 2020

These are necessary QTest methods that I don't have any implementation for them yet.
I didn't like the fact that although I don't have anything implemented, it's still counts as a successful test, so I comment them out for now until I have an implementation for them.
In general I prefer not to remove thme to keep them as part of the standard QtTest class.

HD-DEN-1404-1 17 Jan 2020

RESOLVED in CODE WALKTHROUGH

UI-DEN-1396-1 14 Jan 2020

These are necessary QTest methods that I don't have any implementation for them yet.
I didn't like the fact that although I don't have anything implemented, it's still counts as a successful test, so I comment them out for now until I have an implementation for them.
In general I prefer not to remove thme to keep them as part of the standard QtTest class.

HD-DEN-1404-1 17 Jan 2020

RESOLVED in CODE WALKTHROUGH

HD-DEN-1404-1 15 Jan 2020

Should have static (private) function to handle each of these states.

HD-DEN-1757-1 20 Jan 2020

Done.

UI-DEN-1396-1 15 Jan 2020

RESOLVED.

UI-DEN-1396-1 15 Jan 2020

RESOLVED.

UI-DEN-1396-1 15 Jan 2020

RESOLVED.

HD-DEN-1404-1 15 Jan 2020

I suggest implementing them when they are needed.

UI-DEN-1434-1 11 Mar 2020

RESOLVED

DIALIN-PENDING-APPROAVAL-1 22 Jan 2020

Remove extra blank lines

UI-DEN-1710-1 22 Jan 2020

Remove commented lines.

UI-DEN-1971-1 26 Feb 2020
UI-DEN-1434-1 10 Mar 2020

This is not unused.
This is for debugging if un-commented.

UI-DEN-1971-1 27 Feb 2020

RESOLVED.

UI-DEN-1971-1 26 Feb 2020

Remove extra line.

UI-DEN-3253-1 23 Jun 2020

Done

UI-DEN-1434-1 10 Mar 2020

Although they are doing almost the same thing but one is for driver buffer and this one is for application buffer and are not necessarily the same.

DG-RESTART-1 24 Feb 2020

Remove extra line at EOF.

DG-RESTART-1 25 Feb 2020

This doxygen comment (group end) looks out of place - should be at the bottom of the module after all code. What should be up here is a group start. Check HD code for examples.

DG-RESTART-1 24 Feb 2020

Remove all UART-related debugging ports (but the one connected to FPGA). This is planned to be done in DEN S15.

DG-RESTART-1 26 Feb 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-1434-1 10 Mar 2020

RESOLVED.

DG-RESTART-1 26 Feb 2020

RESOLVED in CODE WALKTHROUGH.

DG-RESTART-1 26 Feb 2020

Done.

DG-RESTART-1 24 Feb 2020

Why removed?