•  

Comment Results

Review Name Created Custom Fields Content
DG-RESTART-1 26 Feb 2020

This file was in the wrong directory. All the corresponding extensions that need to be ignored, are added to the .gitignore of the firmware or VectorCAST.

UI-DEN-1396-1 13 Jan 2020

Files has been modified many times manuallu on my branch as you asked a week or toow before 2020 and by Dara's script on master on 2019 and 2020.
It might be me merging files from my branch to master with 2019, since I think his script is running only on master branches.

HD-DEN-1404-1 16 Jan 2020

comment should say "to stop"

UI-DEN-1396-1 13 Jan 2020

Files has been modified many times manuallu on my branch as you asked a week or toow before 2020 and by Dara's script on master on 2019 and 2020.
It might be me merging files from my branch to master with 2019, since I think his script is running only on master branches.

HD-DEN-1404-1 15 Jan 2020

I've been putting module initialize functions first throughout HD code. For consistency, please move to top.

UI-DEN-1396-1 13 Jan 2020

Files has been modified many times manuallu on my branch as you asked a week or toow before 2020 and by Dara's script on master on 2019 and 2020.
It might be me merging files from my branch to master with 2019, since I think his script is running only on master branches.

HD-DEN-1404-1 15 Jan 2020

Why not just go to switch directly and if there is no change to the current state, exit?

UI-DEN-1396-1 13 Jan 2020

Files has been modified many times manuallu on my branch as you asked a week or toow before 2020 and by Dara's script on master on 2019 and 2020.
It might be me merging files from my branch to master with 2019, since I think his script is running only on master branches.

HD-DEN-1906-1 02 Mar 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-1396-1 14 Jan 2020

RESOLVED.

HD-DEN-1906-1 02 Mar 2020

Remove extra line at EOF.

UI-DEN-1396-1 14 Jan 2020

RESOLVED.

UI-DEN-1396-1 09 Jan 2020

Date change?

HD-DEN-1906-1 02 Mar 2020

Remove.

UI-DEN-1396-1 14 Jan 2020

RESOLVED.

UI-DEN-1396-1 09 Jan 2020

Date change?

HD-DEN-1906-1 02 Mar 2020

Remove.

UI-DEN-1396-1 14 Jan 2020

RESOLVED.

HD-DEN-1906-1 02 Mar 2020

Remove.

UI-DEN-1396-1 14 Jan 2020

RESOLVED.

UI-DEN-1396-1 09 Jan 2020

Why back to 2019? We are in 2020.

HD-DEN-1906-1 02 Mar 2020

Extra line.

UI-DEN-1396-1 14 Jan 2020

updated.

HD-DEN-1906-1 02 Mar 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-1906-1 02 Mar 2020

Remove.

DIALIN-PENDING-APPROAVAL-1 22 Jan 2020

RESOLVED.

UI-DEN-1396-1 09 Jan 2020

Same comment here, indent the cases for legibility.

HD-DEN-1757-1 22 Jan 2020

RESOLVED in CODE WALKTHROUGH.

DIALIN-PENDING-APPROAVAL-1 22 Jan 2020

RESOLVED.

UI-DEN-1710-1 22 Jan 2020

RESOLVED.

UI-DEN-1710-1 22 Jan 2020

RESOLVED.

UI-DEN-1434-1 10 Mar 2020

Add space.

HD-DEN-431-BUG-FIXES-1 14 Feb 2020

RESOLVED in CODE WALKTHROUGH.

DG-RESTART-1 28 Feb 2020

Done.

UI-DEN-1434-1 10 Mar 2020

Add space between two if conditions.

DG-RESTART-1 25 Feb 2020

The scope on these variables is too narrow. You will want to make latest load cell values available to other modules via a "get" function and you'll need to move these up to module level to do that. Also, generally speaking, it is difficult to unit test functions that have static variables declared in them so I would not recommend doing this.

DG-RESTART-1 24 Feb 2020

If related to UART, must be removed.

DG-RESTART-1 24 Feb 2020

Must get rid of UART, it is planned for DEN S15.

DG-RESTART-1 24 Feb 2020

Where is prototype for execSensorProcess()?

UI-DEN-1434-1 10 Mar 2020

finally with two ls.

DG-RESTART-1 26 Feb 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-1434-1 10 Mar 2020

RESOLVED.

DG-RESTART-1 26 Feb 2020

It's because code got moved to common

DG-RESTART-1 24 Feb 2020

Why removed?

UI-DEN-1434-1 10 Mar 2020

Space between cases, everywhere.

DG-RESTART-1 26 Feb 2020

RESOLVED in CODE WALKTHROUGH.

DG-RESTART-1 24 Feb 2020

We need to get rid of UART. It is planned for DEN S15.

UI-DEN-1434-1 10 Mar 2020

RESOLVED.

UI-DEN-1434-1 11 Mar 2020

RESOLVED

UI-DEN-1434-1 11 Mar 2020

Please put range check.