•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-4211-1 28 Aug 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-1404-1 16 Jan 2020

Done

HD-DEN-431-1 10 Jan 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-1906-1 02 Mar 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-1396-1 15 Jan 2020

Very good point.
Regarding our discussion I understood.
I don't timeout and don't wait for a response back.
But I'm going to have that when I'm done with the ACK/BACK.

UI-DEN-1396-1 13 Jan 2020

Files has been modified many times manuallu on my branch as you asked a week or toow before 2020 and by Dara's script on master on 2019 and 2020.
It might be me merging files from my branch to master with 2019, since I think his script is running only on master branches.

HD-DEN-1906-1 02 Mar 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-1396-1 13 Jan 2020

Files has been modified many times manuallu on my branch as you asked a week or toow before 2020 and by Dara's script on master on 2019 and 2020.
It might be me merging files from my branch to master with 2019, since I think his script is running only on master branches.

HD-DEN-1404-1 16 Jan 2020

Yes

UI-DEN-1396-1 13 Jan 2020

Files has been modified many times manuallu on my branch as you asked a week or toow before 2020 and by Dara's script on master on 2019 and 2020.
It might be me merging files from my branch to master with 2019, since I think his script is running only on master branches.

HD-DEN-1404-1 16 Jan 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-1396-1 13 Jan 2020
  • We are not at release point.
  • Some comments are Tests codes which will be (un)comment back/forth
  • Some codes are codes to help developer as an example of how to use the code in that specific section or matter.
  • Some codes are placeholder and will be removed when the actual implementation is done.
    .
    .
    ~ In this case it's Test Code.
    .
    .
UI-DEN-1396-1 09 Jan 2020

Same comment here.

HD-DEN-1404-1 15 Jan 2020

Please leave space in paranthesis

UI-DEN-1396-1 14 Jan 2020

RESOLVED.

UI-DEN-1396-1 14 Jan 2020

RESOLVED.

UI-DEN-1396-1 09 Jan 2020

Date change?

UI-DEN-1396-1 14 Jan 2020

RESOLVED.

HD-DEN-1404-1 17 Jan 2020

RESOLVED in CODE WALKTHROUGH

UI-DEN-1396-1 14 Jan 2020

RESOLVED.

HD-DEN-1404-1 15 Jan 2020

Should be more data published (rotor speed, motor speed, motor controller speed, motor controller current) like other pumps.

UI-DEN-1396-1 14 Jan 2020

Updated in "38e28c4"

HD-DEN-431-DIA-1 20 Jan 2020

Done

UI-DEN-1396-1 14 Jan 2020

You are absolutely right.
I forgot the classes details description.
Added details.

DIALIN-PENDING-APPROAVAL-1 21 Jan 2020

Done

UI-DEN-2087-1 16 Apr 2020

Remove extra line

UI-DEN-2086-1 02 Mar 2020

For the first one, sure
For the second, We are not going to support extended CAN. At least we don't have any plan and if we want to do it, it needs the architecture (SWA,SDD,...) to be modified.

HD-DEN-431-BUG-FIXES-1 10 Feb 2020

Deleted the variable

UI-DEN-1396-1 15 Jan 2020

RESOLVED.

UI-DEN-1396-1 15 Jan 2020

RESOLVED.

UI-DEN-2086-1 02 Mar 2020

Okay, makes sense, RESOLVED

UI-DEN-1434-1 10 Mar 2020

Add space.

DG-RESTART-1 25 Feb 2020

Implemented suggestions. Please review again.

DG-RESTART-1 26 Feb 2020

Because code got moved to common.

DG-RESTART-1 26 Feb 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-1434-1 10 Mar 2020

I don't see where needs space.

DG-RESTART-1 25 Feb 2020

It should be removed. Kept it only for the moment as reference to help with DG FPGA register assignment.

UI-DEN-1434-1 10 Mar 2020

Peman,
Some of the comments about the spacing are in our c coding standards and not in our C++ coding standard.
From the beginning we discussed that these may/should be different.

DG-RESTART-1 26 Feb 2020

RESOLVED in CODE WALKTHROUGH.

DG-RESTART-1 24 Feb 2020

What are we doing in transitionToPostTreatmentMode?

DG-RESTART-1 26 Feb 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-1434-1 10 Mar 2020

applied.

DG-RESTART-1 26 Feb 2020

RESOLVED in CODE WALKTHROUGH.

DG-RESTART-1 27 Feb 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-1434-1 10 Mar 2020

applied .

DG-RESTART-1 28 Feb 2020

Placeholder for future unit test accomodations.

UI-DEN-1434-1 10 Mar 2020

Extra line needed at EOF.

DG-RESTART-1 28 Feb 2020

Done.

UI-DEN-1434-1 10 Mar 2020

RESOLVED.

HD-DEN-1906-1 02 Mar 2020

Done.