•  

Comment Results

Review Name Created Custom Fields Content
DG-RESTART-1 24 Feb 2020

Consolidate all includes.

DG-RESTART-1 24 Feb 2020

Why 2 structures that appear to hold the same 4 load cell values?

DG-RESTART-1 26 Feb 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-2086-1 02 Mar 2020

Should these be equal?

HD-DEN-1906-1 02 Mar 2020

RESOLVED in CODE WALKTHROUGH.

DG-RESTART-1 26 Feb 2020

RESOLVED in CODE WALKTHROUGH.

DG-RESTART-1 24 Feb 2020

Why removed?

UI-DEN-1434-1 11 Mar 2020

it is in a loop with int i as loop variable.
inner loop should not use the same even if the outer loop variable in not use in inner.

UI-DEN-1434-1 11 Mar 2020

it is in a loop with int i as loop variable.
inner loop should not use the same even if the outer loop variable in not use in inner.

HD-DEN-1778-1 17 Mar 2020

Why is this a byte pointer instead of a CALIBRATION_DATA_T pointer?

HD-DEN-1778-1 19 Mar 2020

True. Changed it to MAX_NUM_OF_EVENTS_IN_SECTOR3 and changed it to all of them

HD-DEN-1778-1 19 Mar 2020

Done. It goes back to Idle

HD-DEN-1778-1 17 Mar 2020

Why subtract one more?

HD-DEN-1778-1 19 Mar 2020

The FlashDriver folder contains all the files and the library for F021 related work which they are not shown here. They are all needed to be able to EEPROM work. I added CGT.gcc.h last night so I can compile in VectoCAST as well since we use MinGW in there.

HD-DEN-1778-1 19 Mar 2020

Done

HD-DEN-1778-1 19 Mar 2020

Yes we only return a bool to the caller. If they request a write and get a FALSE, it means their request has failed and they have to try again. It is mentioned in the Interface section in AE. Otherwise, we have to return enums instead of Boolean.

HD-DEN-1778-1 19 Mar 2020

The bootloader flag is a static variable in the scope of this file. It is returned using the getBootloaderFlag function.

HD-DEN-1778-1 19 Mar 2020

So the struct that has the details (see above please) has is called memory operations. The array of type this struct is called jobs and from then jobs is used. Only this struct has memory named.

HD-DEN-1778-1 20 Mar 2020

I added a check to all the get functions to check for NULL pointer.

HD-DEN-1778-1 17 Mar 2020

Remove fault state? On default, s/w fault and set state back to Idle.

HD-DEN-1778-1 23 Mar 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-1778-1 17 Mar 2020

Is minutes right? Or was it supposed to be hours?

HD-DEN-1778-1 17 Mar 2020

Sometime we call it a job and sometimes a memory operation. We should probably pick one and be consistent. I think non-volatile memory operation is best.

HD-DEN-1778-1 23 Mar 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-1778-1 23 Mar 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-1906-1 02 Mar 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-1710-1 22 Jan 2020

RESOLVED.

HD-DEN-1312-1 10 Jan 2020

Add blank line at eof.

HD-DEN-1312-1 10 Jan 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-1312-1 10 Jan 2020

RESOLVED in CODE WALKTHROUGH.

DIALIN-ACK-1 01 Apr 2020

I would keep bytearray as one word since it's a python type .

UI-DEN-1396-1 13 Jan 2020

Files has been modified many times manuallu on my branch as you asked a week or toow before 2020 and by Dara's script on master on 2019 and 2020.
It might be me merging files from my branch to master with 2019, since I think his script is running only on master branches.

HD-DEN-1906-1 02 Mar 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-1396-1 13 Jan 2020

Files has been modified many times manuallu on my branch as you asked a week or toow before 2020 and by Dara's script on master on 2019 and 2020.
It might be me merging files from my branch to master with 2019, since I think his script is running only on master branches.

UI-DEN-1396-1 13 Jan 2020

Files has been modified many times manuallu on my branch as you asked a week or toow before 2020 and by Dara's script on master on 2019 and 2020.
It might be me merging files from my branch to master with 2019, since I think his script is running only on master branches.

UI-DEN-1396-1 13 Jan 2020

Files has been modified many times manuallu on my branch as you asked a week or toow before 2020 and by Dara's script on master on 2019 and 2020.
It might be me merging files from my branch to master with 2019, since I think his script is running only on master branches.

UI-DEN-1396-1 13 Jan 2020

When the common repo is ready the hash table will be moved there but the function itself remains here since the data types UI and HD are using are different and can't be mixed.

HD-DEN-1404-1 16 Jan 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-1396-1 14 Jan 2020

RESOLVED.

UI-DEN-1396-1 09 Jan 2020

Date change?

HD-DEN-1404-1 16 Jan 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-1396-1 14 Jan 2020

It's a test code as has been stated on line 66 and will be removed or handled in correct way latter.

UI-DEN-2086-1 02 Mar 2020

Just as a suggestion, for future it would be helpful to replace the magic numbers with descriptive variables to improve readability here. Will it need to change to support both Standard and Extended CAN?

UI-DEN-1396-1 15 Jan 2020

RESOLVED.

UI-DEN-1396-1 10 Jan 2020

Can you explain why are you using two threads? One in frame interface and another one in can interface? I would think of a communication system as two threads, one sending information and another waiting to receive a response.

HD-DEN-1404-1 16 Jan 2020

With understanding that these are from prescription settings. RESOLVED in CODE WALKTHROUGH.

HD-DEN-1404-1 15 Jan 2020

Why are these variables volatile?

HD-DEN-1404-1 16 Jan 2020

These should be sensors values we can override with dialin. Use the test macros for these to facilitate that.

HD-DEN-1404-1 16 Jan 2020

Why U16? Seems like float would be the most versatile type.

DG-RESTART-1 24 Feb 2020

Remove 20+ extra lines.