•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-1404-1 16 Jan 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-1404-1 16 Jan 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-1404-1 16 Jan 2020

Put simulator code in #define.

HD-DEN-431-DIA-1 21 Jan 2020

RESOLVED in CODE WALKTHROUGH.

DG-RESTART-1 24 Feb 2020

Why removed?

UI-DEN-1710-1 22 Jan 2020

modified.

UI-DEN-1710-1 22 Jan 2020

Misspelling in word "application", also what is voved?

DG-RESTART-1 24 Feb 2020

Why removed?

UI-DEN-1971-1 26 Feb 2020

Remove extra line.

DG-RESTART-1 25 Feb 2020

Added prototype.

DG-RESTART-1 25 Feb 2020

I had not noticed existing one and made a new one. Removed one of them accordingly.

DG-RESTART-1 25 Feb 2020

I was checking to see if interrupt protection helped with any of the CAN issues. They are not needed. I'll remove.

DG-RESTART-1 24 Feb 2020

Why removed?

DG-RESTART-1 26 Feb 2020

Because code got moved to common.

UI-DEN-1971-1 26 Feb 2020

Spaces between arguments?

DG-RESTART-1 24 Feb 2020

Why removed?

UI-DEN-3149-1 11 Jun 2020

it's my general personal comments and todos like what we have as general comments in crucible.
just as a reminder for me.

UI-DEN-1396-1 13 Jan 2020

Could you please explain a little more which timeout and messages we are talking about since it's in a general area I don't know which part you mean.

DG-RESTART-1 26 Feb 2020

Will do so in DEN S15.

UI-DEN-1396-1 13 Jan 2020

Files has been modified many times manuallu on my branch as you asked a week or toow before 2020 and by Dara's script on master on 2019 and 2020.
It might be me merging files from my branch to master with 2019, since I think his script is running only on master branches.

HD-DEN-1404-1 16 Jan 2020

State change is relatively simple. Handles are created in the state machine.

UI-DEN-1396-1 13 Jan 2020

Files has been modified many times manuallu on my branch as you asked a week or toow before 2020 and by Dara's script on master on 2019 and 2020.
It might be me merging files from my branch to master with 2019, since I think his script is running only on master branches.

UI-DEN-1396-1 13 Jan 2020

Files has been modified many times manuallu on my branch as you asked a week or toow before 2020 and by Dara's script on master on 2019 and 2020.
It might be me merging files from my branch to master with 2019, since I think his script is running only on master branches.

UI-DEN-1396-1 09 Jan 2020

Date change?

UI-DEN-1396-1 09 Jan 2020

Date change?

HD-DEN-1404-1 16 Jan 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-1404-1 16 Jan 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-1404-1 15 Jan 2020

I don't see this param in function - cut & paste error?

UI-DEN-2086-1 10 Mar 2020

RESOLVED.

UI-DEN-1396-1 14 Jan 2020

This is the Qt [built-in] style.
I didn't change it since it is also used for QML.
And it made both code look alike.

HD-DEN-1404-1 17 Jan 2020

Done

UI-DEN-1396-1 15 Jan 2020

RESOLVED.

UI-DEN-2086-1 02 Mar 2020

Yes,
I used channel Id 0 as none, but since it has a highest priority it's not good to have the highest priority channel id for something kind of unknown, so I changed it to the lowest.
Also the Lowest is used for keepAwake message.
And both have the same value.

UI-DEN-1396-1 15 Jan 2020

RESOLVED.

HD-DEN-431-DIA-1 20 Jan 2020

I thought about that before putting the function here. Sure we can add more logic but I would like to make sure we definitely want to broadcast time less often.

HD-DEN-431-DIA-1 21 Jan 2020

Change deferred. RESOLVED in CODE WALKTHROUGH.

DG-RESTART-1 28 Feb 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-2086-1 02 Mar 2020

Maybe need a check if (vData.type() == QVariant::Int) here before incrementing mData?

DIALIN-PENDING-APPROAVAL-1 21 Jan 2020

change to \param and \return

UI-DEN-1434-1 10 Mar 2020

It has EEL, Extra Empty Lines are not necessary shown up in crucible.

UI-DEN-1710-1 22 Jan 2020

Updated.

HD-DEN-431-BUG-FIXES-1 10 Feb 2020

I didn't see where this was used. What is its purpose?

UI-DEN-1434-1 10 Mar 2020

Could it be the same as txqueuelen? That's how I interpreted it

DG-RESTART-1 24 Feb 2020

All of these modes act as a state machine. They each have a transition function where you can take any actions that you want to happen when transitioning into the mode from some other mode.

UI-DEN-1434-1 10 Mar 2020

applied .

DG-RESTART-1 25 Feb 2020

Now I am calling execLoadCell from within execSensorData. New functions can be later added to execSensorData().

UI-DEN-2087-1 22 Apr 2020

Done

DG-RESTART-1 26 Feb 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-1434-1 10 Mar 2020

RESOLVED.

UI-DEN-1434-1 11 Mar 2020

RESOLVED