•  

Comment Results

Review Name Created Custom Fields Content
UI-DEN-1396-1 13 Jan 2020

Files has been modified many times manuallu on my branch as you asked a week or toow before 2020 and by Dara's script on master on 2019 and 2020.
It might be me merging files from my branch to master with 2019, since I think his script is running only on master branches.

HD-DEN-1404-1 16 Jan 2020

I believe INC_WRAP is more flexible. It mostly used in digital filter implementation. This should be gone once the digital filter are moved to the once in the module.

UI-DEN-1396-1 13 Jan 2020

Files has been modified many times manuallu on my branch as you asked a week or toow before 2020 and by Dara's script on master on 2019 and 2020.
It might be me merging files from my branch to master with 2019, since I think his script is running only on master branches.

UI-DEN-1396-1 13 Jan 2020

namespaces don't have indentation because it would be redundant and almost all the files have namespaces.

UI-DEN-1396-1 14 Jan 2020

RESOLVED.

UI-DEN-1396-1 09 Jan 2020

Changed date?

UI-DEN-1396-1 14 Jan 2020

RESOLVED.

UI-DEN-1396-1 09 Jan 2020

Changed date?

HD-DEN-1404-1 16 Jan 2020

Sapna will need them as soon as you close out the SDLC sub-tasks and the story goes to her.

UI-DEN-1396-1 14 Jan 2020

RESOLVED.

UI-DEN-1396-1 09 Jan 2020

Changed date?

UI-DEN-1396-1 09 Jan 2020

Changed date?

UI-DEN-1396-1 09 Jan 2020

Changed date?

UI-DEN-1396-1 09 Jan 2020

Changed date?

UI-DEN-1396-1 09 Jan 2020

Changed date?

UI-DEN-1396-1 09 Jan 2020

Changed date?

UI-DEN-1396-1 09 Jan 2020

Changed date?

UI-DEN-1396-1 14 Jan 2020

RESOLVED.

UI-DEN-1396-1 09 Jan 2020

Date change?

UI-DEN-1396-1 09 Jan 2020

Date change?

UI-DEN-1396-1 14 Jan 2020

RESOLVED.

UI-DEN-1396-1 14 Jan 2020

RESOLVED.

HD-DEN-431-DIA-1 20 Jan 2020

May not want to broadcast at same interval as RTC read. Recommend separating broadcast to its own schedule in case we want to broadcast epoch less often.

UI-DEN-1396-1 14 Jan 2020

RESOLVED.

UI-DEN-1396-1 14 Jan 2020

RESOLVED.

UI-DEN-1396-1 15 Jan 2020

RESOLVED.

UI-DEN-1396-1 09 Jan 2020

Remove commented section.

UI-DEN-1710-1 22 Jan 2020

They didn't intended to be removed.
Commented for a while and forget to revert back.
Updated.

UI-DEN-1396-1 15 Jan 2020

RESOLVED.

DIALIN-PENDING-APPROAVAL-1 21 Jan 2020

We need HD_TestScript.py to be move to a pytest type of function on the next revision of this software.

HD-DEN-431-BUG-FIXES-1 10 Feb 2020

Why the extra parenthesis?

DG-RESTART-1 26 Feb 2020

RESOLVED in CODE WALKTHROUGH.

DG-RESTART-1 26 Feb 2020

RESOLVED in CODE WALKTHROUGH.

DG-RESTART-1 26 Feb 2020

Because code got moved to common.

DG-RESTART-1 26 Feb 2020

Because code got moved to common.

DG-RESTART-1 26 Feb 2020

RESOLVED in CODE WALKTHROUGH.

DG-RESTART-1 26 Feb 2020

RESOLVED in CODE WALKTHROUGH.

DG-RESTART-1 27 Feb 2020

RESOLVED in CODE WALKTHROUGH.

DG-RESTART-1 28 Feb 2020

Done.

DG-RESTART-1 28 Feb 2020

Comments should go.

HD-DEN-1906-1 02 Mar 2020

CAN_TEST build switch and related code is removed.

HD-DEN-1906-1 02 Mar 2020

Done.

DIALIN-ACK-1 27 Mar 2020

Isn't the 1 second sleep going to interfere with the faster messages transmitted and received by the laptop+CAN Analyzer node?

DIALIN-ACK-1 27 Mar 2020

Provide """ """ section in class header, also provide the process by which these channel IDs get updated, using which files, located where.

DG-DEN-2650-1 11 May 2020

???

DIALIN-DEN-2652-1 20 May 2020

Fixed.

DG-DEN-2650-1 18 May 2020

Replace with RO_FLOW_ADC_TO_LPM_FACTOR / (F32)(roFlow)

UI-DEN-2087-1 16 Apr 2020

both cpp and header are next to each other.
FishEye is adding what ever file that has been changed.

UI-DEN-2087-1 16 Apr 2020

I understand return is the output; however, what I more used to see is: input(s), output(s), and params for every function header.

UI-DEN-2087-1 16 Apr 2020

Where is format.h?