•  

Comment Results

Review Name Created Custom Fields Content
UI-DEN-2087-1 22 Apr 2020

Done

HD-DEN-3115-1 19 May 2020

Comment?

UI-DEN-2087-1 22 Apr 2020

RESOLVED.

HD-DEN-3115-1 19 May 2020

Align comments

DG-DEN-2379-1 19 May 2020

Where is ModeInitPOST.h?

HD-SPRINT16-1 23 Apr 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-13460-2 21 Sep 2022

Done.

DIALIN-DEN-2652-1 20 May 2020

RESOLVED.

DG-DEN-4217-1 17 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-2652-1 05 May 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-2087-1 24 Apr 2020

Resolving as per our conv. today regarding placeholders

DIALIN-REFACTORING-3-1 29 Apr 2020

The purpose of programming language specification here is description only and there are no pypi classifiers that specify the python version beyond MAJOR.MINOR.

Since python-can has an issue working on windows, I haven't specified windows as a supported version.

I checked, and there is no pypi classifier for Virtualbox, or any other type of virtualization platform. This makes sense because specifying a python package as being compatible with a virtualization environment is out of the scope of the setuptools configuration.

There are also no pypi specifiers for Ubuntu specifically. So, the classifier I could find that best matches the OS we're running is Linux.

UI-DEN-2793-1 26 Apr 2020

RESOLVED.

UI-DEN-2793-1 26 Apr 2020

RESOLVED

UI-DEN-2793-1 26 Apr 2020

Here is ALL CAPS with "_" inbetween. What part of the C++ coding standard states this?

DG-DEN-2650-1 27 Apr 2020

Where does 0.1L come from? From SA? From HRS? From HDD?

DG-DEN-2650-1 28 Apr 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-2652-1 05 May 2020

Added.

DG-DEN-2652-1 05 May 2020

Agreed, but if condition check needs to become < 2 instead of <= 2, also modified that.

DG-DEN-2650-1 30 Apr 2020

Insert line.

DG-DEN-2652-1 05 May 2020

For consistency, I would use U08 instead of int

DG-DEN-2652-1 05 May 2020

I would use DEENERGIZED instead of zero to clarify intent for these inits.

DG-DEN-2652-1 05 May 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-2652-1 04 May 2020

I would rename function to convertValveStateNameToValveState and rename the param to valveStateName.

DG-DEN-2652-1 05 May 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-2652-1 04 May 2020

I would consider always giving FPGA the current valve states at the end of this function instead of only when valve states change. And I would also set currentValvesStates just prior to sending to FPGA instead of above on line 89 - that way the monitor portion here will be checking read FPGA states against the current states from last exec (more likely to match).

DG-DEN-2652-1 05 May 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-3024-1 06 May 2020

RESOLVED

UI-DEN-3024-1 07 May 2020

I don't know what is the standard format.
The wording should be exactly the same it's just spacing in the code.

UI-DEN-3024-1 07 May 2020

All methods comments added.

UI-DEN-3024-1 07 May 2020

Done

UI-DEN-3024-1 07 May 2020

done.

UI-DEN-3024-1 07 May 2020

done

UI-DEN-3024-1 07 May 2020

done

UI-DEN-3024-1 06 May 2020

It is preferred to keep them as constant values

UI-DEN-3024-1 07 May 2020

RESOLVED.

HD-DEN-3115-1 14 May 2020

I've considered this and generally agree. I've been waiting for dust to settle a bit on design - if the design for the 2 pumps diverges a lot, I'd want to keep them separate. If they stay this aligned, I'll want to move a lot of the common code to a common module.

HD-DEN-3115-1 11 May 2020

I noticed that a long time ago - but it's everywhere. Would be very painful to change now.

HD-DEN-3115-1 12 May 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-3115-1 11 May 2020

0x10000 #define as constant

HD-DEN-3115-1 11 May 2020

Again, should it be ///< or ///>?

HD-DEN-3115-1 13 May 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-2650-1 18 May 2020

Agreed. Done.

HD-DEN-3115-1 19 May 2020

Added comments.

HD-DEN-4211-1 28 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-4217-1 17 Aug 2020

Planned to be taken care of in DEN S26.

DG-COMMON-FIX-1 27 Mar 2020

Yes.

DG-COMMON-FIX-1 27 Mar 2020

Do we have sensors supplied with +6 Vdc?

DG-COMMON-FIX-1 27 Mar 2020

Does HD have a Standby mode, as well?

DG-COMMON-FIX-1 27 Mar 2020

What is this alarm for?