•  

Comment Results

Review Name Created Custom Fields Content
DIALIN-PENDING-APPROAVAL-1 22 Jan 2020

Done

UI-DEN-1710-1 22 Jan 2020

What was wrong with the ; at the end of each line?

UI-DEN-1710-1 22 Jan 2020

What is this comment line for?

HD-DEN-1778-1 23 Mar 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-431-BUG-FIXES-1 10 Feb 2020

Deleted the parenthesis

DG-RESTART-1 26 Feb 2020

Done.

DG-RESTART-1 24 Feb 2020

Any reason why you're keeping the HD structure?

HD-DEN-1778-1 23 Mar 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-1778-1 19 Mar 2020

This #define was never used and I will remove it. If you look at the POST functions, Mfg log is read from EEPROM at the beginning of Sector0.

HD-DEN-1778-1 19 Mar 2020

Done

HD-DEN-1778-1 20 Mar 2020

Done

HD-DEN-1778-1 23 Mar 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-1778-1 23 Mar 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-1778-1 23 Mar 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-1778-1 17 Mar 2020

Why is this a byte pointer instead of a LOG_DATA_T pointer? And if it was a LOG_DATA_T pointer, would we need a length since length is fixed at 32 bytes?

HD-DEN-1778-1 23 Mar 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-1778-1 23 Mar 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-1778-1 17 Mar 2020

Were you going to add a flag field for when this record is found corrupted (and set to full until uploaded to HD)?

HD-DEN-1778-1 23 Mar 2020

Keeping as is. RESOLVED in CODE WALKTHROUGH.

HD-DEN-1778-1 17 Mar 2020

Were you going to remove this state?

HD-DEN-1778-1 23 Mar 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-1778-1 23 Mar 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-1778-1 19 Mar 2020

Is this always guaranteed? i.e. is there a check on buffer's data needed before doing a memcpy to avoid failure of this action?

HD-DEN-1778-1 24 Mar 2020

Done

HD-DEN-1778-1 24 Mar 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-1778-1 24 Mar 2020

RESOLVED in CODE WALKTHROUGH.

DIALIN-ACK-1 27 Mar 2020

Remove extra line

DG-COMMON-FIX-1 27 Mar 2020

Remove extra line.

DIALIN-ACK-1 01 Apr 2020

RESOLVED.

HD-DEN-1906-1 02 Mar 2020

Remove extra lines at EOF.

HD-DEN-1906-1 02 Mar 2020

Why /// instead of //? I see this in many places.

UI-DEN-1396-1 09 Jan 2020

Indentation of }?

UI-DEN-1396-1 09 Jan 2020

Indentation of }?

UI-DEN-1396-1 09 Jan 2020

Remove all commented sections.

UI-DEN-1396-1 09 Jan 2020

Remove all commented sections.

UI-DEN-3149-1 11 Jun 2020

I would keep them outside the code base.

UI-DEN-1396-1 09 Jan 2020

Remove commented line.

UI-DEN-1396-1 09 Jan 2020

Remove commented line.

UI-DEN-2086-1 10 Mar 2020

Has been removed in the current working branch fro the Treatment last implementation.

UI-DEN-1396-1 09 Jan 2020

Add blank line at eof.

UI-DEN-1396-1 09 Jan 2020

Move to common, this is too much maintenance.

UI-DEN-1396-1 09 Jan 2020

Remove commented line.

HD-DEN-1404-1 15 Jan 2020

Are these variables part of the module or temporary engineering code?

HD-DEN-1404-1 16 Jan 2020

I believe most if not all of these will be floats for the caller of this function. You're forcing caller to cast to U16 and then you're casting them back.

UI-DEN-1434-1 10 Mar 2020

applied .

HD-DEN-1404-1 17 Jan 2020

As discussed, this activity can be post-pone.

UI-DEN-1396-1 13 Jan 2020

Files has been modified many times manuallu on my branch as you asked a week or toow before 2020 and by Dara's script on master on 2019 and 2020.
It might be me merging files from my branch to master with 2019, since I think his script is running only on master branches.

HD-DEN-1404-1 16 Jan 2020

I believe INC_WRAP is more flexible. It mostly used in digital filter implementation. This should be gone once the digital filter are moved to the once in the module.

UI-DEN-1396-1 13 Jan 2020

Files has been modified many times manuallu on my branch as you asked a week or toow before 2020 and by Dara's script on master on 2019 and 2020.
It might be me merging files from my branch to master with 2019, since I think his script is running only on master branches.

UI-DEN-1396-1 13 Jan 2020

namespaces don't have indentation because it would be redundant and almost all the files have namespaces.