•  

Comment Results

Review Name Created Custom Fields Content
UI-DEN-2087-1 22 Apr 2020

Done

DG-RESTART-1 26 Feb 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-1434-1 10 Mar 2020

RESOLVED.

UI-DEN-1434-1 11 Mar 2020

RESOLVED

UI-DEN-1434-1 11 Mar 2020

it is in a loop with int i as loop variable.
inner loop should not use the same even if the outer loop variable in not use in inner.

UI-DEN-2087-1 22 Apr 2020

Done

UI-DEN-2087-1 22 Apr 2020

Done

HD-SPRINT16-1 22 Apr 2020

Add space.

HD-DEN-1778-1 19 Mar 2020

Understood. I changed it to MIN_JOBS_NEEDED_FOR_DATA_LOG

HD-DEN-1778-1 19 Mar 2020

I wanted the default operation be write to it does not accidentally write or read something.

HD-DEN-1778-1 19 Mar 2020

Yes, the Bool flag isHdrCorrupted in the LOG_HEADER_T is that flag. It is false unless the CRC fails in POST.

HD-DEN-1778-1 19 Mar 2020

Done

HD-DEN-1778-1 19 Mar 2020

Is bootloaderFlag a global variable or static variable in the scope of this file?

HD-DEN-1778-1 20 Mar 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-1778-1 20 Mar 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-1778-1 20 Mar 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-1778-1 20 Mar 2020

Done

HD-DEN-1778-1 23 Mar 2020

Done. I don't check for any of the counts in enqueue function.

HD-DEN-1778-1 23 Mar 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-1778-1 19 Mar 2020

If you only have one data, use the 1 data macro.

HD-DEN-1778-1 17 Mar 2020

Should this be "JOB" count instead of "QUEUE" count?

HD-DEN-1778-1 17 Mar 2020

What is the purpose of this "none" operation?

DG-DEN-4217-1 17 Aug 2020

Planned to be taken care of in DEN S26.

HD-DEN-1404-1 16 Jan 2020

Because, when you switch, they might be initialization code. If you are in pause and mistakenly you switch to pause, you don't want to run initialization routines.

UI-DEN-1396-1 13 Jan 2020

I'll take an overall look.
Could you please help me with a specific example?

HD-DEN-1404-1 16 Jan 2020

Done, part of simulator, #define was used

UI-DEN-1396-1 13 Jan 2020

Files has been modified many times manuallu on my branch as you asked a week or toow before 2020 and by Dara's script on master on 2019 and 2020.
It might be me merging files from my branch to master with 2019, since I think his script is running only on master branches.

UI-DEN-1396-1 09 Jan 2020

Changed date?

HD-DEN-1778-1 19 Mar 2020

My point was that there is only one queue and the queue holds some number of jobs or memory operations. So the count is not a queue count (because there's only one).

UI-DEN-1396-1 14 Jan 2020

RESOLVED.

HD-DEN-1404-1 16 Jan 2020

Done

UI-DEN-1396-1 14 Jan 2020

RESOLVED.

HD-DEN-1404-1 15 Jan 2020

I would prefer to see all of these definitions moved to the top of the module.

UI-DEN-1396-1 14 Jan 2020

RESOLVED.

UI-DEN-1396-1 09 Jan 2020

Date change?

HD-DEN-1404-1 15 Jan 2020

This function returns a boolean.

HD-DEN-1404-1 15 Jan 2020

This macro appears to be duplicate of INC_WRAP above.

UI-DEN-2087-1 16 Apr 2020

Remove extra line

HD-DEN-1404-1 16 Jan 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-1396-1 15 Jan 2020

RESOLVED.

UI-DEN-1434-1 10 Mar 2020

applied.

DG-RESTART-1 27 Feb 2020

What is this blank section for?

HD-DEN-1404-1 16 Jan 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-1404-1 15 Jan 2020

Please leave space in paranthesis

HD-DEN-1404-1 15 Jan 2020

Please leave space in paranthesis

HD-DEN-1404-1 15 Jan 2020

I think you should move the #defines to the top

HD-DEN-1404-1 17 Jan 2020

Done. See DialoutFlow.h

UI-DEN-1434-1 10 Mar 2020

RESOLVED.

HD-DEN-1404-1 17 Jan 2020

As discussed, this activity can be post-pone

UI-DEN-1434-1 10 Mar 2020

RESOLVED.