•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-1404-1 16 Jan 2020

Done

UI-DEN-1396-1 13 Jan 2020

Files has been modified many times manuallu on my branch as you asked a week or toow before 2020 and by Dara's script on master on 2019 and 2020.
It might be me merging files from my branch to master with 2019, since I think his script is running only on master branches.

UI-DEN-1396-1 14 Jan 2020

RESOLVED.

HD-DEN-1312-1 09 Jan 2020

I only made these volatile to see if it helped with CAN issue (it did not). I'll likely change them back to remove the volatile property. We only need volatile if we access a variable multiple times within a function and expect other threads may have changed the variable's value between accesses (as compiler may optimize the function to only access it once if not volatile). Other means of thread protection should prevent other threads from accessing a given side of a buffer at the same time.

UI-DEN-1396-1 09 Jan 2020

Date change?

HD-DEN-1906-1 02 Mar 2020

Remove.

UI-DEN-1396-1 14 Jan 2020

RESOLVED.

HD-DEN-1404-1 16 Jan 2020

Where's newState @param?

UI-DEN-1396-1 14 Jan 2020

RESOLVED.

HD-DEN-1404-1 15 Jan 2020

If you're casting these to floats, why not just type your parameters to float so you get what you want?

HD-DEN-1404-1 16 Jan 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-1906-1 02 Mar 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-1404-1 16 Jan 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-1906-1 02 Mar 2020

Remove.

UI-DEN-1396-1 14 Jan 2020

These are necessary QTest methods that I don't have any implementation for them yet.
I didn't like the fact that although I don't have anything implemented, it's still counts as a successful test, so I comment them out for now until I have an implementation for them.
In general I prefer not to remove thme to keep them as part of the standard QtTest class.

HD-DEN-1404-1 16 Jan 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-1396-1 14 Jan 2020

This is the Qt [built-in] style.
I didn't change it since it is also used for QML.
And it made both code look alike.

HD-DEN-1906-1 02 Mar 2020

Remove.

HD-DEN-1404-1 17 Jan 2020

Done. More to come.

UI-DEN-1396-1 15 Jan 2020

RESOLVED.

DIALIN-PENDING-APPROAVAL-1 21 Jan 2020

We will do it on the next revision

HD-DEN-1906-1 02 Mar 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-1906-1 02 Mar 2020

Remove.

HD-DEN-431-BUG-FIXES-1 12 Feb 2020

The values are actually used to define the status of the state machine when next time the function is called.

LEAHI-DD-FIRMWARE-LDT-2030-2 11 Feb 2026

Minor: There is a typo with Inputs

DG-RESTART-1 26 Feb 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-2086-1 02 Mar 2020

RESOLVED

HD-DEN-431-BUG-FIXES-1 12 Feb 2020

I know this is not new code but, why these functions (e.g. handleSelfTestStart()) return a value that is not used?

HD-DEN-431-BUG-FIXES-1 14 Feb 2020

RESOLVED in CODE WALKTHROUGH.

DG-RESTART-1 26 Feb 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-2086-1 10 Mar 2020

Has been removed in the current working branch fro the Treatment last implementation.

DG-RESTART-1 26 Feb 2020

RESOLVED in CODE WALKTHROUGH.

DG-RESTART-1 26 Feb 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-1434-1 10 Mar 2020

Should this be hardcoded to 4000? Would it ever need to change to 10,000?

DG-RESTART-1 26 Feb 2020

RESOLVED in CODE WALKTHROUGH.

DG-RESTART-1 26 Feb 2020

RESOLVED in CODE WALKTHROUGH.

DG-RESTART-1 26 Feb 2020

Because code got moved to common.

UI-DEN-1971-1 27 Feb 2020

RESOLVED.

UI-DEN-1434-1 10 Mar 2020

Remove extra line.

UI-DEN-2086-1 06 Mar 2020

Remove extra line.

UI-DEN-1434-1 11 Mar 2020

Please put range check.

DG-RESTART-1 28 Feb 2020

Remove extra lines.

DG-RESTART-1 28 Feb 2020

RESOLVED IN CODE WALKTHROUGH.

HD-DEN-1906-1 02 Mar 2020

Done.

HD-DEN-1906-1 02 Mar 2020

Done.

HD-DEN-1404-1 16 Jan 2020

Done

DG-DEN-4217-1 17 Aug 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-1404-1 16 Jan 2020

I'm reducing unnecessary bytes in communication.

HD-DEN-1312-1 10 Jan 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-1312-1 10 Jan 2020

Add space.