•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-1312-1 06 Jan 2020

Why are we using both mibSPI and SPI?

UI-DEN-1090-1 19 Dec 2019

RESOLVED.

DG-DEN-1125-1 16 Dec 2019

.gitignore is due to a /document file that I have in local folder. We need flexibility for developers.

HD-DEN-1404-1 16 Jan 2020

Done

DG-DEN-1125-1 16 Dec 2019

Done

HD-DEN-431-1 06 Jan 2020

In the datasheet, it is mentioned that bits labeled as T must always be written with logic 0. The unused bit is labeled as T so I am checking it all the time.

UI-DEN-1090-1 19 Dec 2019

Replace 10, 4, 100, etc. with LETTER_PARAMETERS centralized on top of code.

HD-DEN-431-1 06 Jan 2020

Done!

UI-DEN-1090-1 19 Dec 2019

RESOLVED.

HD-DEN-431-1 06 Jan 2020

Length is range checked in the above else if statement.

UI-DEN-704-1 20 Dec 2019

RESOLVED

DG-DEN-1125-1 20 Dec 2019

RESOLVED IN CODE WALKTHROUGH

DG-DEN-1125-1 10 Dec 2019

DG dialin message IDs should start at some other offset. HD is using 0x8000. DG should maybe use 0xA000.

HD-DEN-431-1 06 Jan 2020

Done!

DG-DEN-1125-1 20 Dec 2019

RESOLVED IN CODE WALKTHROUGH

DG-DEN-1125-1 20 Dec 2019

Done

DG-DEN-1125-1 07 Jan 2020

RESOLVED IN CODE WALKTHROUGH.

DG-DEN-1125-1 26 Dec 2019

RESOLVED in CODEWALKTHROUGH

DG-DEN-1125-1 30 Dec 2019

Remove extra line.

DG-DEN-1125-1 07 Jan 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-1125-1 07 Jan 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-431-1 07 Jan 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-431-1 07 Jan 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-431-1 07 Jan 2020

RESOLVED in CODE WALKTHROUGH.

DIALIN-1 05 Dec 2019

In general I'm not a fan of having parameter name when passing a value to it.
I know some languages like old lady VisualBasic had it, but it's confusing and also give the ability to reorder the functions parameters when passing values which I believe is not good and is making the code hard to understand and read.
As you used a very good naming for the values it shows which parameter is used.

UI-DEN-1434-1 10 Mar 2020

RESOLVED.

DIALIN-1 13 Dec 2019

RESOLVED.

DIALIN-1 26 Nov 2019

Not a big fan of sleeps in general.

DG-DEN-1125-1 11 Dec 2019

Done

DIALIN-1 26 Nov 2019

A lot of magic numbers throughout the python code. What is the python equivalent of a #define? Can we create named constants for these values?

HD-DEN-759-1 26 Nov 2019

RESOLVED in CODE WALKTHROUGH.

UI-DEN-626-1 04 Dec 2019

RESOLVED

DIALIN-1 27 Nov 2019

I would need to explain logic. let's meet

UI-DEN-704-1 05 Dec 2019

Recommend using a more descriptive naming. 0x020 is an input channel to UI, i.e., HD2UI. Similar is 0x100, it is an output channel.From UI to HD.

DIALIN-1 03 Dec 2019

Logic here is determining zero vs. non-zero only. Sign is not considered here one way or the other.

UI-DEN-626-1 01 Nov 2019

Leo,

Resolving the case in not enough, you also need to reply to Behrouz's last comment and mention the word "RESOLVED", otherwise, Dara's Crucible script won't pick this code review up. We will review this next week during the training.

DIALIN-1 30 Dec 2019

RESOLVED

DIALIN-1 03 Dec 2019

If we haven't received a reply (indicated by None) within 1 second of transmit of command, then we timed out.

HD-DEN-759-1 06 Dec 2019

RESOLVED in CODE WALKTHROUGH.

HD-DEN-759-1 04 Dec 2019

Then, please add a TODO comment (or similar).

DG-DEN-1125-1 10 Dec 2019

Leo should take ownership of DG modules that are not going to be common with HD. Change author and date.

DG-DEN-1125-1 16 Dec 2019

I need to do a major clean up, at this time, this change requires major clean up.

DIALIN-1 03 Dec 2019

This is just an example test script using the HD library. I imagined a tester wanting to set a specific interval and I don't imagine testers will be creating constants or enums for their code.

HD-DEN-759-1 04 Dec 2019

Done.

HD-DEN-759-1 06 Dec 2019

RESOLVED in CODE WALKTHROUGH.

UI-DEN-608-4 04 Dec 2019

Method should be verbs, e.g., setupConnections()

DG-DEN-1125-1 11 Dec 2019

RESOLVED IN CODE WALKTHROUGH

DG-DEN-1125-1 16 Dec 2019

Yes, at the moment, standby doesn't do anything.

HD-DEN-759-1 06 Dec 2019

RESOLVED in CODE WALKTHROUGH.

HD-DEN-759-1 04 Dec 2019

We should create a toggle macro for this. Also, do we have a min and max macro?