Activity dd-firmware/

4:17 pm

Vinayakam Mani

More
b342323
changed 1 file
LDT-2004-dialysate-composition-bicarb-mixing-closed-loop--dd, LDT-2004-dialysate-composition-dosing-control--dd and 13 more LEAHI-DD-FIRMWARE-LDT-3352-1

LDT-3352 resolving merge conflicts

- -4
- +1
/firmware/App/Modes/ModeGenDialysate.c
- History
- Source
- Diff
/firmware/App/Modes/ModeGenDialysate.c

3:47 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3352-1
commented on review

Looks like we are doing a lot of the dialysate temp control in Gen Dialysate mode. Do we not do any heating in PreGen mode? Even if all dialysate heating is done in this mode, should we consider cr...

Looks like we are doing a lot of the dialysate temp control in Gen Dialysate mode. Do we not do any heating in PreGen mode?
Even if all dialysate heating is done in this mode, should we consider creating a service controller (like BC controller) to manage this complex temperature control?

3:38 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3352-1
commented on review

Resolve merge conflicts.

1:54 pm

Michael Garthwaite

More
811395e
changed 3 files

LDT-3372: Reduced warnings in relation to teensy driver. Removed unused functions. Fixed overrides

- -131
- +28
/firmware/App/Drivers/ConductivityTeensy.c
- History
- Source
- Diff
/firmware/App/.../ConductivityTeensy.c
- -2
- +2
/firmware/App/Drivers/ConductivityTeensy.h
- History
- Source
- Diff
/firmware/App/.../ConductivityTeensy.h
- -8
- +8
/firmware/App/Monitors/Conductivity.c
- History
- Source
- Diff
/firmware/App/Monitors/Conductivity.c

1:33 pm

Vendor - TEL - Jashwant Gantyada

More
f66ffb2
changed 7 files
LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 44 more LEAHI-DD-FIRMWARE-LDT-3344-1

LDT-3344 addressed code review comments

- -8
- +119
/firmware/App/Controllers/RinsePump.c
- History
- Source
- Diff
/firmware/App/Controllers/RinsePump.c
- -2
- +6
/firmware/App/Controllers/RinsePump.h
- History
- Source
- Diff
/firmware/App/Controllers/RinsePump.h
- -1
- +37
/firmware/App/Drivers/GPIO.c
- History
- Source
- Diff
/firmware/App/Drivers/GPIO.c
- -0
- +12
/firmware/App/Drivers/GPIO.h
- History
- Source
- Diff
/firmware/App/Drivers/GPIO.h
- -13
- +11
/firmware/App/Monitors/Level.c
- History
- Source
- Diff
/firmware/App/Monitors/Level.c
- -39
- +30
/firmware/App/Services/FpgaDD.c
- History
- Source
- Diff
/firmware/App/Services/FpgaDD.c
- -0
- +4
/firmware/App/Tasks/TaskPriority.c
- History
- Source
- Diff
/firmware/App/Tasks/TaskPriority.c

12:00 pm

Michael Garthwaite

More
b91d956
changed 3 files
LDT-2004-dialysate-composition-bicarb-mixing-closed-loop--dd, LDT-2004-dialysate-composition-closed-loop--dd and 2 more

LDT-2004: updates to v2 driver. changed data types for cal coefficents to f32. Implemented calculated resistance, temp, and conductivity based on raw data from sensor.

- -21
- +129
/firmware/App/Drivers/ConductivitySensors.c
- History
- Source
- Diff
/firmware/App/.../ConductivitySensors.c
- -8
- +8
/firmware/App/Drivers/ConductivitySensors.h
- History
- Source
- Diff
/firmware/App/.../ConductivitySensors.h
- -17
- +8
/firmware/App/Monitors/Conductivity.c
- History
- Source
- Diff
/firmware/App/Monitors/Conductivity.c

9:40 am

Vinayakam Mani

9:25 am

Vinayakam Mani

10:32 pm

chaithra bs <ven.cburudugatta@diality.com>

More
a289610
changed 0 files
LDT-1195-dd-is-balancing-chamber-switching, LDT-2004-dialysate-composition-dosing-control--dd and 22 more

LDT-3223-dialysate-flow-rate---dd---mode-tel-dev-test : Added testcases for DialysatePump file

5:15 pm

Dara Navaei

More
6631fc6
changed 1 file
LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 46 more

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

- -1
- +1
/firmware/App/DDCommon.h
- History
- Source
- Diff
/firmware/App/DDCommon.h

5:14 pm

Dara Navaei

More
3a539af
changed 4 files
LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 46 more LEAHI-DD-FIRMWARE-LDT-2004-11 LEAHI-DD-FIRMWARE-LDT-2004-13

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -3
- +3
/firmware/App/Drivers/BloodLeakDriver.c
- History
- Source
- Diff
/firmware/App/Drivers/BloodLeakDriver.c
- -3
- +3
/firmware/App/Drivers/BloodLeakDriver.h
- History
- Source
- Diff
/firmware/App/Drivers/BloodLeakDriver.h
- -2
- +2
/firmware/App/Monitors/BloodLeak.c
- History
- Source
- Diff
/firmware/App/Monitors/BloodLeak.c
- -1
- +1
/firmware/App/Monitors/BloodLeak.h
- History
- Source
- Diff
/firmware/App/Monitors/BloodLeak.h

5:12 pm

Vendor - TEL - Jashwant Gantyada

More
18b2b56
changed 0 files
LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 46 more

Merged LDT-2030 blood leak refactor code

5:09 pm

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-3344-1
commented on review

For B1.0/B1.9 - Where Diener silencer 2000 pumps, this macro needs to be enabled.

5:07 pm

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-3344-1
commented on review

There are recent changes done on FPGA register in staging for B1.0/B1.9. please merge the latest changes here.

5:01 pm

Vendor - TEL - Jashwant Gantyada

More
d874c0b
changed 0 files
LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 47 more

Merge branch 'staging' into LDT-2030-blood-leak-refactor---dd

5:00 pm

Dara Navaei

More
bac3018
changed 1 file
LDT-2004-dialysate-composition-bicarb-mixing-closed-loop--dd, LDT-2004-dialysate-composition-closed-loop--dd, develop

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

- -1
- +1
/firmware/App/DDCommon.h
- History
- Source
- Diff
/firmware/App/DDCommon.h

4:59 pm

Vendor - TEL - Jashwant Gantyada

More
e8464c8
changed 0 files
LDT-2004-dialysate-composition-bicarb-mixing-closed-loop--dd, LDT-2004-dialysate-composition-closed-loop--dd, develop

Merge branch 'LDT-2030-blood-leak-refactor---dd' into develop

4:56 pm

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-3344-1
commented on review

Add valve details per HDD (may be 2.0 valves. as we remove beta 1/1.9 in sometime)

4:56 pm

Vendor - TEL - Jashwant Gantyada

4:55 pm

Sean Nash and Vendor - TEL - Sameer Poyil

More
LEAHI-DD-FIRMWARE-LDT-2030-2
finished reviewing

4:55 pm

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-3344-1
commented on review

add new valves.

4:53 pm

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-3344-1
commented on review

Can we follow the same terminology as DD, starting a variable with 'fpga...'. for all IOFP variables?

4:50 pm

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-3344-1
commented on review

typo - used.

4:46 pm

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-3344-1
commented on review

Add as HDF hallsensor. start the comment with capital letter R.

4:30 pm

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-3344-1
commented on review

#define 0U across the file.

4:18 pm

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-3344-1
commented on review

Instead of generic function, recommend adding a specific function something similar to "getACSwitchStatus' or 'getLeaskSensorStatus' and return the values ( ex: leak sensor Enum states?). Do we nee...

Instead of generic function, recommend adding a specific function something similar to "getACSwitchStatus' or 'getLeaskSensorStatus' and return the values ( ex: leak sensor Enum states?). Do we need to add the application code as well now, say if leak is found, trigger an alarm?

3:56 pm