dd-firmware

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Merge branch 'staging' into LDT-2008-v2-conductivity-sensors-CLEAN

LDT-2008: code review comments

both drivers need to be initialized since we dont know what Beta unit we are running until the FW receives test configuration(s).

both drivers need to be initialized since we dont know what Beta unit we are running until the FW receives test configuration(s).

LDT-3735: Updated logic to send record to dialin

    • -92
    • +203
    /firmware/App/Services/NVMsgQ.c
Dry bicart closed loop

    • -331
    • +457
    /firmware/App/Controllers/DryBiCart.c
    • -25
    • +20
    /firmware/App/Controllers/DryBiCart.h
Yes, this needs to be corrected. I don't see any controller existing properties defining these min and max. Will discuss further with you on this.

Yes, this needs to be corrected. I don't see any controller existing properties defining these min and max. Will discuss further with you on this.

Since feedforward output is same as control signal output, checking control signal min and max seems to be correct.

Since feedforward output is same as control signal output, checking control signal min and max seems to be correct.

Reduced gain and testing in progress.

Reduced gain and testing in progress.

Reduced gain and testing in progress.

Reduced gain and testing in progress.

Done.

Done.

Done.

Done.

LDT-3352 code review comments update

    • -11
    • +9
    /firmware/App/Controllers/Heaters.c
    • -2
    • +2
    /firmware/App/Modes/ModeGenDialysate.c
    • -53
    • +20
    /firmware/App/Monitors/Temperature.c
Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

    • -1
    • +1
    /firmware/App/Modes/ModeGenDialysate.c
    • -1
    • +1
    /firmware/App/Modes/ModeGenDialysate.h
LDT-3103 merged latest staging and resolved merge conflicts

    • -11
    • +21
    /firmware/App/Modes/ModeGenDialysate.c
LDT-3103 resolved merge conflicts

    • -2
    • +0
    /firmware/App/Modes/ModeGenDialysate.c
    • -1
    • +0
    /firmware/App/Modes/ModeGenDialysate.h
The FP signals are not included in the DD-pre gen/Gen dialysate transition functions. They have handled separately in the TD Interface.

The FP signals are not included in the DD-pre gen/Gen dialysate transition functions. They have handled separately in the TD Interface.

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

    • -2
    • +2
    /firmware/App/Modes/ModeGenDialysate.c
    • -2
    • +2
    /firmware/App/Modes/ModePreGenDialysate.c
Merge branch 'LDT-1195-dd-is-balancing-chamber-switching' into staging

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

    • -1
    • +1
    /firmware/App/Modes/FPModes/FPOperationModes.c
LDT-3677 merged into staging

its auto generated . should not change it manually. any way when merging its added correct value

its auto generated . should not change it manually. any way when merging its added correct value

Now we don't need this macro ?

Now we don't need this macro ?

now we are initializing sensor simultaneously?

now we are initializing sensor simultaneously?