dd-firmware / firmware / App / Controllers

RinsePump.c

Clone Tools

Stats

Commits this week: 1
Total Committers: 6
Last Commit: 11:27
Commits this week: 1

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
2 hrs ago

Vendor - TEL - Jashwant Gantyada

LDT-3963 enabled fault mode tranisiton for switching off hetares for dilaysate flow rate testing

Options
    • -1
    • +1
    ./RinsePump.c
  2. … 11 more files in changeset.
Tuesday 28 Apr
12:10 pm

Vinayakam Mani

First two logics ANDed correct (first cycle and close period). the third one (BC switch only must be ANDed only with close period), not to include first cycle..

First two logics ANDed correct (first cycle and close period). the third one (BC switch only must be ANDed only with close period), not to include first cycle..

Sunday 26 Apr
12:42 pm

Sean Nash

Don't assign BOOL variables implicitly. Always assign a FALSE or TRUE explicitly with ternary operator or inside an if statement.

Don't assign BOOL variables implicitly. Always assign a FALSE or TRUE explicitly with ternary operator or inside an if statement.

Tuesday 21 Apr
9:17 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3963_Dialysate Flow Rate - FW Implementation - 1/3:
LEAHI-DD-FIRMWARE-LDT-3963_Dialysate Flow Rate - FW Implementation - 1/3:
Friday 17 Apr
9:54 am

Vinayakam Mani

Tuesday 14 Apr
9:22 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./RinsePump.c
  2. … 12 more files in changeset.
7:47 pm

Sean Nash and Vendor - TEL - Sameer Poyil

4:39 pm

Vinayakam Mani

LDT-3352 resolving merge issues

Options
    • -1
    • +2
    ./RinsePump.c
  2. … 10 more files in changeset.
Monday 13 Apr
2:58 pm

Vinayakam Mani

Yes, this needs to be corrected. I don't see any controller existing properties defining these min and max. Will discuss further with you on this.

Yes, this needs to be corrected. I don't see any controller existing properties defining these min and max. Will discuss further with you on this.

12:00 pm

Vinayakam Mani

Since feedforward output is same as control signal output, checking control signal min and max seems to be correct.

Since feedforward output is same as control signal output, checking control signal min and max seems to be correct.

11:57 am

Vinayakam Mani

Reduced gain and testing in progress.

Reduced gain and testing in progress.

11:57 am

Vinayakam Mani

Reduced gain and testing in progress.

Reduced gain and testing in progress.

11:56 am

Vinayakam Mani

Done.

Done.

11:56 am

Vinayakam Mani

Done.

Done.

Monday 06 Apr
2:12 pm

Vinayakam Mani

1:19 pm

Raghu Kallala

LDT-3676 resolved merge commit with develop

Options
    • -1
    • +1
    ./RinsePump.c
  2. … 11 more files in changeset.
11:52 am

Vendor - TEL - Jashwant Gantyada and Sean Nash

10:30 am

Sean Nash

Not sure these min/max are right here either.

Not sure these min/max are right here either.

10:27 am

Sean Nash

So we have all temp sensors getting averaged now, right? So should we have one get function that takes a sensor ID as param?

So we have all temp sensors getting averaged now, right? So should we have one get function that takes a sensor ID as param?

10:24 am

Sean Nash

Remove extra blank lines.

Remove extra blank lines.

Friday 03 Apr
3:35 pm

Vinayakam Mani

Done.

Done.

3:34 pm

Vinayakam Mani

Done

Done

3:34 pm

Vinayakam Mani

Done.

Done.

1:20 pm

Sean Nash

Same comment.

Same comment.

1:19 pm

Sean Nash

Having much larger P coeff is likely to cause a lot of oscillations and very slow to get to stable target.

Having much larger P coeff is likely to cause a lot of oscillations and very slow to get to stable target.

1:14 pm

Sean Nash

Input is d78TempAvgC

Input is d78TempAvgC

1:13 pm

Sean Nash

I don't think these min/max (for control output in output units i.e. PWM) are appropriate for limiting maximum error sum step size (error is in feedback/target units i.e. RPM).

I don't think these min/max (for control output in output units i.e. PWM) are appropriate for limiting maximum error sum step size (error is in feedback/target units i.e. RPM).

9:32 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./RinsePump.c
  2. … 5 more files in changeset.
9:31 am

Vendor - TEL - Jashwant Gantyada

9:26 am

Vendor - TEL - Jashwant Gantyada

Merge branch 'LDT-3627-fp-dd-valves-the-valves-sensed-' into develop

Options
    • -0
    • +1
    ./RinsePump.c
  2. … 2 more files in changeset.