dd-firmware / firmware

App

Clone Tools

Stats

Commits this week: 61
Total Committers: 16
Last Commit: 01 May
Commits this week: 61

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 12 Feb
2:54 pm

Vendor - TEL - Jashwant Gantyada

LDT-2030 addressed code review comments

Options
    • -15
    • +2
    ./Drivers/BloodLeakDriver.c
    • -2
    • +0
    ./Drivers/BloodLeakDriver.h
2:29 pm

Sean Nash

Do we need to code this controller for multiple rinse pumps? I guess we've done it in some of the others, so I'm not against doing it this way. But if we do, we need to validate pumpID in a bunch o...

Do we need to code this controller for multiple rinse pumps? I guess we've done it in some of the others, so I'm not against doing it this way. But if we do, we need to validate pumpID in a bunch of functions and trigger a s/w fault if it's invalid.

2:22 pm

Sean Nash

Are we only publishing the measured pump speed? Even then, we should probably calculate it prior to the switch statement above in case we start using it in the states.

Are we only publishing the measured pump speed? Even then, we should probably calculate it prior to the switch statement above in case we start using it in the states.

2:18 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

2:17 pm

Sean Nash

Add a TODO to comment then.

Add a TODO to comment then.

2:02 pm

Sean Nash

Can these be done without loop (just fix the size to cover both columns of the array)?

Can these be done without loop (just fix the size to cover both columns of the array)?

2:01 pm

Sean Nash

This memset should be deleted since handled above in loop now.

This memset should be deleted since handled above in loop now.

2:00 pm

Sean Nash

Add a blank line after declaration.

Add a blank line after declaration.

1:57 pm

Raghu Kallala

This is a 4 byte reserved bits, not used at this time on Beta 1.9 or Beta 2.0

This is a 4 byte reserved bits, not used at this time on Beta 1.9 or Beta 2.0

1:57 pm

Raghu Kallala

This is a 4 byte reserved bits, not used at this time on Beta 1.9 or Beta 2.0

This is a 4 byte reserved bits, not used at this time on Beta 1.9 or Beta 2.0

1:54 pm

Vendor - TEL - Sameer Poyil

implement it in a single structure packing by moving all other pragma pack

implement it in a single structure packing by moving all other pragma pack

1:50 pm

Vendor - TEL - Jashwant Gantyada

done

done

1:45 pm

Vendor - TEL - Jashwant Gantyada

done

done

1:45 pm

Vendor - TEL - Jashwant Gantyada

changed

changed

1:45 pm

Vendor - TEL - Jashwant Gantyada

done

done

1:45 pm

Vendor - TEL - Jashwant Gantyada

done

done

1:45 pm

Vendor - TEL - Jashwant Gantyada

done

done

1:44 pm

Vendor - TEL - Jashwant Gantyada

done.

done.

1:44 pm

Vendor - TEL - Jashwant Gantyada

done.

done.

1:44 pm

Vendor - TEL - Jashwant Gantyada

done.

done.

1:44 pm

Vendor - TEL - Jashwant Gantyada

declared in the header and updated them.

declared in the header and updated them.

1:43 pm

Vendor - TEL - Jashwant Gantyada

Resolved. Thanks

Resolved. Thanks

1:43 pm

Vendor - TEL - Jashwant Gantyada

Resolved. Thanks

Resolved. Thanks

1:43 pm

Vendor - TEL - Jashwant Gantyada

LDT-2030 addressed code review comments

Options
    • -76
    • +86
    ./Drivers/BloodLeakDriver.c
    • -0
    • +8
    ./Drivers/BloodLeakDriver.h
    • -7
    • +6
    ./Monitors/BloodLeak.c
1:14 pm

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./DDCommon.h
12:46 pm

Raghu Kallala

LDT3344 updated rinsepump to work for beta1 and beta2

Options
    • -6
    • +20
    ./Controllers/RinsePump.c
    • -1
    • +1
    ./Controllers/Valves.c
    • -4
    • +7
    ./Monitors/Level.c
    • -2
    • +1
    ./Services/FpgaDD.c
10:32 am

Vendor - TEL - Jashwant Gantyada

done.

done.

10:32 am

Vendor - TEL - Jashwant Gantyada

done.

done.

10:32 am

Vendor - TEL - Jashwant Gantyada

done.

done.

10:28 am

Vendor - TEL - Jashwant Gantyada

LDT-3344- f/w changes for integrating beta 2 h/w

Options
    • -27
    • +45
    ./Controllers/RinsePump.c
    • -1
    • +7
    ./Controllers/RinsePump.h
    • -1
    • +1
    ./Controllers/Valves.c
    • -6
    • +20
    ./Drivers/GPIO.c
    • -8
    • +9
    ./Drivers/GPIO.h
    • -123
    • +145
    ./Monitors/Level.c
    • -3
    • +1
    ./Services/FpgaDD.c