dd-firmware

firmware

Clone Tools

Stats

Commits this week: 38
Total Committers: 16
Last Commit: 24 Apr
Commits this week: 38

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 11 Feb
2:02 pm

Vinayakam Mani

LDT-1473 code review comments

Options
    • -1
    • +1
    ./App/Controllers/ConcentratePumps.c
    • -1
    • +0
    ./App/Controllers/Heaters.c
1:34 pm

Sean Nash

For init functions, I'm ok with saying something like "Blood leak driver unit variables initialized".

For init functions, I'm ok with saying something like "Blood leak driver unit variables initialized".

1:33 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

1:33 pm

Sean Nash

Should these 2 #defines be converted to an enum? If we did that, we could add a "NUM_OF_" to end and use the "NUM_OF_" enum for array declarations instead of literal "2".

Should these 2 #defines be converted to an enum? If we did that, we could add a "NUM_OF_" to end and use the "NUM_OF_" enum for array declarations instead of literal "2".

1:31 pm

Sean Nash

Some of these memset calls are zeroing a 2-dimensional array, so the size param is too short (only sizing 1st dimension).

Some of these memset calls are zeroing a 2-dimensional array, so the size param is too short (only sizing 1st dimension).

1:28 pm

Sean Nash

Ok as is. We only need to have constant/literal first when using == operator to prevent confusion with = operator.

Ok as is. We only need to have constant/literal first when using == operator to prevent confusion with = operator.

1:26 pm

Sean Nash

Actually, for casting, I prefer no spaces around ().

Actually, for casting, I prefer no spaces around ().

1:25 pm

Sean Nash

Declare these earlier and just assign them here (i.e. keep declarations together at top of function).

Declare these earlier and just assign them here (i.e. keep declarations together at top of function).

1:23 pm

Michael Garthwaite

Merge branch 'staging' into LDT-2004-v2-conductivity-sensors

Options
    • -1
    • +1
    ./App/DDCommon.h
    • -2
    • +2
    ./App/Services/Messaging.c
12:47 pm

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./App/DDCommon.h
12:41 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./App/Controllers/Valves.c
    • -1
    • +1
    ./App/Drivers/ConductivityTeensy.c
    • -1
    • +1
    ./App/Drivers/ConductivityTeensy.h
    • -2
    • +2
    ./App/Services/Messaging.c
12:01 pm

Vendor - TEL - Arpita Srivastava

I do not see bloodLeakDataPublicationTimerCounter being initialized in the function. Should we add bloodLeakEmbModeCmdQ to the list?

I do not see bloodLeakDataPublicationTimerCounter being initialized in the function.
Should we add bloodLeakEmbModeCmdQ to the list?

11:59 am

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./App/DDCommon.h
11:58 am

Michael Garthwaite

Merge branch 'LDT-2990-iofp-fw-and-fpga-version' into develop

Options
    • -0
    • +14
    ./App/DDCommon.h
    • -0
    • +12
    ./App/Services/Messaging.c
11:57 am

Michael Garthwaite

LDT-2990: added fp version response to the dd handle version request message.

Options
    • -0
    • +14
    ./App/DDCommon.h
    • -0
    • +12
    ./App/Services/Messaging.c
11:53 am

Vendor - TEL - Arpita Srivastava

Please change bloodLeakState != BLOOD_LEAK_VERIFY_INTENSITY_AFTER_ZEROING_STATE to BLOOD_LEAK_VERIFY_INTENSITY_AFTER_ZEROING_STATE != bloodLeakState

Please change

bloodLeakState != BLOOD_LEAK_VERIFY_INTENSITY_AFTER_ZEROING_STATE
to
BLOOD_LEAK_VERIFY_INTENSITY_AFTER_ZEROING_STATE != bloodLeakState

11:49 am

Vendor - TEL - Arpita Srivastava

Please remove extra line

Please remove extra line

11:49 am

Vendor - TEL - Arpita Srivastava

Minor: Need space in (BLOOD_LEAK_EMB_MODE_CMD_T)

Minor: Need space in (BLOOD_LEAK_EMB_MODE_CMD_T)

11:45 am

Vendor - TEL - Arpita Srivastava

Minor: Need space between parentheses

Minor: Need space between parentheses

11:45 am

Vendor - TEL - Arpita Srivastava

Minor: Need space between parentheses

Minor: Need space between parentheses

11:19 am

Michael Garthwaite

Merge branch 'staging' into LDT-2004-v2-conductivity-sensors

Options
    • -1
    • +1
    ./App/DDCommon.h
    • -4
    • +11
    ./App/Services/Messaging.c
11:18 am

Michael Garthwaite

11:12 am

Vinayakam Mani

Remove the empty space.

Remove the empty space.

11:11 am

Vinayakam Mani

Can we remove this #if check? we can keep the comment.

Can we remove this #if check? we can keep the comment.

11:07 am

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./App/DDCommon.h
11:07 am

Vinayakam Mani

can we get each group of level check in to a function and call those functions for each case?

can we get each group of level check in to a function and call those functions for each case?

11:01 am

Sean Nash and Vendor - TEL - Sameer Poyil

10:45 am

Vendor - TEL - Arpita Srivastava

Minor: Please add space in [cmd].

Minor: Please add space in [cmd].

10:45 am

Vendor - TEL - Arpita Srivastava

Should it be bloodLeakEmbModeCmd?

Should it be bloodLeakEmbModeCmd?

10:07 am

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./App/DDCommon.h