Activity leahi-common/

3:24 pm

Raghu Kallala

More
a685362
changed 1 file
LDT-1195-dd-is-balancing-chamber-switching, LDT-1394-blood-flow-rate-h4-rotor-count and 36 more LEAHI-DD-FIRMWARE-LDT-2185-1

LDT-2185 updated alarm 150.

- -4
- +4
/AlarmDefs.h
- History
- Source
- Diff
/AlarmDefs.h

11:17 am

Vendor - TEL - Varshini Nagabooshanam

More
53b4d00
changed 1 file
LDT-1195-dd-is-balancing-chamber-switching, LDT-1394-blood-flow-rate-h4-rotor-count and 33 more LEAHI-DD-FIRMWARE-LDT-2998-1

Merge branch 'staging' into LDT-2998-update-dialin-to-support-any-b1

- -1
- +1
/DDDefs.h
- History
- Source
- Diff
/DDDefs.h

10:29 pm

Vendor - TEL - Sameer Poyil

This is a test support sub function.

10:26 pm

Vendor - TEL - Sameer Poyil

This is retained for future use. This function check two temperatures, whereas above function checkInletTemperature only check one temperature D1 or P10.

2:35 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-3126-1
commented on review

I believe this function only takes 1 param in Leahi.

2:34 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-3126-1
commented on review

This unit does not compile w/o errors - always build and check for errors before committing/pushing changes. At least one issue is that we need to include Valve3Way.h and I suspect other includes a...

This unit does not compile w/o errors - always build and check for errors before committing/pushing changes. At least one issue is that we need to include Valve3Way.h and I suspect other includes are missing as well (check bottom of compiler warnings list).

2:15 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-3126-1
commented on review

Change BloodPrime to StateTxBloodPrime here too.

2:14 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-3126-1
commented on review

Function headers that we copy from Denali will not have some of the new formatting changes - make sure to update all of them to Leahi format (see from other units for example). In this case, there ...

Function headers that we copy from Denali will not have some of the new formatting changes - make sure to update all of them to Leahi format (see from other units for example). In this case, there should be a \b before the type of details (Inputs and Outputs here) so they will be bold when documentation is generated.

2:11 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-3126-1
commented on review

Add a details line for Message Sent for the broadcast data message.

2:09 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-3126-1
commented on review

I don't see these override message handler functions being added to table in Messages.c. And I don't see new Dialin message IDs added to enum in MsgDefs.h.

2:05 pm