leahi-common

Clone Tools

Stats

Commits this week: 11
Total Committers: 16
Last Commit: 03 Apr
Commits this week: 11

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 02 Feb
9:17 am

Michael Garthwaite

Merge branch 'LDT-2004-dialysate-composition-dd' into staging

Options
9:15 am

Michael Garthwaite

Friday 30 Jan
10:14 pm

Vendor - TEL - Sameer Poyil

Complex conditional expressions can be avoided. Introduce temporary boolean variables instead. for example if ((elementNo < 0) || (elementNo > maxElement)|| elementNo == lastElement){ … } should b...

Complex conditional expressions can be avoided. Introduce
temporary boolean variables instead.

for example
if ((elementNo < 0) || (elementNo > maxElement)||
elementNo == lastElement)

Unknown macro: { … }


should be replaced by:
isFinished = (elementNo < 0) || (elementNo > maxElement);
isRepeatedEntry = elementNo == lastElement;
if ((isFinished == TRUE) || (isRepeatedEntry == TRUE))

4:32 pm

Vendor - TEL - Sameer Poyil

its rate , pump speed in ml/min

its rate , pump speed in ml/min

3:32 pm

Vendor - TEL - Varshini Nagabooshanam

LEAHI-TD-FIRMWARE-LDT-1415_Pressures Monitoring - TD
LEAHI-TD-FIRMWARE-LDT-1415_Pressures Monitoring - TD
3:04 pm

Vendor - TEL - Sameer Poyil

Fixed.

Fixed.

3:02 pm

Vendor - TEL - Sameer Poyil

When flag is true and Drain complete , it remains in the DRY_BICART_FLUID_DRAIN_END_STATE, when it is cleared, it go back to DRY_BICART_DRAIN_START_STATE Its fixed now

When flag is true and Drain complete , it remains in the DRY_BICART_FLUID_DRAIN_END_STATE, when it is cleared, it go back to DRY_BICART_DRAIN_START_STATE
Its fixed now

12:12 pm

Sean Nash

It looks to me like the state machine (drain for example) will keep running so long as the flag is true. I would think it should set the flag to false when drain is done.

It looks to me like the state machine (drain for example) will keep running so long as the flag is true. I would think it should set the flag to false when drain is done.

11:53 am

Vendor - TEL - Sameer Poyil

right now, only bicarbChamberFillRequested is cleared during the supply. dryBiCartFillRequested and dryBiCartDrainRequested has a Fill/Drain complete state and it remains in that state to check com...

right now, only bicarbChamberFillRequested is cleared during the supply. dryBiCartFillRequested and dryBiCartDrainRequested has a Fill/Drain complete state and it remains in that state to check completion state programmatically. an explicit clear request is required to start the next operation. Do I need to clear it ?

11:33 am

Sean Nash

Where do these request flags get set back to FALSE after request is serviced?

Where do these request flags get set back to FALSE after request is serviced?

11:31 am

Sean Nash

Why is drain request flag different (ends in "ed")?

Why is drain request flag different (ends in "ed")?

11:02 am

Vendor - TEL - Sameer Poyil

LDT-2004-3 drybicart feature updates

Options
    • -0
    • +4
    /DDDefs.h
    • -0
    • +1
    /MsgDefs.h
Thursday 29 Jan
4:34 pm

Dara Navaei

LDT-1415 added a comment in the DD valves enum

Options
    • -1
    • +1
    /DDDefs.h
3:54 pm

Vendor - TEL - Varshini Nagabooshanam

Merge LDT-1415-pressures-monitoring-td

Options
    • -1
    • +5
    /DDDefs.h
    • -2
    • +16
    /MsgDefs.h
2:53 pm

Vendor - TEL - Varshini Nagabooshanam

2:25 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

2:17 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

2:15 pm

Sean Nash

Format for params is: param name description Add "psi" (name) between param and "Pressure value in PSI".

Format for params is: param name description
Add "psi" (name) between param and "Pressure value in PSI".

2:04 pm

Vendor - TEL - Varshini Nagabooshanam

I removed

I removed

2:04 pm

Vendor - TEL - Varshini Nagabooshanam

Sorry, updated

Sorry, updated

2:02 pm

Vendor - TEL - Jashwant Gantyada

done.

done.

1:53 pm

Sean Nash

Please keep local declarations together up top.

Please keep local declarations together up top.

1:49 pm

Vendor - TEL - Jashwant Gantyada

removed.

removed.

1:49 pm

Vendor - TEL - Jashwant Gantyada

done.

done.

1:29 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

1:29 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

1:28 pm

Vendor - TEL - Varshini Nagabooshanam

LDT-1415-pressures-monitoring-td

Options
    • -2
    • +2
    /AlarmDefs.h
1:23 pm

Sean Nash

Add space between = and (F32)

Add space between = and (F32)

1:19 pm

Vendor - TEL - Varshini Nagabooshanam

Yes we need to add

Yes we need to add

1:19 pm

Sean Nash

Added param looks wrong.

Added param looks wrong.