leahi-common

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LDT-2004-3 removing pressure equillibrium state

input parameter not updated

input parameter not updated

input parameter is not updated

input parameter is not updated

input and output is not updated properly

input and output is not updated properly

structure packing required

structure packing required

fixed it

fixed it

fixed it

fixed it

This state machine running continuously. fill request is initiated for every 1 minutes of balancing chamber exec (since right now level sensor is not working ) //Increment counter for dry bicarb c...

This state machine running continuously. fill request is initiated for every 1 minutes of balancing chamber exec (since right now level sensor is not working )

//Increment counter for dry bicarb chamber fill
bicarbChamberPeriodicFillCounter += 1;
// Fill bicarb chamber once every 60secs.
if ( bicarbChamberPeriodicFillCounter >= BICARB_CHAMBER_PERIODIC_FILL_TIME )

Unknown macro: { setBicarbChamberFillRequested(); bicarbChamberPeriodicFillCounter = 0; }


The request is cleared here. for consistency I am moving to the end of the fill cycle

LEAHI-TD-FIRMWARE-LDT-1415_Pressures Monitoring - TD
LEAHI-TD-FIRMWARE-LDT-1415_Pressures Monitoring - TD
LDT-1415-pressures-monitoring-td

LDT-1415-pressures-monitoring-td

Merge branch 'develop' of bitbucket.org:diality-cloud/leahi-common into develop

Yes, we do and this is not required here so, I removed

Yes, we do and this is not required here so, I removed

LDT-1415-pressures-monitoring-td

Shouldn't we be getting these defaults from the TxParams unit?

Shouldn't we be getting these defaults from the TxParams unit?

Remove blank line.

Remove blank line.

Add a blank line before return statement.

Add a blank line before return statement.

Why is this commented out?

Why is this commented out?

d48PumpSpeed is an input.

d48PumpSpeed is an input.

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
Yes, Updated

Yes, Updated

Why is this flag set to FALSE here in start state while the other request flags are set to FALSE in their completed states?

Why is this flag set to FALSE here in start state while the other request flags are set to FALSE in their completed states?

Should there be any constraints to setting these request flags to TRUE? What if drain request is still in progress for example? Shouldn't drain finish before fill starts? This wouldn't be an issue ...

Should there be any constraints to setting these request flags to TRUE? What if drain request is still in progress for example? Shouldn't drain finish before fill starts?
This wouldn't be an issue if we combined the 3 state machines.

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

I think this should be commented out before we merge to staging.

I think this should be commented out before we merge to staging.

Merge branch 'LDT-2004-dialysate-composition-dd' into staging