leahi-common

Clone Tools

Stats

Commits this week: 12
Total Committers: 16
Last Commit: 10:37
Commits this week: 12

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 06 Feb
8:07 pm

Vendor - TEL - Sameer Poyil

LDT-2004 drybicart updates

Options
    • -1
    • +1
    /DDDefs.h
7:35 pm

Vendor - TEL - Sameer Poyil

Fixed it

Fixed it

7:34 pm

Vendor - TEL - Sameer Poyil

Ya , I forgot the coding guide line . Fixed it

Ya , I forgot the coding guide line .
Fixed it

7:34 pm

Vendor - TEL - Sameer Poyil

fixed it

fixed it

7:34 pm

Vendor - TEL - Sameer Poyil

Fixed it

Fixed it

7:32 pm

Vendor - TEL - Sameer Poyil

fixed it

fixed it

3:56 pm

Sean Nash

2:22 pm

Sean Nash

Use explicit BOOL conditions (e.g. TRUE == isFreshDialysatePressureInRange).

Use explicit BOOL conditions (e.g. TRUE == isFreshDialysatePressureInRange).

1:06 pm

Stephen Quong

10:52 am

Sean Nash

I prefer to be explicit on BOOL conditions like this (e.g. TRUE == isFreshDialysatePressureInRange).

I prefer to be explicit on BOOL conditions like this (e.g. TRUE == isFreshDialysatePressureInRange).

10:51 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

9:26 am

Vinayakam Mani

I don't think we need to check test config for variable initialization.

I don't think we need to check test config for variable initialization.

9:13 am

Vendor - TEL - Sameer Poyil

fixed it

fixed it

9:10 am

Vendor - TEL - Sameer Poyil

Fixed it

Fixed it

9:04 am

Vendor - TEL - Sameer Poyil

fixed it

fixed it

9:04 am

Vendor - TEL - Sameer Poyil

fixed it

fixed it

9:03 am

Vendor - TEL - Sameer Poyil

fixed it

fixed it

9:03 am

Vendor - TEL - Sameer Poyil

fixed it

fixed it

9:01 am

Vendor - TEL - Sameer Poyil

fixed it

fixed it

9:00 am

Vendor - TEL - Sameer Poyil

LDT-2004-3 implementing review comments

Options
    • -1
    • +1
    /DDDefs.h
Thursday 05 Feb
7:27 pm

Vendor - TEL - Sameer Poyil

Since fill and drain is a single time request and it is not a frequent request similar to supply during dialysate generation. I removed and now run as idle

Since fill and drain is a single time request and it is not a frequent request similar to supply during dialysate generation. I removed and now run as idle

7:24 pm

Vendor - TEL - Sameer Poyil

To make it exclusive operation. no previous request should be pending when a new operation is requested. So only one state machine is running at a time. otherwise, while chamber fill is in progress...

To make it exclusive operation. no previous request should be pending when a new operation is requested. So only one state machine is running at a time. otherwise, while chamber fill is in progress, anyone can request drain and both requests will be handled. even through new code run only one state machine at a time, this will ensure that only one request is submitted to drybicart

This was a concern reported by Sean and proposed for restructuring into a single state machine.

3:45 pm

Raghu Kallala

LDT-3344 reverted DD valve changes

Options
    • -2
    • +2
    /DDDefs.h
3:41 pm

Dara Navaei

Merged staging

Options
    • -1
    • +1
    /DDDefs.h
    • -2
    • +2
    /MsgDefs.h
3:39 pm

Raghu Kallala

LDT-3344 merge latest from staging

Options
    • -3
    • +3
    /DDDefs.h
3:20 pm

Vendor - TEL - Jashwant Gantyada

LDT-3344 changes made to registers

Options
    • -4
    • +4
    /DDDefs.h
2:17 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3344_Firmware support for Beta 2 FPGA updates.
LEAHI-DD-FIRMWARE-LDT-3344_Firmware support for Beta 2 FPGA updates.
1:01 pm

Sean Nash

This doesn't look like a valid substate. We should have an enum for valid substates. In default case, we should trigger a s/w fault and also set the state to a valid state (idle or something like t...

This doesn't look like a valid substate. We should have an enum for valid substates. In default case, we should trigger a s/w fault and also set the state to a valid state (idle or something like that).

12:53 pm

Sean Nash

I think /// was correct. // will not be seen by doxygen.

I think /// was correct. // will not be seen by doxygen.

11:10 am

Nicholas Ramirez , Behrouz NematiPour and Tiffany Mejia