leahi-common

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Mask value seems wrong. please update per HDD.

Mask value seems wrong. please update per HDD.

This code review contains known issues, and it is not yet ready for a detailed review.

This code review contains known issues, and it is not yet ready for a detailed review.

this has already been addressed. I think you have commented on removed code.

this has already been addressed. I think you have commented on removed code.

added a todo for testing it after we have the new beta 2 units.

added a todo for testing it after we have the new beta 2 units.

added a todo for testing it after we have the new beta 2 units.

added a todo for testing it after we have the new beta 2 units.

We will be merging the latest staging and resolve the conflicts after the CR approval.

We will be merging the latest staging and resolve the conflicts after the CR approval.

Beta 1.0 and Beta 1.9 , there small difference, please check with Noe if he can re-implement the registers for conductivity in last part.

Beta 1.0 and Beta 1.9 , there small difference, please check with Noe if he can re-implement the registers for conductivity in last part.

Beta2 is the final structure and it should be named as DD_FPGA_SENSORS_T and give respective name for all other variants Beta 1.0 and Beta 1.9

Beta2 is the final structure and it should be named as DD_FPGA_SENSORS_T and give respective name for all other variants Beta 1.0 and Beta 1.9

Seems old file. sync with latest staging

Seems old file. sync with latest staging

It should be removed and initialized based on FPGA version. no config for any beta 1.0 , 1.9 or 2.0

It should be removed and initialized based on FPGA version. no config for any beta 1.0 , 1.9 or 2.0

Will resolve it while merging the staging to this branch after CR approval

Will resolve it while merging the staging to this branch after CR approval

done. added a TODO.

done. added a TODO.

I have added the mentioned ones.

I have added the mentioned ones.

done.

done.

done.

done.

done.

done.

done

done

done

done

added a todo.

added a todo.

removed.

removed.

we can start with 500msec. if we change the speed during runtime, say 10% to 20% PWM, need to see how long it takes to stabilize and accordingly this persistence can be set.

we can start with 500msec. if we change the speed during runtime, say 10% to 20% PWM, need to see how long it takes to stabilize and accordingly this persistence can be set.

fixed

fixed

reworded

reworded

Updated

Updated

Based on the Denali properties, I have written the following.

Based on the Denali properties, I have written the following.

replace with else block

replace with else block

convert to switch case

convert to switch case

set treatment modality.

set treatment modality.

Priority doesn't look right. Should be High I think. Check properties from Denali project.

Priority doesn't look right. Should be High I think. Check properties from Denali project.