leahi-common

Clone Tools

Stats

Commits this week: 18
Total Committers: 16
Last Commit: 14:52
Commits this week: 18

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 19 Feb
4:32 pm

Vendor - TEL - Jashwant Gantyada

LDT-3344 addressed code review comments

Options
    • -3
    • +3
    /AlarmDefs.h
1:01 pm

Raghu Kallala

They were removed accidentally is what my understanding is, identify issued after commit cfa8ae2. reverted the changes with cherry picking the commits

They were removed accidentally is what my understanding is, identify issued after commit cfa8ae2.
reverted the changes with cherry picking the commits

1:00 pm

Raghu Kallala

Updated

Updated

1:00 pm

Raghu Kallala

Updated

Updated

12:59 pm

Raghu Kallala

the fix has been reverted

the fix has been reverted

12:59 pm

Raghu Kallala

As discussed, this will be done after we stabilize to single fpga structure. To avoid multiple line changes.

As discussed, this will be done after we stabilize to single fpga structure. To avoid multiple line changes.

11:40 am

Vendor - TEL - Varshini Nagabooshanam

LDT-3539-air-infusion-td

Options
    • -2
    • +2
    /AlarmDefs.h
11:28 am

Vendor - TEL - Sameer Poyil

There is a standardized level checking logic proposed , please check with Noe

There is a standardized level checking logic proposed , please check with Noe

11:27 am

Vendor - TEL - Sameer Poyil

please use FPGA version function to initialize or handle HW version

please use FPGA version function to initialize or handle HW version

11:24 am

Vendor - TEL - Sameer Poyil

read the FPGA ID and initialize it

read the FPGA ID and initialize it

11:23 am

Vendor - TEL - Sameer Poyil

remove #if 1 and add a TODO with this comment

remove #if 1 and add a TODO with this comment

11:22 am

Vendor - TEL - Sameer Poyil

Yes define registers for all variants without #if 1 and mark a TODO for removal later.

Yes define registers for all variants without #if 1 and mark a TODO for removal later.

7:17 am

Raghu Kallala

Had that question. Thanks Changed to else block

Had that question. Thanks
Changed to else block

7:13 am

Raghu Kallala

Updated

Updated

7:07 am

Raghu Kallala

This will be gone once we have institutional records, do you still want me to move it to a separate func?

This will be gone once we have institutional records, do you still want me to move it to a separate func?

7:06 am

Raghu Kallala

Fixed

Fixed

Wednesday 18 Feb
10:09 pm

Sean Nash

Can we uncomment these and send msg?

Can we uncomment these and send msg?

10:08 pm

Sean Nash

Can we uncomment this and send the limits to the UI?

Can we uncomment this and send the limits to the UI?

10:06 pm

Sean Nash

Should we cast these to (S32)?

Should we cast these to (S32)?

10:04 pm

Sean Nash

These 2 last values have already been used above. Change to 154 and 155.

These 2 last values have already been used above. Change to 154 and 155.

10:02 pm

Sean Nash

Can this stuff down here be done in a separate function that is called here? This function is too big.

Can this stuff down here be done in a separate function that is called here? This function is too big.

10:02 pm

Sean Nash

Should this just be an "else" to above condition?

Should this just be an "else" to above condition?

9:58 pm

Sean Nash

When do you plan on removing this?

When do you plan on removing this?

9:56 pm

Sean Nash

Just a heads up that all message handling functions in Leahi have the same prototype - just different function names (i.e. BOOL funcName( MESSAGE_T *message)) and that includes all Dialin command m...

Just a heads up that all message handling functions in Leahi have the same prototype - just different function names (i.e. BOOL funcName( MESSAGE_T *message)) and that includes all Dialin command message handlers like these.

9:48 pm

Sean Nash

This param has been renamed to HEPARIN_STOP_TIME which is a couple rows below so we don't need to add this.

This param has been renamed to HEPARIN_STOP_TIME which is a couple rows below so we don't need to add this.

9:47 pm

Sean Nash

We will not have this saline bolus state in Leahi.

We will not have this saline bolus state in Leahi.

9:45 pm

Sean Nash

This alarm does not belong here. Put it back where it was before. In the next table below, the alarms are sorted by rank. But this property table is sorted by alarm ID #.

This alarm does not belong here. Put it back where it was before.
In the next table below, the alarms are sorted by rank. But this property table is sorted by alarm ID #.

9:43 pm

Sean Nash

Why did you move it. The alarm is #30 so it should stay here where you had it before.

Why did you move it. The alarm is #30 so it should stay here where you had it before.

3:52 pm

Sean Nash

Only 1 return per function.

Only 1 return per function.

3:50 pm

Sean Nash

If result is U08, why are we returning U16?

If result is U08, why are we returning U16?