leahi-common

Clone Tools

Stats

Commits this week: 28
Total Committers: 19
Last Commit: 12 Jun
Commits this week: 28

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 20 Feb
11:38 am

Raghu Kallala

LDt-473 updated the enum list

Options
    • -25
    • +1
    /TDDefs.h
11:37 am

Sean Nash

This was correct before (assuming 711 was correct rank).

This was correct before (assuming 711 was correct rank).

11:36 am

Sean Nash

Why change rank back to 206? If priority is low, rank was probably correct at 711. I think you had correct properties before - it was just in the wrong row.

Why change rank back to 206? If priority is low, rank was probably correct at 711. I think you had correct properties before - it was just in the wrong row.

11:32 am

Sean Nash

In comment, specify units is % duty cycle (0..100%).

In comment, specify units is % duty cycle (0..100%).

11:31 am

Sean Nash

Should we specify that power level is now a duty cycle percentage (0..100%)?

Should we specify that power level is now a duty cycle percentage (0..100%)?

11:26 am

Raghu Kallala

Updated

Updated

11:26 am

Raghu Kallala

Updated

Updated

11:25 am

Sean Nash

We have a FRACTION_TO_PERCENT_FACTOR in Common.h that we can use when we need 100.0.

We have a FRACTION_TO_PERCENT_FACTOR in Common.h that we can use when we need 100.0.

11:22 am

Sean Nash

We've been using capital F. Let's be consistent.

We've been using capital F. Let's be consistent.

11:21 am

Sean Nash

Don't call function in function call. Set local var to scalar, then pass local var as param.

Don't call function in function call. Set local var to scalar, then pass local var as param.

11:10 am

Sean Nash

You can use RANGE macro in Common.h for this.

You can use RANGE macro in Common.h for this.

11:07 am

Sean Nash

( F32 percentage ) { }

( F32 percentage )
{
}

11:06 am

Sean Nash

Add space around () i.e. ..Scalar( F32 percentage );

Add space around () i.e. ..Scalar( F32 percentage );

11:03 am

Sean Nash

Noe says we can distinguish between beta 1.9 and 2.0 w/ ID (4 and 6). We still need test configs for beta 1.0 stuff and non-fpga differences. We can use DD fpga ID # here in this macro instead of t...

Noe says we can distinguish between beta 1.9 and 2.0 w/ ID (4 and 6).
We still need test configs for beta 1.0 stuff and non-fpga differences.
We can use DD fpga ID # here in this macro instead of test config.
Since this is all temporary, I'm not that concerned about how we do this so long as it works.

10:23 am

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

10:23 am

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

10:22 am

Sean Nash

I think Sameer is saying that the monitor should just call one get level function in FPGA and that one function (in FpgaDD.c) would handle all of this beta 1/1.9/2.0 stuff. I agree, but didn't comm...

I think Sameer is saying that the monitor should just call one get level function in FPGA and that one function (in FpgaDD.c) would handle all of this beta 1/1.9/2.0 stuff.
I agree, but didn't comment on it because it's all temporary anyway.

10:21 am

Vendor - TEL - Varshini Nagabooshanam

LDT-3539-air-infusion-td

Options
    • -1
    • +1
    /AlarmDefs.h
9:59 am

Sean Nash

Why do we need a get function to call another get function? The caller of this function should just call getFPGAGPIOStatus() and then we wouldn't need this.

Why do we need a get function to call another get function? The caller of this function should just call getFPGAGPIOStatus() and then we wouldn't need this.

9:46 am

Sean Nash

Move this up to public definitions section.

Move this up to public definitions section.

9:40 am

Vendor - TEL - Sameer Poyil

LEAHI-TD-FIRMWARE-LDT-1903_Air Trap Level Control - TD - 04: DEV - Feature Implementation
LEAHI-TD-FIRMWARE-LDT-1903_Air Trap Level Control - TD - 04: DEV - Feature Implementation
9:17 am

Sean Nash

Outputs is none now I think.

Outputs is none now I think.

8:33 am

Raghu Kallala

LDT-473 ISDO UF is for phase 3

Options
    • -1
    • +1
    /TDDefs.h
7:59 am

Raghu Kallala

readFloaterLevelStatus is higher level functions that give the data from the FPGA. Reason why we had these get functions here is, based on the FPGA response we translate it to the user understandab...

readFloaterLevelStatus is higher level functions that give the data from the FPGA.
Reason why we had these get functions here is, based on the FPGA response we translate it to the user understandable enum values (low, medium, high)

7:55 am

Raghu Kallala

This is a reset call, as the default requirement is to be on Beta 1.9 HW The logic is checking if the user is resetting the Beta 2.0 config, if yes, we will have to fall back to the Beta 1.9 FPGA r...

This is a reset call, as the default requirement is to be on Beta 1.9 HW
The logic is checking if the user is resetting the Beta 2.0 config, if yes, we will have to fall back to the Beta 1.9 FPGA registers

1:05 am

Vendor - TEL - Sameer Poyil

Level.c is a higher level abstracted functions and should not implement the HW dependent details in this file. this details should be pushed to FPGADD. and single function should handle all the cas...

Level.c is a higher level abstracted functions and should not implement the HW dependent details in this file. this details should be pushed to FPGADD. and single function should handle all the cases instead of multiple functions.

12:29 am

Vendor - TEL - Sameer Poyil

Its not required, HW should be auto detected and initialized without any user configuration.

Its not required, HW should be auto detected and initialized without any user configuration.

12:25 am

Vendor - TEL - Sameer Poyil

why its checking beta 2 and then setting beta 1.9 HW ?

why its checking beta 2 and then setting beta 1.9 HW ?

12:22 am

Vendor - TEL - Sameer Poyil

We don't need this complex logic . use getFPGAVersions() function

We don't need this complex logic . use getFPGAVersions() function

12:18 am

Vendor - TEL - Sameer Poyil

use getFPGAVersions() to check this . if Beta 1.9 , FPGA version id is 4 and 6 if beta 2.0

use getFPGAVersions() to check this . if Beta 1.9 , FPGA version id is 4 and 6 if beta 2.0