Activity leahi-common/

Tree
Accordion

Stats

Commits this week: 19

Total Committers:	16
Last Commit:	10:38
Commits this week:	19

Lines of code count not available

Commit Activity

last updated a few minutes ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Monday 23 Feb

1:19 pm

Raghu Kallala

More
d5a65c0
changed 1 file
LDT-3344-firmware-support-for-beta-2-fpg, develop, staging LEAHI-DD-FIRMWARE-LDT-3344-1

LDT-3344 merge latest from staging

- -3
- +51
/DDDefs.h
- History
- Source
- Diff
/DDDefs.h

1:18 pm

Vendor - TEL - Jashwant Gantyada

More
LEAHI-DD-FIRMWARE-LDT-3344-1
started review

LEAHI-DD-FIRMWARE-LDT-3344_Firmware support for Beta 2 FPGA updates.

LEAHI-DD-FIRMWARE-LDT-3344_Firmware support for Beta 2 FPGA updates.

1:04 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-3126-1
commented on review

Add spaces inside of ().

Add spaces inside of ().

1:03 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-3126-1
commented on review

Stop button is a "hard" pause which would take us to Treatment: Paused state (out of blood prime completely). We want to go to our internal paused state when UI sends us a "soft" blood prime pause ...

Stop button is a "hard" pause which would take us to Treatment: Paused state (out of blood prime completely).
We want to go to our internal paused state when UI sends us a "soft" blood prime pause commands message.

1:01 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-3126-1
commented on review

Remove blank line.

Remove blank line.

1:00 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-3126-1
commented on review

Should we add this test config? Systems team will likely want it eventually since they wanted it in Denali.

Should we add this test config? Systems team will likely want it eventually since they wanted it in Denali.

12:56 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-1903-8
commented on review

Put each condition in (). Also, should the setAirPumpState function be checking power is in range instead of here?

Put each condition in ().
Also, should the setAirPumpState function be checking power is in range instead of here?

12:53 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-1903-8
commented on review

You have these MIN/MAX definitions in both this unit and AirPump unit. Can we put these in header file for this unit and remove from AirPump unit?

You have these MIN/MAX definitions in both this unit and AirPump unit. Can we put these in header file for this unit and remove from AirPump unit?

12:52 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-1903-8
commented on review

Remove extra blank line.

Remove extra blank line.

12:50 pm

Vendor - TEL - Varshini Nagabooshanam

Removed

Removed

12:50 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

12:50 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

12:50 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

12:50 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

12:49 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

12:49 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

12:49 pm

Vendor - TEL - Varshini Nagabooshanam

I will Update as per Raghu treatment parameter

I will Update as per Raghu treatment parameter

12:47 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-1903-8
commented on review

This looks like develop branch got merged into your branch. We should not be doing that. Always merge your branch to develop in that direction only.

This looks like develop branch got merged into your branch. We should not be doing that. Always merge your branch to develop in that direction only.

Saturday 21 Feb

7:10 pm

Vendor - TEL - Sameer Poyil

More
Re: LEAHI-TD-FIRMWARE-LDT-1903-8
commented on review

capital F

capital F

3:49 pm

Dara Navaei

More
cd09d3c
changed 6 files
BambooSetup

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -1
- +1
/AlarmDefs.h
- History
- Source
- Diff
/AlarmDefs.h
- -1
- +1
/Compatible.h
- History
- Source
- Diff
/Compatible.h
- -1
- +1
/DDDefs.h
- History
- Source
- Diff
/DDDefs.h
- -1
- +1
/MsgDefs.h
- History
- Source
- Diff
/MsgDefs.h
- -1
- +1
/RODefs.h
- History
- Source
- Diff
/RODefs.h
- -1
- +1
/TDDefs.h
- History
- Source
- Diff
/TDDefs.h

Friday 20 Feb

3:01 pm

Vendor - TEL - Jashwant Gantyada

2:52 pm

Vendor - TEL - Arpita Srivastava

More
8577933
changed 1 file
LDT-3505-heparin-td-04-dev-feature-implemenation LEAHI-TD-FIRMWARE-LDT-3505-1

LDT-3505: Added msg id for heparin pause and resume

- -0
- +1
/MsgDefs.h
- History
- Source
- Diff
/MsgDefs.h

2:19 pm

Vendor - TEL - Sameer Poyil

This is total mess up . that is what I want it a clean implementation. created a ticket LDT-3563 and closing all review comments.

This is total mess up . that is what I want it a clean implementation. created a ticket LDT-3563 and closing all review comments.

2:17 pm

Vendor - TEL - Sameer Poyil

Removing all the review comments and created a ticket to handle it in separate ticket -LDT-3563

Removing all the review comments and created a ticket to handle it in separate ticket -LDT-3563

1:48 pm

Sean Nash

More
LEAHI-TD-FIRMWARE-LDT-3539-1
finished reviewing

1:42 pm

Vendor - TEL - Jashwant Gantyada

removed.

removed.

1:42 pm

Raghu Kallala

Updated

Updated

1:42 pm

Vendor - TEL - Jashwant Gantyada

changed.

changed.

1:41 pm

Vendor - TEL - Jashwant Gantyada

removed.

removed.

1:36 pm

Raghu Kallala

Updated

Updated

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-02-24 17:54 -0800