leahi-common

Clone Tools

Stats

Commits this week: 31
Total Committers: 18
Last Commit: 05 May
Commits this week: 31

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 11 Mar
9:38 am

Vendor - TEL - Jashwant Gantyada

Merge branch 'LDT-3103-implement-closed-loop-control-f' into develop

Options
    • -2
    • +2
    /TDDefs.h
9:19 am

Vendor - TEL - Arpita Srivastava

Merge branch 'LDT-1195-dd-is-balancing-chamber-switching' into develop

Options
9:10 am

Michael Garthwaite

Merge branch 'staging' into LDT-2004-v2-conductivity-sensors

Options
    • -2
    • +5
    /MsgDefs.h
Tuesday 10 Mar
3:21 pm

Sean Nash

If we don't think we need this, let's just delete it. If we think it's coming back, let's keep it and just set the max count to something really high (e.g. 1,000,000).

If we don't think we need this, let's just delete it. If we think it's coming back, let's keep it and just set the max count to something really high (e.g. 1,000,000).

3:00 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    /TDDefs.h
2:55 pm

Vendor - TEL - Varshini Nagabooshanam

Merge LDT-3126-blood-prime-td

Options
    • -0
    • +1
    /MsgDefs.h
2:26 pm

Vendor - TEL - Varshini Nagabooshanam

2:25 pm

Vendor - TEL - Varshini Nagabooshanam

2:18 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    /MsgDefs.h
2:04 pm

Vendor - TEL - Varshini Nagabooshanam

LDT-3126-blood-prime-td

Options
    • -23
    • +39
    /MsgDefs.h
    • -2
    • +2
    /TDDefs.h
1:53 pm

Vendor - TEL - Varshini Nagabooshanam

1:52 pm

Vendor - TEL - Jashwant Gantyada and Sean Nash

1:38 pm

Vendor - TEL - Varshini Nagabooshanam

LDT-1415-pressures-monitoring-td-updates

Options
    • -2
    • +2
    /MsgDefs.h
11:01 am

Vendor - TEL - Varshini Nagabooshanam

LDT-1415-pressures-monitoring-td-updates

Options
    • -2
    • +2
    /MsgDefs.h
9:43 am

Dara Navaei

Resolved merge conflicts from staging

Options
Friday 06 Mar
2:48 pm

Sean Nash

See my comment above. We should return BOOL so Dialin request can be ACK/NAK'd.

See my comment above. We should return BOOL so Dialin request can be ACK/NAK'd.

2:46 pm

Sean Nash

No faults from Dialin commands - we never want Dialin to cause system to go to fault because it requested something invalid - we only NAK the invalid request. We should do whatever is needed (if an...

No faults from Dialin commands - we never want Dialin to cause system to go to fault because it requested something invalid - we only NAK the invalid request.
We should do whatever is needed (if anything) to start the mode normally in an else.
And we should return TRUE/FALSE in these signal functions so that when it's called from Dialin msg handler, the msg handler can return ACK/NAK to Dialin if sub mode is invalid.

2:42 pm

Sean Nash

We shouldn't request op mode until we're sure we're happy with the whole thing. Need to determine whether we are already in the op mode being requested. If so, no need to request it again - just re...

We shouldn't request op mode until we're sure we're happy with the whole thing.
Need to determine whether we are already in the op mode being requested. If so, no need to request it again - just request new sub mode if not already in it. If not, the currentSubMode checked below is not relevant (applies to current mode, not the requested mode) and we need to request new op mode and signal that new op mode that we will want to start in a specific sub mode.

2:38 pm

Sean Nash

Declarations should be at top of scope (right before memcpy).

Declarations should be at top of scope (right before memcpy).

2:37 pm

Sean Nash

Do we need this function? Can we do these 2 assignments in the Dialin msg handler function?

Do we need this function? Can we do these 2 assignments in the Dialin msg handler function?

2:34 pm

Sean Nash

I don't think this code should be here. Should be moved to a function and called - probably not from here though. Can we call function with this code from the Dialin msg handler?

I don't think this code should be here. Should be moved to a function and called - probably not from here though. Can we call function with this code from the Dialin msg handler?

2:02 pm

Vendor - TEL - Varshini Nagabooshanam

Removed

Removed

1:56 pm

Sean Nash

I don't think we need to call setPressureLimitsToOuterBounds() either. The signal function will indirectly cause that function to be called later.

I don't think we need to call setPressureLimitsToOuterBounds() either. The signal function will indirectly cause that function to be called later.

12:47 pm

Raghu Kallala

Shall I add the SW_Fault as an else case if an invalid submode was requested for an opmode? Sean NashMichael Garthwaite please confirm

Shall I add the SW_Fault as an else case if an invalid submode was requested for an opmode?
Sean NashMichael Garthwaite please confirm

12:37 pm

Raghu Kallala

I was thinking we could return BOOL to check if the request was successful, added it. But as you clarified the dialin response will only confirm the delivery of message successfully, I can change ...

I was thinking we could return BOOL to check if the request was successful, added it.

But as you clarified the dialin response will only confirm the delivery of message successfully, I can change all these signal functions to void
Thanks!

11:41 am

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

9:58 am

Michael Garthwaite

Yes since you're not using the return value in execOpModes()

Yes since you're not using the return value in execOpModes()

9:55 am

Sean Nash

I think we should just call signalInitiatePressureStabilization( USE_NORMAL_STABILIZATION_PERIOD );

I think we should just call signalInitiatePressureStabilization( USE_NORMAL_STABILIZATION_PERIOD );

9:50 am

Sean Nash

9:49 am

Sean Nash