leahi-common

Clone Tools

Stats

Commits this week: 28
Total Committers: 16
Last Commit: 17:17
Commits this week: 28

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
7 hrs ago

Michael Garthwaite

Merge branch 'staging' into LDT-2004-v2-conductivity-sensors

Options
    • -3
    • +3
    /MsgDefs.h
7 hrs ago

Michael Garthwaite

Friday 13 Mar
2:57 pm

Sean Nash

Not sure that publish function is the best place to do this, but it's where you're calculating timeout and countdown times which are local - but we need to alarm (warning) when countdown reaches 1 ...

Not sure that publish function is the best place to do this, but it's where you're calculating timeout and countdown times which are local - but we need to alarm (warning) when countdown reaches 1 minute (60 secs) and we need to alarm more severely when countdown reaches 0 secs.

If you make the 2 times static (not local here), you can call a monitor function from exec and do the calculations for the times and trigger alarms in the monitor function. Then, here in publish function, you would just publish the static times (no need to calculate because it's already done all the time).

2:51 pm

Sean Nash

elapsedSec will count up. The countdown should be time remaining ( timeout - elapsedSec ) when in pause state, zero when in ramp or run state.

elapsedSec will count up. The countdown should be time remaining ( timeout - elapsedSec ) when in pause state, zero when in ramp or run state.

2:43 pm

Sean Nash

Use MS_PER_SECOND (in Common.h I think) instead of 1000. Also, make sure elapsedSec does not exceed timeout (300) so countdown doesn't go negative.

Use MS_PER_SECOND (in Common.h I think) instead of 1000.
Also, make sure elapsedSec does not exceed timeout (300) so countdown doesn't go negative.

2:39 pm

Sean Nash

The timeout should be 5 minutes (300 secs) when in pause state, 0 when in ramp or run state. Use a #define for the 300 (5 * SEC_PER_MIN).

The timeout should be 5 minutes (300 secs) when in pause state, 0 when in ramp or run state. Use a #define for the 300 (5 * SEC_PER_MIN).

2:35 pm

Sean Nash

Assign bloodPrimeStartMS here to mark start of pause.

Assign bloodPrimeStartMS here to mark start of pause.

2:35 pm

Sean Nash

Assign bloodPrimeStartMS here to mark start of pause.

Assign bloodPrimeStartMS here to mark start of pause.

2:34 pm

Sean Nash

I think we can initialize to zero here. We haven't paused yet.

I think we can initialize to zero here. We haven't paused yet.

2:33 pm

Sean Nash

Align with others (after U32).

Align with others (after U32).

2:11 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    /AlarmDefs.h
2:06 pm

Vendor - TEL - Jashwant Gantyada and Sean Nash

1:43 pm

Vinayakam Mani

LEAHI-DD-FIRMWARE-LDT-3103_implement closed loop control for d48 pump speed
LEAHI-DD-FIRMWARE-LDT-3103_implement closed loop control for d48 pump speed
1:34 pm

Vendor - TEL - Jashwant Gantyada

Merge branch 'staging' into LDT-3103-implement-closed-loop-control-f

Options
    • -8
    • +8
    /AlarmDefs.h
1:31 pm

Vinayakam Mani

12:18 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    /MsgDefs.h
12:14 pm

Vendor - TEL - Jashwant Gantyada

Merge branch 'staging' into LDT-1394-blood-flow-rate-h4-rotor-count

Options
12:12 pm

Vendor - TEL - Jashwant Gantyada

LDT-3103 addressed code review comments

Options
    • -1
    • +1
    /AlarmDefs.h
12:04 pm

Vendor - TEL - Jashwant Gantyada

12:03 pm

Sean Nash and Raghu Kallala

11:59 am

Vendor - TEL - Jashwant Gantyada

done updated below in the function as well.

done updated below in the function as well.

11:59 am

Vendor - TEL - Jashwant Gantyada

done.

done.

11:54 am

Raghu Kallala

Intentional?

Intentional?

11:50 am

Vendor - TEL - Jashwant Gantyada

done changed it.

done changed it.

11:50 am

Vendor - TEL - Jashwant Gantyada

LDT-3103 addressed code review comments

Options
    • -1
    • +1
    /AlarmDefs.h
11:45 am

Raghu Kallala

update the header and field comments in later commits

update the header and field comments in later commits

11:43 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    /AlarmDefs.h
11:39 am

Vendor - TEL - Varshini Nagabooshanam

Merge branch 'staging' into LDT-3539-air-infusion-td

Options
    • -10
    • +14
    /AlarmDefs.h
11:37 am

Vinayakam Mani

Looks the fields are empty and misaligned. fill as needed.

Looks the fields are empty and misaligned. fill as needed.

11:30 am

Vendor - TEL - Varshini Nagabooshanam