leahi-common

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Merge branch 'LDT-2004-v2-conductivity-sensors' into develop

LDT-2004: msg id naming

I'm not seeing where alarms get triggered?

I'm not seeing where alarms get triggered?

Updated

Updated

Added

Added

Added

Added

Added

Added

Added

Added

Added

Added

Updated

Updated

Aligned

Aligned

Merge branch 'staging' into LDT-2004-v2-conductivity-sensors

Not sure that publish function is the best place to do this, but it's where you're calculating timeout and countdown times which are local - but we need to alarm (warning) when countdown reaches 1 ...

Not sure that publish function is the best place to do this, but it's where you're calculating timeout and countdown times which are local - but we need to alarm (warning) when countdown reaches 1 minute (60 secs) and we need to alarm more severely when countdown reaches 0 secs.

If you make the 2 times static (not local here), you can call a monitor function from exec and do the calculations for the times and trigger alarms in the monitor function. Then, here in publish function, you would just publish the static times (no need to calculate because it's already done all the time).

elapsedSec will count up. The countdown should be time remaining ( timeout - elapsedSec ) when in pause state, zero when in ramp or run state.

elapsedSec will count up. The countdown should be time remaining ( timeout - elapsedSec ) when in pause state, zero when in ramp or run state.

Use MS_PER_SECOND (in Common.h I think) instead of 1000. Also, make sure elapsedSec does not exceed timeout (300) so countdown doesn't go negative.

Use MS_PER_SECOND (in Common.h I think) instead of 1000.
Also, make sure elapsedSec does not exceed timeout (300) so countdown doesn't go negative.

The timeout should be 5 minutes (300 secs) when in pause state, 0 when in ramp or run state. Use a #define for the 300 (5 * SEC_PER_MIN).

The timeout should be 5 minutes (300 secs) when in pause state, 0 when in ramp or run state. Use a #define for the 300 (5 * SEC_PER_MIN).

Assign bloodPrimeStartMS here to mark start of pause.

Assign bloodPrimeStartMS here to mark start of pause.

Assign bloodPrimeStartMS here to mark start of pause.

Assign bloodPrimeStartMS here to mark start of pause.

I think we can initialize to zero here. We haven't paused yet.

I think we can initialize to zero here. We haven't paused yet.

Align with others (after U32).

Align with others (after U32).

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

LEAHI-DD-FIRMWARE-LDT-3103_implement closed loop control for d48 pump speed
LEAHI-DD-FIRMWARE-LDT-3103_implement closed loop control for d48 pump speed
Merge branch 'staging' into LDT-3103-implement-closed-loop-control-f

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Merge branch 'staging' into LDT-1394-blood-flow-rate-h4-rotor-count

LDT-3103 addressed code review comments