leahi-common

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Merge branch 'staging' into LDT-3259-software-update---td-firmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

LDT-3505: Added msg ids for syringe pump module

check alarm status instead of switch state.

check alarm status instead of switch state.

Name something similar to 'BCSwitchingBasedOnClosePeriodCounter'?

Name something similar to 'BCSwitchingBasedOnClosePeriodCounter'?

I guess, all these checks should be moved to FillEndState.

I guess, all these checks should be moved to FillEndState.

after one state of BC switching completed. update the next comment as well.

after one state of BC switching completed. update the next comment as well.

LDT-3970: Added new rejection reason for confirmation flow handling

LDY-3963 merged latest staging

Uncommented

Uncommented

LDT-2240-disposable-tube-set-self-test

Should we add a TODO to remove this one as well?

Should we add a TODO to remove this one as well?

If we are removing this call, then where are we calling the function testDDFloaterLevelStateOverride?

If we are removing this call, then where are we calling the function testDDFloaterLevelStateOverride?

Please update the function name : testDDFloaterLevelStateOverride

Please update the function name : testDDFloaterLevelStateOverride

Merge branch LDT-3978-switch-chamber-f-conductive-lev into staging

Remove extra blank line.

Remove extra blank line.

Why is this service prefixed with "Tx"? Also, Praneeth and I agreed to put these state machine services into a sub-folder of Services. See how he did it and do the same.

Why is this service prefixed with "Tx"?
Also, Praneeth and I agreed to put these state machine services into a sub-folder of Services. See how he did it and do the same.

DrySelfTests unit.

DrySelfTests unit.

DrySelfTests unit initialized.

DrySelfTests unit initialized.

Remove extra blank line.

Remove extra blank line.

.. handles dry self-tests execution for pre-treatment and treatment modes.

.. handles dry self-tests execution for pre-treatment and treatment modes.

Should be in "", not <>. And should be placed alphabetically down before TxParams.h.

Should be in "", not <>. And should be placed alphabetically down before TxParams.h.

Calling signal function here seems circular (that's how we got here in the first place). Shouldn't we set state to the install state here instead?

Calling signal function here seems circular (that's how we got here in the first place).
Shouldn't we set state to the install state here instead?

Put before TxParams.

Put before TxParams.

I think Praneeth created a function for this. Make sure they're identical.

I think Praneeth created a function for this. Make sure they're identical.

Is the folder name necessary?

Is the folder name necessary?