leahi-common

Clone Tools

Stats

Commits this week: 20
Total Committers: 19
Last Commit: 10 Jun
Commits this week: 20

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 12 May
2:03 pm

Vendor - TEL - Varshini Nagabooshanam

LDT-2240-disposable-tube-set-self-test

Options
    • -12
    • +12
    /AlarmDefs.h
    • -3
    • +2
    /MsgDefs.h
    • -4
    • +3
    /TDDefs.h
2:00 pm

Vendor - TEL - Arpita Srivastava

Please keep on declaration of the variables in this section and move the initialization to initTreatmentParameters

Please keep on declaration of the variables in this section and move the initialization to initTreatmentParameters

1:59 pm

Vendor - TEL - Arpita Srivastava

Please rename this function to initTreatmentParameters

Please rename this function to initTreatmentParameters

1:58 pm

Vendor - TEL - Arpita Srivastava

We only add File level or global variables in Inputs and Outputs. Please remove functions from the input section of this and other functions.

We only add File level or global variables in Inputs and Outputs.
Please remove functions from the input section of this and other functions.

1:56 pm

Vendor - TEL - Arpita Srivastava

Even if you do not have an Output, please add the tag with None as the value. Please fix in other functions as well.

Even if you do not have an Output, please add the tag with None as the value.
Please fix in other functions as well.

1:54 pm

Vendor - TEL - Arpita Srivastava

Please indent the doxygen comments of all the functions, similar to existing functions.

Please indent the doxygen comments of all the functions, similar to existing functions.

9:40 am

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

Monday 11 May
5:25 pm

Vendor - TEL - Arpita Srivastava

Delete extra line

Delete extra line

3:09 pm

Vendor - TEL - Varshini Nagabooshanam

11:55 am

Vinayakam Mani

Why did we remove this? This is needed for BC Switch only condition.

Why did we remove this? This is needed for BC Switch only condition.

Friday 08 May
1:21 pm

Sean Nash

Again, I don't like these oriented this way. Please change to #ifndef DISABLE_ALARM_4

Again, I don't like these oriented this way. Please change to #ifndef DISABLE_ALARM_4

1:19 pm

Sean Nash

If BC switching period is Zero, I would expect the Qd from TD to also be zero, right? But what if it's not? What if Qd from TD is 600 and switching period is zero? You are going to run the pump pre...

If BC switching period is Zero, I would expect the Qd from TD to also be zero, right? But what if it's not? What if Qd from TD is 600 and switching period is zero? You are going to run the pump pretty fast with no BC switching in that case.

1:10 pm

Sean Nash

We shouldn't require something to be defined to do the right thing. We should require something to be defined to do the wrong thing (i.e. this should say #ifndef _BAD_MSG_CRC_ALARM_DISABLED_) And t...

We shouldn't require something to be defined to do the right thing. We should require something to be defined to do the wrong thing (i.e. this should say #ifndef _BAD_MSG_CRC_ALARM_DISABLED_)
And then, we don't need a TODO. These #defines are only possible in DEBUG builds. A RELEASE build will never allow thing build flags to disable things.

12:54 pm

Vendor - TEL - Vijay Pamula

LDT-3970: Merged latest staging changes

Options
    • -7
    • +12
    /MsgDefs.h
11:17 am

Vendor - TEL - Varshini Nagabooshanam

9:21 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    /AlarmDefs.h
    • -2
    • +2
    /MsgDefs.h
    • -2
    • +2
    /TDDefs.h
Thursday 07 May
1:31 pm

Vendor - TEL - Varshini Nagabooshanam

Merge branch 'LDT-3910-request-add-td-config-flag-so' into staging

Options
    • -3
    • +3
    /AlarmDefs.h
11:34 am

Vendor - TEL - Arpita Srivastava

LDT-3505: Removed msg id for syringe detection override fucnction

Options
    • -10
    • +9
    /MsgDefs.h
11:12 am

Sean Nash

Remove start state.

Remove start state.

10:30 am

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

10:29 am

Vendor - TEL - Varshini Nagabooshanam

updated

updated

10:29 am

Vendor - TEL - Varshini Nagabooshanam

Yes, removed

Yes, removed

10:29 am

Vendor - TEL - Varshini Nagabooshanam

Removed

Removed

10:28 am

Vendor - TEL - Varshini Nagabooshanam

yes, removed

yes, removed

10:28 am

Vendor - TEL - Varshini Nagabooshanam

Changed

Changed

10:28 am

Vendor - TEL - Varshini Nagabooshanam

Removed

Removed

10:28 am

Vendor - TEL - Varshini Nagabooshanam

Removed

Removed

10:27 am

Vendor - TEL - Varshini Nagabooshanam

Removed

Removed

10:27 am

Vendor - TEL - Varshini Nagabooshanam

Added

Added

10:27 am

Vendor - TEL - Varshini Nagabooshanam

Added

Added