leahi-common

Clone Tools

Stats

Commits this week: 8
Total Committers: 18
Last Commit: 14 May
Commits this week: 8

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 14 May
2:31 pm

Vendor - TEL - Jashwant Gantyada

merged lDT-3963 with develop

Options
    • -2
    • +2
    /MsgDefs.h
2:21 pm

Vendor - TEL - Jashwant Gantyada

added TODO above

added TODO above

2:21 pm

Vendor - TEL - Jashwant Gantyada

updated as suggested.

updated as suggested.

2:21 pm

Vendor - TEL - Jashwant Gantyada

updated.

updated.

2:20 pm

Vendor - TEL - Jashwant Gantyada

updated accordingly.

updated accordingly.

2:20 pm

Vendor - TEL - Jashwant Gantyada

added TODO for all

added TODO for all

2:20 pm

Vendor - TEL - Jashwant Gantyada

makes sense. removed it.

makes sense. removed it.

1:25 pm

Vendor - TEL - Jashwant Gantyada

I think we are using it to send a message to Dialin, to let the tester know whether the command has passed/failed or timed out.

I think we are using it to send a message to Dialin, to let the tester know whether the command has passed/failed or timed out.

1:07 pm

Vendor - TEL - Jashwant Gantyada

restored

restored

9:48 am

Vendor - TEL - Arpita Srivastava

Looks like the description part should only be in the @param part. sysConfigTreatmentParameters should be an output? Input is None. Add @details for alarms

Looks like the description part should only be in the @param part.
sysConfigTreatmentParameters should be an output? Input is None.
Add @details for alarms

9:29 am

Vendor - TEL - Arpita Srivastava

align comment

align comment

9:26 am

Vendor - TEL - Arpita Srivastava

The Id name looks too long? What if we change Temperature to Temp?

The Id name looks too long? What if we change Temperature to Temp?

Wednesday 13 May
12:46 pm

Vendor - TEL - Vijay Pamula

LDT-3970: Updated Edit Treatment Parameter handling

Options
    • -0
    • +18
    /TDDefs.h
10:48 am

Vendor - TEL - Varshini Nagabooshanam

Removedd

Removedd

10:44 am

Vendor - TEL - Varshini Nagabooshanam

added

added

Tuesday 12 May
8:41 pm

Sean Nash and Vendor - TEL - Arpita Srivastava

8:39 pm

Vendor - TEL - Praneeth Bunne

LDT-1886: Update blood set failure alarm

Options
    • -4
    • +4
    /AlarmDefs.h
3:47 pm

Vendor - TEL - Arpita Srivastava

Add @param section for reasons.

Add @param section for reasons.

3:44 pm

Vendor - TEL - Arpita Srivastava

Please list names of variables in inputs and outputs. You can move any description in the brief section.

Please list names of variables in inputs and outputs.
You can move any description in the brief section.

3:38 pm

Vendor - TEL - Arpita Srivastava

LDT-3505: Pulled latest staging into LDT-3505

Options
    • -5
    • +18
    /MsgDefs.h
    • -22
    • +25
    /TDDefs.h
2:24 pm

Vendor - TEL - Arpita Srivastava

Please add a comment for this check and break the line in two lines.

Please add a comment for this check and break the line in two lines.

2:24 pm

Vendor - TEL - Arpita Srivastava

Please add a comment about this condition check. Move this part : ( fabs( request.ufRate - validatedUFRateLhr ) < NEARLY_ZERO ) ) to the next line.

Please add a comment about this condition check.

Move this part : ( fabs( request.ufRate - validatedUFRateLhr ) < NEARLY_ZERO ) ) to the next line.

2:18 pm

Vendor - TEL - Arpita Srivastava

Can we please align (move more towards right) the comments of this newly added section with the comments of existing sections?

Can we please align (move more towards right) the comments of this newly added section with the comments of existing sections?

2:03 pm

Vendor - TEL - Varshini Nagabooshanam

LDT-2240-disposable-tube-set-self-test

Options
    • -12
    • +12
    /AlarmDefs.h
    • -3
    • +2
    /MsgDefs.h
    • -4
    • +3
    /TDDefs.h
2:00 pm

Vendor - TEL - Arpita Srivastava

Please keep on declaration of the variables in this section and move the initialization to initTreatmentParameters

Please keep on declaration of the variables in this section and move the initialization to initTreatmentParameters

1:59 pm

Vendor - TEL - Arpita Srivastava

Please rename this function to initTreatmentParameters

Please rename this function to initTreatmentParameters

1:58 pm

Vendor - TEL - Arpita Srivastava

We only add File level or global variables in Inputs and Outputs. Please remove functions from the input section of this and other functions.

We only add File level or global variables in Inputs and Outputs.
Please remove functions from the input section of this and other functions.

1:56 pm

Vendor - TEL - Arpita Srivastava

Even if you do not have an Output, please add the tag with None as the value. Please fix in other functions as well.

Even if you do not have an Output, please add the tag with None as the value.
Please fix in other functions as well.

1:54 pm

Vendor - TEL - Arpita Srivastava

Please indent the doxygen comments of all the functions, similar to existing functions.

Please indent the doxygen comments of all the functions, similar to existing functions.

9:40 am

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated