Activity leahi-common/

Tree
Accordion

Stats

Commits this week: 33

Total Committers:	19
Last Commit:	14:13
Commits this week:	33

Lines of code count not available

Commit Activity

last updated a few minutes ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Today

2 hrs ago

Vendor - TEL - Varshini Nagabooshanam

More
9570191
changed 1 file
LDT-4033-patient-vitals-fw-implementation

Merge branch 'staging' of bitbucket.org:diality-cloud/leahi-common into LDT-4033-patient-vitals-fw-implementation

- -10
- +10
/AlarmDefs.h
- History
- Source
- Diff
/AlarmDefs.h

2 hrs ago

Vendor - TEL - Praneeth Bunne

More
19ac95d
changed 1 file
LDT-1886-blood-set-auto-load-and-auto-ej, develop, staging LEAHI-TD-FIRMWARE-LDT-1886-2

Merge branch 'staging' into LDT-1886-blood-set-auto-load-and-auto-ej

- -10
- +10
/AlarmDefs.h
- History
- Source
- Diff
/AlarmDefs.h

2 hrs ago

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-4033-1
commented on review

Add alarm here.

Add alarm here.

2 hrs ago

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-4033-1
commented on review

Make h10DACControl a U08.

Make h10DACControl a U08.

2 hrs ago

Dara Navaei

More
f5acd07
changed 2 files
LDT-1886-blood-set-auto-load-and-auto-ej, LDT-4033-patient-vitals-fw-implementation and 2 more LEAHI-TD-FIRMWARE-LDT-1886-2 LEAHI-TD-FIRMWARE-LDT-4033-1

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
/AlarmDefs.h
- History
- Source
- Diff
/AlarmDefs.h
- -2
- +2
/DDDefs.h
- History
- Source
- Diff
/DDDefs.h

2 hrs ago

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-4033-1
commented on review

Remove extra blank line.

Remove extra blank line.

3 hrs ago

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-4033-1
commented on review

This looks like leftover from merge conflict. Remove this line.

This looks like leftover from merge conflict. Remove this line.

3 hrs ago

Vendor - TEL - Jashwant Gantyada

3 hrs ago

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-4033-1
replied to Vendor - TEL - Varshini Nagabooshanam

What do we do if BP module reports an error? Do we just go to idle state and there is no alarm?

What do we do if BP module reports an error? Do we just go to idle state and there is no alarm?

3 hrs ago

Vendor - TEL - Jashwant Gantyada

More
313004f
changed 3 files
develop

resolved merge conflicts and merged LDT-3963

- -8
- +8
/AlarmDefs.h
- History
- Source
- Diff
/AlarmDefs.h
- -3
- +17
/MsgDefs.h
- History
- Source
- Diff
/MsgDefs.h
- -2
- +3
/TDDefs.h
- History
- Source
- Diff
/TDDefs.h

3 hrs ago

Vendor - TEL - Varshini Nagabooshanam

More
a0063aa
changed 0 files
LDT-3215-measured-venous-pressure-decreases

Merge branch 'staging' of bitbucket.org:diality-cloud/leahi-common into LDT-3215-measured-venous-pressure-decreases

3 hrs ago

Sean Nash and Vinayakam Mani

More
LEAHI-DD-FIRMWARE-LDT-3963-1
finished reviewing

4 hrs ago

Vendor - TEL - Varshini Nagabooshanam

Thats for error register so not required now

Thats for error register so not required now

5 hrs ago

Vendor - TEL - Varshini Nagabooshanam

You’re right. I should also check the busy status before transitioning to the GET_DATA state. I’ll update the measurement completion logic to first verify the busy bit is cleared, then validate the...

You’re right. I should also check the busy status before transitioning to the GET_DATA state. I’ll update the measurement completion logic to first verify the busy bit is cleared, then validate the BP data response code before moving to BP_DRIVER_GET_DATA_STATE.

5 hrs ago

Vendor - TEL - Jashwant Gantyada

More
5eee871
changed 0 files
LDT-1886-blood-set-auto-load-and-auto-ej, LDT-4033-patient-vitals-fw-implementation and 3 more

Merge branch 'staging' into feature/LDT-3963-dialysate-flow-rate---fw-implem

Thursday 21 May

11:16 pm

Vendor - TEL - Vijay Pamula

More
0add9fc
changed 2 files
LDT-3970-edit-treatment-parameters-during-treatment LEAHI-TD-FIRMWARE-LDT-3970-1

LDT:3970 Merge Latest From Staging

- -4
- +31
/MsgDefs.h
- History
- Source
- Diff
/MsgDefs.h
- -22
- +26
/TDDefs.h
- History
- Source
- Diff
/TDDefs.h

10:58 pm

Vendor - TEL - Vijay Pamula

More
38fca67
changed 2 files
LDT-3970-edit-treatment-parameters-during-treatment LEAHI-TD-FIRMWARE-LDT-3970-1

LDT:3970 Updated Edit Treatment Parameters

- -6
- +6
/MsgDefs.h
- History
- Source
- Diff
/MsgDefs.h
- -1
- +1
/TDDefs.h
- History
- Source
- Diff
/TDDefs.h

10:46 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-4033-1
commented on review

Why do you have {} in the cases?

Why do you have {} in the cases?

10:45 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-4033-1
commented on review

You are getting bpResults, but not doing anything with them. Should you pass as parameter to checkBloodPressureReading() function?

You are getting bpResults, but not doing anything with them. Should you pass as parameter to checkBloodPressureReading() function?

10:43 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-4033-1
commented on review

Where are these get functions defined? I can't find them.

Where are these get functions defined? I can't find them.

8:45 pm

Dara Navaei

More
beacec5
changed 3 files
LDT-3259-software-update---td-firmware LEAHI-TD-FIRMWARE-LDT-3259-1

LDT-3259 merged staging

- -13
- +66
/AlarmDefs.h
- History
- Source
- Diff
/AlarmDefs.h
- -4
- +31
/MsgDefs.h
- History
- Source
- Diff
/MsgDefs.h
- -22
- +26
/TDDefs.h
- History
- Source
- Diff
/TDDefs.h

8:41 pm

Vendor - TEL - Praneeth Bunne

More
786f4f3
changed 2 files
LDT-1886-blood-set-auto-load-and-auto-ej, develop, staging LEAHI-TD-FIRMWARE-LDT-1886-2

LDT-1886: Resolved merge conflicts

- -2
- +28
/MsgDefs.h
- History
- Source
- Diff
/MsgDefs.h
- -2
- +3
/TDDefs.h
- History
- Source
- Diff
/TDDefs.h

5:11 pm

Vendor - TEL - Varshini Nagabooshanam

More
d3e6042
changed 0 files
LDT-4033-patient-vitals-fw-implementation

Merge branch 'staging' of bitbucket.org:diality-cloud/leahi-common into LDT-4033-patient-vitals-fw-implementation

5:10 pm

Vendor - TEL - Varshini Nagabooshanam

More
68c7548
changed 1 file
LDT-3215-measured-venous-pressure-decreases LEAHI-TD-FIRMWARE-LDT-3215-1

LDT-3215-measured-venous-pressure-decreases

- -55
- +3
/AlarmDefs.h
- History
- Source
- Diff
/AlarmDefs.h

4:27 pm

Vendor - TEL - Arpita Srivastava

3:36 pm

Vendor - TEL - Jashwant Gantyada

More
fd44f2e
changed 1 file
LDT-1886-blood-set-auto-load-and-auto-ej, LDT-4033-patient-vitals-fw-implementation and 3 more LEAHI-DD-FIRMWARE-LDT-3963-1

LDT-3963 addressed code review comments

- -6
- +6
/AlarmDefs.h
- History
- Source
- Diff
/AlarmDefs.h

3:24 pm

Vendor - TEL - Jashwant Gantyada

restored

restored

3:24 pm

Sean Nash

Not sure why Crucible is showing it this way. Let's just re-review these diffs.

Not sure why Crucible is showing it this way. Let's just re-review these diffs.

3:22 pm

Dara Navaei

More
bd82717
changed 2 files
LDT-1886-blood-set-auto-load-and-auto-ej, LDT-3215-measured-venous-pressure-decreases and 7 more LEAHI-TD-FIRMWARE-LDT-3259-1 LEAHI-TD-FIRMWARE-LDT-1886-2 LEAHI-TD-FIRMWARE-LDT-3970-1

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
/MsgDefs.h
- History
- Source
- Diff
/MsgDefs.h
- -2
- +2
/TDDefs.h
- History
- Source
- Diff
/TDDefs.h

3:18 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3963-1
replied to Vendor - TEL - Jashwant Gantyada

Should be #ifndef

Should be #ifndef

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-05-22 14:16 -0700