leahi-common

Clone Tools

Stats

Commits this week: 20
Total Committers: 19
Last Commit: 10 Jun
Commits this week: 20

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 10 Jun
1:19 pm

Michael Garthwaite

LDT-4001: code review comments

Options
    • -1
    • +1
    /MsgDefs.h
1:18 pm

Vendor - TEL - Jashwant Gantyada

9:22 am

Vendor - TEL - Sameer Poyil

Please check with TD, I have seen one of the develop branch this populated in pre gen and gen.

Please check with TD, I have seen one of the develop branch this populated in pre gen and gen.

Tuesday 09 Jun
4:44 pm

Sean Nash

Change PRES_OCCL to PRESSURE

Change PRES_OCCL to PRESSURE

4:43 pm

Sean Nash

Maybe move OperationModes.c?

Maybe move OperationModes.c?

4:42 pm

Sean Nash

Use generic confirmation functions/messages.

Use generic confirmation functions/messages.

4:41 pm

Sean Nash

Move this function to OperationModes.c.

Move this function to OperationModes.c.

4:40 pm

Sean Nash

From here forward, we can just call sendMessage() with appropriate params.

From here forward, we can just call sendMessage() with appropriate params.

4:37 pm

Sean Nash

Use generic helper function (sendMessage) in MessageSupport.c.

Use generic helper function (sendMessage) in MessageSupport.c.

4:33 pm

Sean Nash

Use generic confirmation functions/messages for off button.

Use generic confirmation functions/messages for off button.

4:26 pm

Sean Nash

Remove change.

Remove change.

2:38 pm

Sean Nash

You only addressed the first part of my comment above.

You only addressed the first part of my comment above.

2:36 pm

Sean Nash

This medium alarm is ID 196 (from enum above). So I would expect it to be at the bottom of this table. Why are you placing it here?

This medium alarm is ID 196 (from enum above). So I would expect it to be at the bottom of this table. Why are you placing it here?

2:26 pm

Sean Nash

Put TRUE on left side of ==

Put TRUE on left side of ==

2:21 pm

Sean Nash

"u" comes before "y".

"u" comes before "y".

2:18 pm

Sean Nash

BROADCAST_INTERVAL?

BROADCAST_INTERVAL?

1:51 pm

suresh

LDT-4063:add alarms and msg ids related to POST

Options
    • -0
    • +4
    /AlarmDefs.h
    • -1
    • +4
    /MsgDefs.h
1:48 pm

Michael Garthwaite

removed

removed

1:48 pm

Michael Garthwaite

pre-gen does not need substitution rate as its only treatment related.

pre-gen does not need substitution rate as its only treatment related.

1:47 pm

Michael Garthwaite

its used in handleDialysateDeliveryRequestMsg() to set the sub pump's speed. please review the changes thoroughly.

its used in handleDialysateDeliveryRequestMsg() to set the sub pump's speed. please review the changes thoroughly.

1:46 pm

Michael Garthwaite

removed

removed

1:15 pm

Vendor - TEL - Sameer Poyil

1:09 pm

Vendor - TEL - Sameer Poyil

is it a dummy parameter? where are you using it ?

is it a dummy parameter? where are you using it ?

1:08 pm

Vendor - TEL - Sameer Poyil

Why pre-gen missing substitutionrate ? not required ?

Why pre-gen missing substitutionrate ? not required ?

1:00 pm

Vendor - TEL - Sameer Poyil

please removed commented code

please removed commented code

12:59 pm

Vendor - TEL - Sameer Poyil

please remove commented code

please remove commented code

12:03 pm

Vinayakam Mani

remove blank line

remove blank line

12:03 pm

Vinayakam Mani

remove blank line

remove blank line

12:02 pm

Vinayakam Mani

Please see if you can define a function to handle this and call that function here, to reduce the number of code lines in this function.

Please see if you can define a function to handle this and call that function here, to reduce the number of code lines in this function.

12:01 pm

Michael Garthwaite

added

added