leahi-common

Clone Tools

Stats

Commits this week: 23
Total Committers: 20
Last Commit: 09:58
Commits this week: 23

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 10 Jun
1:19 pm

Michael Garthwaite

LDT-4001: code review comments

Options
    • -1
    • +1
    /MsgDefs.h
1:18 pm

Vendor - TEL - Jashwant Gantyada

9:49 am

Vendor - TEL - Jashwant Gantyada

Merge branch 'staging' into LDT-4011-isolated-uf-dd---fw-implementat

Options
9:22 am

Vendor - TEL - Sameer Poyil

Please check with TD, I have seen one of the develop branch this populated in pre gen and gen.

Please check with TD, I have seen one of the develop branch this populated in pre gen and gen.

Tuesday 09 Jun
10:29 pm

Vinayakam Mani

why TODO?

why TODO?

10:24 pm

Vinayakam Mani

Do we need to close D64 as well?

Do we need to close D64 as well?

10:23 pm

Vinayakam Mani

Delete the commented line

Delete the commented line

10:17 pm

Vinayakam Mani

handleBicarbChamberInitiateSupply?

handleBicarbChamberInitiateSupply?

10:15 pm

Vinayakam Mani

Update this.

Update this.

10:14 pm

Vinayakam Mani

Remove this comment.

Remove this comment.

10:13 pm

Vinayakam Mani

Update Inputs and Outputs throughout the file.

Update Inputs and Outputs throughout the file.

10:06 pm

Vinayakam Mani

Do we need this?

Do we need this?

10:05 pm

Vinayakam Mani

when are we closing D64 valve? handle the same in else block as well.

when are we closing D64 valve? handle the same in else block as well.

9:56 pm

Vinayakam Mani

Can this be assigned during declaration time?

Can this be assigned during declaration time?

9:43 pm

Vinayakam Mani

are we using these?

are we using these?

9:29 pm

Vinayakam Mani

Can we use one macro (instead of three) for the D66 persistence?

Can we use one macro (instead of three) for the D66 persistence?

9:24 pm

Vinayakam Mani

The difference between the actual pressure measured at bicart assembly and the measured D66 pressure based on the placement of the sensor.

The difference between the actual pressure measured at bicart assembly and the measured D66 pressure based on the placement of the sensor.

9:21 pm

Vinayakam Mani

Dry bicart data publish in the comment.

Dry bicart data publish in the comment.

4:44 pm

Sean Nash

Change PRES_OCCL to PRESSURE

Change PRES_OCCL to PRESSURE

4:43 pm

Sean Nash

Maybe move OperationModes.c?

Maybe move OperationModes.c?

4:42 pm

Sean Nash

Use generic confirmation functions/messages.

Use generic confirmation functions/messages.

4:41 pm

Sean Nash

Move this function to OperationModes.c.

Move this function to OperationModes.c.

4:40 pm

Sean Nash

From here forward, we can just call sendMessage() with appropriate params.

From here forward, we can just call sendMessage() with appropriate params.

4:33 pm

Sean Nash

Use generic confirmation functions/messages for off button.

Use generic confirmation functions/messages for off button.

4:26 pm

Sean Nash

Remove change.

Remove change.

2:38 pm

Sean Nash

You only addressed the first part of my comment above.

You only addressed the first part of my comment above.

2:36 pm

Sean Nash

This medium alarm is ID 196 (from enum above). So I would expect it to be at the bottom of this table. Why are you placing it here?

This medium alarm is ID 196 (from enum above). So I would expect it to be at the bottom of this table. Why are you placing it here?

2:35 pm

Vendor - TEL - Jashwant Gantyada

remove blank lines

remove blank lines

2:29 pm

Vendor - TEL - Jashwant Gantyada

Align comment

Align comment

2:26 pm

Sean Nash

Put TRUE on left side of ==

Put TRUE on left side of ==