leahi-common

MsgDefs.h

Clone Tools

Stats

Commits this week: 9
Total Committers: 16
Last Commit: 23 Apr
Commits this week: 9

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 13 Apr
10:35 am

Vendor - TEL - Varshini Nagabooshanam

LDT-2240-disposable-tube-set-self-test

Options
    • -0
    • +2
    /MsgDefs.h
  2. … 2 more files in changeset.
9:22 am

Dara Navaei

LDT-3259 added mode update enum and new messages to inform the stacks that update is available

Options
    • -2
    • +2
    /MsgDefs.h
  2. … 1 more file in changeset.
Saturday 11 Apr
1:38 pm

Dara Navaei

Friday 10 Apr
11:52 am

Vinayakam Mani

The FP signals are not included in the DD-pre gen/Gen dialysate transition functions. They have handled separately in the TD Interface.

The FP signals are not included in the DD-pre gen/Gen dialysate transition functions. They have handled separately in the TD Interface.

11:46 am

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-1886_Blood Set Auto-Load and Auto-Eject - TD
LEAHI-TD-FIRMWARE-LDT-1886_Blood Set Auto-Load and Auto-Eject - TD
10:25 am

Vendor - TEL - Sameer Poyil

its auto generated . should not change it manually. any way when merging its added correct value

its auto generated . should not change it manually. any way when merging its added correct value

10:24 am

Vendor - TEL - Sameer Poyil

Now we don't need this macro ?

Now we don't need this macro ?

10:17 am

Vendor - TEL - Sameer Poyil

now we are initializing sensor simultaneously?

now we are initializing sensor simultaneously?

10:16 am

Vendor - TEL - Sameer Poyil

comments missing

comments missing

10:15 am

Vendor - TEL - Sameer Poyil

comments missing

comments missing

10:15 am

Vendor - TEL - Sameer Poyil

This is not clear- please give a detailed description for this variable

This is not clear- please give a detailed description for this variable

10:14 am

Vendor - TEL - Sameer Poyil

use capital for starting letter

use capital for starting letter

10:13 am

Vendor - TEL - Sameer Poyil

please align the comments

please align the comments

10:13 am

Vendor - TEL - Sameer Poyil

please Alignment the comments

please Alignment the comments

10:10 am

Vendor - TEL - Sameer Poyil

Why the order is important here ? please document it

Why the order is important here ? please document it

10:06 am

Vendor - TEL - Sameer Poyil

10:06 am

Vendor - TEL - Sameer Poyil

do we need bracket here ? all text should start with capital

do we need bracket here ? all text should start with capital

10:00 am

Vendor - TEL - Sameer Poyil

Why a * here ?

Why a * here ?

9:43 am

Vendor - TEL - Sameer Poyil

is it write states or read state ?

is it write states or read state ?

9:43 am

Vendor - TEL - Sameer Poyil

is documentation correct ?

is documentation correct ?

8:21 am

Raghu Kallala

You are right, modified in all places

You are right, modified in all places

Thursday 09 Apr
2:35 pm

Dara Navaei

LDT-3259 merged staging and reserved new messages for TD and DD update signals

Options
    • -23
    • +62
    /MsgDefs.h
  2. … 2 more files in changeset.
Wednesday 08 Apr
1:51 pm

Sean Nash

FALSE?

FALSE?

1:50 pm

Sean Nash

FALSE?

FALSE?

1:46 pm

Sean Nash

Should default be TRUE? If we are being asked to validate an jump to an invalid state, shouldn't we return FALSE?

Should default be TRUE? If we are being asked to validate an jump to an invalid state, shouldn't we return FALSE?

1:44 pm

Sean Nash

Vinayakam Mani, how does that signal happen normally? In your example, when would DD signal FP when starting pre-gen mode? If that signal happened in pre-gen transition function, it would always ha...

Vinayakam Mani, how does that signal happen normally? In your example, when would DD signal FP when starting pre-gen mode? If that signal happened in pre-gen transition function, it would always happen regardless of how we got to pre-gen mode.

1:41 pm

Sean Nash

Add comment that these modes not (yet?) supported.

Add comment that these modes not (yet?) supported.

12:25 pm

Sean Nash

Why do some functions take sensor as a U32 and some as a CONDUCTIVITY_SENSORS_T? The latter seems appropriate.

Why do some functions take sensor as a U32 and some as a CONDUCTIVITY_SENSORS_T? The latter seems appropriate.

12:24 pm

Sean Nash

Remove blank line.

Remove blank line.

12:24 pm

Sean Nash

Remove blank line.

Remove blank line.