leahi-common

MsgDefs.h

Clone Tools

Stats

Commits this week: 8
Total Committers: 19
Last Commit: 09:38
Commits this week: 8

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 06 Jul
1:56 pm

Sean Nash

1:07 pm

Sean Nash

I would keep blank line between library includes and regular includes.

I would keep blank line between library includes and regular includes.

1:05 pm

Sean Nash

We can't have 2 alarms with ID 196. The enum only has the empty saline bag alarm. Looks like alarm 197 is duplicate of this 196 alarm you've added. I think you should just remove this new alarm 196...

We can't have 2 alarms with ID 196. The enum only has the empty saline bag alarm. Looks like alarm 197 is duplicate of this 196 alarm you've added.
I think you should just remove this new alarm 196 that you've added here.

10:56 am

Vendor - TEL - Praneeth Bunne

10:10 am

Vinayakam Mani

Thursday 02 Jul
3:32 pm

Sean Nash

test instead of handle

test instead of handle

3:06 pm

Vendor - TEL - Jashwant Gantyada and Sean Nash

2:42 pm

Sean Nash

Align =

Align =

2:41 pm

Sean Nash

Should modality be an enum type?

Should modality be an enum type?

2:41 pm

Sean Nash

Align =

Align =

2:40 pm

Sean Nash

Should this be an enum type?

Should this be an enum type?

10:32 am

Vendor - TEL - Arpita Srivastava

Wednesday 01 Jul
9:08 pm

Vendor - TEL - Sameer Poyil

3:07 pm

Sean Nash

Should the word "GENERIC" be in here somewhere?

Should the word "GENERIC" be in here somewhere?

3:06 pm

Sean Nash

Is ADJUST appropriate in context of this message? What are we adjusting?

Is ADJUST appropriate in context of this message? What are we adjusting?

1:36 pm

Sean Nash

What is the 3rd modality?

What is the 3rd modality?

1:26 pm

Sean Nash

Return type should be an enum (TREATMENT_TYPE_T).

Return type should be an enum (TREATMENT_TYPE_T).

1:24 pm

Sean Nash

Return type should be an enum (FLUID_BOLUS_MEDIUM_T).

Return type should be an enum (FLUID_BOLUS_MEDIUM_T).

1:17 pm

Sean Nash

Move after Modes so they are alphabetized.

Move after Modes so they are alphabetized.

10:45 am

Vendor - TEL - Arpita Srivastava

10:21 am

Sean Nash

Remove extra ;

Remove extra ;

10:18 am

Sean Nash

Can we align comments?

Can we align comments?

10:01 am

Sean Nash

Missing pinch valves (H1 and H19).

Missing pinch valves (H1 and H19).

9:59 am

Sean Nash

Remove this blank line.

Remove this blank line.

Tuesday 30 Jun
3:14 pm

Vendor - TEL - Arpita Srivastava

Please typecast alarmID to resolve warning. ALARM_T alarm = getAlarmProperties( ( ALARM_ID_T )alarmID );

Please typecast alarmID to resolve warning.

ALARM_T alarm = getAlarmProperties( ( ALARM_ID_T )alarmID );

1:23 pm

Sean Nash

Fix merge conflict stuff here.

Fix merge conflict stuff here.

1:23 pm

Sean Nash

Fix merge conflict stuff here.

Fix merge conflict stuff here.

Monday 29 Jun
12:13 pm

Vendor - TEL - Arpita Srivastava

Facing build errors. Please check if DD staging builds with your branch. Also, please add these to the sheet MSG_ID_DD_TREATMENT_PARAMS_OVERRIDE_REQUEST MSG_ID_DD_UF_DATA_PUBLISH_OVERRIDE_REQUEST

Facing build errors. Please check if DD staging builds with your branch.
Also, please add these to the sheet
MSG_ID_DD_TREATMENT_PARAMS_OVERRIDE_REQUEST
MSG_ID_DD_UF_DATA_PUBLISH_OVERRIDE_REQUEST

Saturday 27 Jun
9:11 am

Sean Nash

Where is testBatteryI2cStatusOverride (from BatteryDriver)?

Where is testBatteryI2cStatusOverride (from BatteryDriver)?

Friday 26 Jun
3:16 pm

Sean Nash

Add blank line before return statement.

Add blank line before return statement.