leahi-dialin / leahi_dialin / fp / modules

ro_pump.py

Clone Tools

Stats

Commits this week: 2
Total Committers: 3
Last Commit: 11 Mar
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 10 Mar
3:43 pm

Zoltan Miskolci

- Added FPPumpStates enum - Fixed valves_state_enum length - Fixed pressure sensor struct type

Options
    • -1
    • +1
    ./ro_pump.py
  2. … 8 more files in changeset.
11:48 am

Dara Navaei

LEAHI-DIALIN-LDT-3629_FP and DD valve_states_enum are one short of the full valve list
LEAHI-DIALIN-LDT-3629_FP and DD valve_states_enum are one short of the full valve list
Thursday 05 Mar
10:46 am

Zoltan Miskolci

10:37 am

Zoltan Miskolci

Merge branch 'LDT-3557-doc_header_for_vars' into develop

Options
    • -3
    • +4
    ./ro_pump.py
  2. … 13 more files in changeset.
10:25 am

Raghu Kallala

Tuesday 03 Mar
4:58 pm

Michael Garthwaite

3:28 pm

Zoltan Miskolci

removed

removed

9:13 am

Michael Garthwaite

Remove this extra line

Remove this extra line

Wednesday 25 Feb
6:57 pm

Zoltan Miskolci

- Moved enum def class to proxy file - Added comments to module files - Removed test config TEST_CONFIG_DD_DRY_BICART_TEST

Options
    • -3
    • +4
    ./ro_pump.py
  2. … 60 more files in changeset.
Friday 20 Feb
10:46 am

Dara Navaei

LEAHI-DIALIN-LDT-3557_[Documantation][Enhancement] Add documentation header to dialin variables
LEAHI-DIALIN-LDT-3557_[Documantation][Enhancement] Add documentation header to dialin variables
Thursday 12 Feb
4:29 pm

Zoltan Miskolci

3:04 pm

Zoltan Miskolci

Merge branch 'LDT-3344-beta2' into develop

Options
    • -2
    • +2
    ./ro_pump.py
3:03 pm

Raghu Kallala and Michael Garthwaite

2:16 pm

Zoltan Miskolci

Updated

Updated

2:12 pm

Michael Garthwaite

Does this string need to change as well?

Does this string need to change as well?

1:53 pm

Dara Navaei

1:53 pm

Dara Navaei

1:31 pm

Zoltan Miskolci

Renamed pump attribute

Options
    • -2
    • +2
    ./ro_pump.py
  2. … 2 more files in changeset.
1:18 pm

Dara Navaei

LEAHI-DIALIN-LDT-3344_Firmware support for Beta 2 FPGA updates.
LEAHI-DIALIN-LDT-3344_Firmware support for Beta 2 FPGA updates.
Thursday 22 Jan
10:07 am

Zoltan Miskolci

10:06 am

Zoltan Miskolci

Merge branch 'LDT-3214-override-refactor' into staging

Options
    • -118
    • +55
    ./ro_pump.py
  2. … 46 more files in changeset.
Wednesday 21 Jan
8:02 pm

Zoltan Miskolci

Merge branch 'LDT-3214-override-refactor' into develop

Options
    • -119
    • +55
    ./ro_pump.py
  2. … 46 more files in changeset.
12:35 pm

Sean Nash

11:08 am

Zoltan Miskolci

10:31 am

Raghu Kallala and Michael Garthwaite

9:47 am

Zoltan Miskolci

Tuesday 20 Jan
3:33 pm

Tiffany Mejia

10:14 am

Zoltan Miskolci

I added the unique decorator back, except for the few that have aliases

I added the unique decorator back, except for the few that have aliases

9:32 am

Zoltan Miskolci

Renamed, also flagged for future type change.

Renamed, also flagged for future type change.

Monday 19 Jan
11:52 am

Michael Garthwaite

"No one should interact with it or be aware of it's existence, so the name shouldn't matter." *it matters to those who read the code in inconsistent intervals ( like those who participate in code...

"No one should interact with it or be aware of it's existence, so the name shouldn't matter."

  • it matters to those who read the code in inconsistent intervals ( like those who participate in code review or teaching ).


"As we only have 2 version in test at the same time."

  • Currently. By summer, i'd expect dialin to be considering 1.0's, 1.9s, and 2.0s/DVTs.


We have the choice to handle the redesign effort then or now.


Edit:
Follow up comment.

Looking at the other files. Users of dialin will not be aware of existence, but developers of dialin will as it impacts the behavior of overrides like temp & pressure.