leahi-fwcommon

Clone Tools

Stats

Commits this week: 7
Total Committers: 12
Last Commit: 11:29
Commits this week: 7

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 12 Feb
3:46 pm

Raghu Kallala

LDT-3344 merge into develop

Options
    • -1
    • +0
    /TestSupport.h
3:43 pm

Vinayakam Mani

Please add 'execRinsePumpMonitor' which checks the commanded vs measured speed tolerance check and trigger alarm if deviates beyond the limit. You may move this function into monitor.

Please add 'execRinsePumpMonitor' which checks the commanded vs measured speed tolerance check and trigger alarm if deviates beyond the limit. You may move this function into monitor.

3:11 pm

Vinayakam Mani

Use #define macros for magic numbers.

Use #define macros for magic numbers.

2:29 pm

Sean Nash

Do we need to code this controller for multiple rinse pumps? I guess we've done it in some of the others, so I'm not against doing it this way. But if we do, we need to validate pumpID in a bunch o...

Do we need to code this controller for multiple rinse pumps? I guess we've done it in some of the others, so I'm not against doing it this way. But if we do, we need to validate pumpID in a bunch of functions and trigger a s/w fault if it's invalid.

2:22 pm

Sean Nash

Are we only publishing the measured pump speed? Even then, we should probably calculate it prior to the switch statement above in case we start using it in the states.

Are we only publishing the measured pump speed? Even then, we should probably calculate it prior to the switch statement above in case we start using it in the states.

2:18 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

2:17 pm

Sean Nash

Add a TODO to comment then.

Add a TODO to comment then.

1:57 pm

Raghu Kallala

This is a 4 byte reserved bits, not used at this time on Beta 1.9 or Beta 2.0

This is a 4 byte reserved bits, not used at this time on Beta 1.9 or Beta 2.0

1:57 pm

Raghu Kallala

This is a 4 byte reserved bits, not used at this time on Beta 1.9 or Beta 2.0

This is a 4 byte reserved bits, not used at this time on Beta 1.9 or Beta 2.0

1:51 pm

Raghu Kallala

LDT-3344 fault alarm if wrong configs are enabled simultaneously

Options
    • -1
    • +15
    /TestSupport.c
12:42 pm

Raghu Kallala

LDT-3344 removed D79 PWM test config

Options
    • -1
    • +0
    /TestSupport.h
10:32 am

Vendor - TEL - Jashwant Gantyada

done.

done.

10:32 am

Vendor - TEL - Jashwant Gantyada

done.

done.

10:32 am

Vendor - TEL - Jashwant Gantyada

done.

done.

9:58 am

Vinayakam Mani

LDT-3352 latest from staging

Options
9:03 am

Raghu Kallala

LDT-3344 merge fwcommon into develop

Options
8:58 am

Raghu Kallala

LDT-3344 Added ifdef for FpgaDD in test support

Options
    • -0
    • +2
    /TestSupport.c
4:02 am

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-3505_Heparin - TD - 04: DEV - Feature Implementation
LEAHI-TD-FIRMWARE-LDT-3505_Heparin - TD - 04: DEV - Feature Implementation
Wednesday 11 Feb
5:05 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    /TestSupport.h
4:56 pm

Vinayakam Mani

LDT-1473 merge into staging

Options
4:19 pm

Vendor - TEL - Sameer Poyil and Sean Nash

3:01 pm

Vinayakam Mani

Done.

Done.

2:49 pm

Vinayakam Mani

Updated.

Updated.

2:48 pm

Vendor - TEL - Sameer Poyil

copy paste error comment

copy paste error comment

2:39 pm

Sean Nash

Please convert bool expression to BOOL (TRUE or FALSE) before assigning (either in the expression with trinary or prior).

Please convert bool expression to BOOL (TRUE or FALSE) before assigning (either in the expression with trinary or prior).

2:24 pm

Sean Nash

In °C?

In °C?

2:23 pm

Sean Nash

Is return value in °C? U32 is pretty low resolution for a temperature.

Is return value in °C? U32 is pretty low resolution for a temperature.

2:08 pm

Vinayakam Mani

LDT-1473 latest from staging

Options
    • -2
    • +3
    /TestSupport.h
2:02 pm

Vinayakam Mani

Done

Done

2:02 pm

Vinayakam Mani

Done.

Done.