leahi-fwcommon

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Remove extra blank line.

Remove extra blank line.

Why is this service prefixed with "Tx"? Also, Praneeth and I agreed to put these state machine services into a sub-folder of Services. See how he did it and do the same.

Why is this service prefixed with "Tx"?
Also, Praneeth and I agreed to put these state machine services into a sub-folder of Services. See how he did it and do the same.

DrySelfTests unit.

DrySelfTests unit.

DrySelfTests unit initialized.

DrySelfTests unit initialized.

Remove extra blank line.

Remove extra blank line.

.. handles dry self-tests execution for pre-treatment and treatment modes.

.. handles dry self-tests execution for pre-treatment and treatment modes.

Should be in "", not <>. And should be placed alphabetically down before TxParams.h.

Should be in "", not <>. And should be placed alphabetically down before TxParams.h.

Calling signal function here seems circular (that's how we got here in the first place). Shouldn't we set state to the install state here instead?

Calling signal function here seems circular (that's how we got here in the first place).
Shouldn't we set state to the install state here instead?

Put before TxParams.

Put before TxParams.

I think Praneeth created a function for this. Make sure they're identical.

I think Praneeth created a function for this. Make sure they're identical.

Why are we removing this TODO comment? It looks like we should keep it.

Why are we removing this TODO comment? It looks like we should keep it.

Do we need TODO comments to restore these alarms later?

Do we need TODO comments to restore these alarms later?

What is the point of this message?

What is the point of this message?

Looks like we need a TODO comment to restore these checks later.

Looks like we need a TODO comment to restore these checks later.

We should just have 1 of these. Let's have TD always working in mL and mL/min, and we'll just convert before sending to UI or after receiving from UI.

We should just have 1 of these. Let's have TD always working in mL and mL/min, and we'll just convert before sending to UI or after receiving from UI.

we don't need pragma alignment on enums, could you exclude it ?

we don't need pragma alignment on enums, could you exclude it ?

Updated to ml/min, except for broadcast in treatment mode

Updated to ml/min, except for broadcast in treatment mode

What TD does with UF rate is mostly to tell DD what rate we want. DD wants mL/min. TD can keep L/hr and convert to mL/min every time it needs to send DD a message or it can keep mL/min and convert ...

What TD does with UF rate is mostly to tell DD what rate we want. DD wants mL/min. TD can keep L/hr and convert to mL/min every time it needs to send DD a message or it can keep mL/min and convert to L/hr every time it needs to send UI a message. Either way works for me.

Changed to U32

Changed to U32

we are sending a message ack as response in the handler of this message request

we are sending a message ack as response in the handler of this message request

Other existing set functions in TD is using UF in liter and rate in L/hr Shall I change all of them? Which might impact how systems is sending this info(L/hr or ml/min) in their scripts

Other existing set functions in TD is using UF in liter and rate in L/hr

Shall I change all of them? Which might impact how systems is sending this info(L/hr or ml/min) in their scripts

I think DD (and TD) want mL/min and UI wants L/hr. TxParams should have already calculated this rate (in mL/min) and should probably have a get function you can call from here to access it. When se...

I think DD (and TD) want mL/min and UI wants L/hr. TxParams should have already calculated this rate (in mL/min) and should probably have a get function you can call from here to access it. When sending UF rate to UI, we would convert back to L/hr first, but everywhere else we would work with mL/min.

Remove extra blank line.

Remove extra blank line.

Remove extra space before function name.

Remove extra space before function name.

This is not a Dialin message, so move up above all of these "test" functions.

This is not a Dialin message, so move up above all of these "test" functions.