leahi-fwcommon

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LDT-3958 PI control update

I had this commented again to push to the develop branch. It is uncommented for my testing.

I had this commented again to push to the develop branch. It is uncommented for my testing.

Merge branch 'feature/LDT-3963-dialysate-flow-rate---fw-implem' into develop

Merge branch 'develop' of bitbucket.org:diality-cloud/leahi-fwcommon into develop

added TODO above

added TODO above

updated as suggested.

updated as suggested.

updated.

updated.

updated accordingly.

updated accordingly.

added TODO for all

added TODO for all

makes sense. removed it.

makes sense. removed it.

I think we are using it to send a message to Dialin, to let the tester know whether the command has passed/failed or timed out.

I think we are using it to send a message to Dialin, to let the tester know whether the command has passed/failed or timed out.

restored

restored

Removedd

Removedd

added

added

LDT-2240-disposable-tube-set-self-test

Merge branch 'staging' of bitbucket.org:diality-cloud/leahi-fwcommon into LDT-3505-heparin-td-04-dev-feature-implemenation

Updated

Updated

Merge branch 'staging' of bitbucket.org:diality-cloud/leahi-fwcommon into LDT-2240-disposable-tube-set-self-test

Why did we remove this? This is needed for BC Switch only condition.

Why did we remove this? This is needed for BC Switch only condition.

LDT-3958 heater control update

LDT-3958 resolving merge conflicts

LDT-4188 merge latest to staging

LDT-4188 merge latest from staging

Again, I don't like these oriented this way. Please change to #ifndef DISABLE_ALARM_4

Again, I don't like these oriented this way. Please change to #ifndef DISABLE_ALARM_4

If BC switching period is Zero, I would expect the Qd from TD to also be zero, right? But what if it's not? What if Qd from TD is 600 and switching period is zero? You are going to run the pump pre...

If BC switching period is Zero, I would expect the Qd from TD to also be zero, right? But what if it's not? What if Qd from TD is 600 and switching period is zero? You are going to run the pump pretty fast with no BC switching in that case.

We shouldn't require something to be defined to do the right thing. We should require something to be defined to do the wrong thing (i.e. this should say #ifndef _BAD_MSG_CRC_ALARM_DISABLED_) And t...

We shouldn't require something to be defined to do the right thing. We should require something to be defined to do the wrong thing (i.e. this should say #ifndef _BAD_MSG_CRC_ALARM_DISABLED_)
And then, we don't need a TODO. These #defines are only possible in DEBUG builds. A RELEASE build will never allow thing build flags to disable things.

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Remove start state.

Remove start state.