leahi-fwcommon

Clone Tools

Stats

Commits this week: 8
Total Committers: 13
Last Commit: 10:33
Commits this week: 8

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
6 hrs ago

Vendor - TEL - Varshini Nagabooshanam

Fixed

Options
    • -2
    • +3
    /TestSupport.h
7 hrs ago

Zoltan Miskolci

Shouldn't this file contain the incoming request and associate it to the corresponding function? And that function will trigger the response sending part. Declaring the response here instead seems...

Shouldn't this file contain the incoming request and associate it to the corresponding function?
And that function will trigger the response sending part.

Declaring the response here instead seems out of regular design scheme.

Friday 22 May
11:17 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    /PIControllers.c
11:11 am

Vendor - TEL - Jashwant Gantyada

10:55 am

Vendor - TEL - Jashwant Gantyada

LDT-3963 resolved merge conflicts and merged branch

Options
    • -2
    • +2
    /PIControllers.c
    • -2
    • +2
    /PIControllers.h
    • -2
    • +3
    /TestSupport.h
10:50 am

Sean Nash and Vinayakam Mani

9:04 am

Vendor - TEL - Jashwant Gantyada

Merge branch 'staging' into feature/LDT-3963-dialysate-flow-rate---fw-implem

Options
Thursday 21 May
8:37 pm

Dara Navaei

Merge branch 'staging' into LDT-3259-software-update---td-firmware

Options
4:27 pm

Vendor - TEL - Arpita Srivastava

3:24 pm

Vendor - TEL - Jashwant Gantyada

restored

restored

3:24 pm

Sean Nash

Not sure why Crucible is showing it this way. Let's just re-review these diffs.

Not sure why Crucible is showing it this way. Let's just re-review these diffs.

3:22 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    /PersistentAlarm.h
    • -2
    • +2
    /TestSupport.h
3:18 pm

Sean Nash

Should be #ifndef

Should be #ifndef

3:13 pm

Sean Nash

Should be #ifndef I think.

Should be #ifndef I think.

3:06 pm

Sean Nash

Can we make these low priority and 999 rank?

Can we make these low priority and 999 rank?

3:06 pm

Vendor - TEL - Jashwant Gantyada and Sean Nash

Wednesday 20 May
4:23 pm

Sean Nash

I thought this was a TEST_CONFIG thing. We aren't doing s/w config status, so maybe we should convert it to a TEST_CONFIG.

I thought this was a TEST_CONFIG thing. We aren't doing s/w config status, so maybe we should convert it to a TEST_CONFIG.

4:22 pm

Sean Nash

Let's hard code for time being with a TODO comment. I don't want alarm to be a problem.

Let's hard code for time being with a TODO comment. I don't want alarm to be a problem.

4:20 pm

Sean Nash

Use OVERRIDE_RESET for .override instead of 0.

Use OVERRIDE_RESET for .override instead of 0.

2:12 pm

Vendor - TEL - Jashwant Gantyada

align indentation, same for line 338 as well.

align indentation, same for line 338 as well.

2:07 pm

Vendor - TEL - Arpita Srivastava

Yes. Otherwise, we will have to hard code the calibration record for the time being.

Yes.
Otherwise, we will have to hard code the calibration record for the time being.

1:59 pm

Vendor - TEL - Arpita Srivastava

The function getSoftwareConfigStatus() is also part of NVM module. Moreover, we are planning to remove this function when NVM will be implemented. So, we will have to perform a cleanup and remove a...

The function getSoftwareConfigStatus() is also part of NVM module.
Moreover, we are planning to remove this function when NVM will be implemented.
So, we will have to perform a cleanup and remove all similar calls that have been currently commented out in other files as well like AirTrap.c, BloodFlow.c, etc.

12:14 pm

Sean Nash

Is this the right time to zero this volume?

Is this the right time to zero this volume?

12:13 pm

Sean Nash

update total volume too?

update total volume too?

12:09 pm

Sean Nash

maybe use target rate for both.

maybe use target rate for both.

11:41 am

Sean Nash

Use #define for array size.

Use #define for array size.

11:40 am

Sean Nash

Make the 6 a #define

Make the 6 a #define

11:39 am

Sean Nash

only 1 return statement

only 1 return statement

11:35 am

Sean Nash

remove comma

remove comma

11:24 am

Sean Nash

return FALSE on else

return FALSE on else