dd-firmware / firmware / App / Modes

ModePostGenDialysate.h

Clone Tools

Stats

Commits this week: 1
Total Committers: 3
Last Commit: 09 Feb
Commits this week: 1

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 08 Apr
1:51 pm

Sean Nash

FALSE?

FALSE?

1:51 pm

Sean Nash

FALSE?

FALSE?

1:50 pm

Sean Nash

FALSE?

FALSE?

1:46 pm

Sean Nash

Should default be TRUE? If we are being asked to validate an jump to an invalid state, shouldn't we return FALSE?

Should default be TRUE? If we are being asked to validate an jump to an invalid state, shouldn't we return FALSE?

1:44 pm

Sean Nash

Vinayakam Mani, how does that signal happen normally? In your example, when would DD signal FP when starting pre-gen mode? If that signal happened in pre-gen transition function, it would always ha...

Vinayakam Mani, how does that signal happen normally? In your example, when would DD signal FP when starting pre-gen mode? If that signal happened in pre-gen transition function, it would always happen regardless of how we got to pre-gen mode.

1:41 pm

Sean Nash

Add comment that these modes not (yet?) supported.

Add comment that these modes not (yet?) supported.

8:24 am

Dara Navaei

Tuesday 07 Apr
2:54 pm

Vinayakam Mani

Probably, we need to signal FP as well when there is a mode change happens. say, DD changes standby to pre-gen/Gen Dialysate mode, FP needs to transition to pre-gen / generate permeate (as we imple...

Probably, we need to signal FP as well when there is a mode change happens. say, DD changes standby to pre-gen/Gen Dialysate mode, FP needs to transition to pre-gen / generate permeate (as we implemented in TD interface).

Monday 06 Apr
1:00 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3749_Ability to set operation sub mode on DD subsystem
LEAHI-DD-FIRMWARE-LDT-3749_Ability to set operation sub mode on DD subsystem
12:45 pm

Raghu Kallala

Wednesday 25 Mar
4:01 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
Thursday 19 Mar
3:47 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
Tuesday 17 Mar
7:22 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3749_Ability to set operation sub mode on DD subsystem
LEAHI-DD-FIRMWARE-LDT-3749_Ability to set operation sub mode on DD subsystem
Friday 09 Jan
10:07 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./ModePostGenDialysate.h
  2. … 121 more files in changeset.
Friday 05 Dec 2025
1:26 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./ModePostGenDialysate.h
  2. … 121 more files in changeset.
Tuesday 22 Apr 2025
2:42 pm

Vinayakam Mani

2:32 pm

Sean Nash and Michael Garthwaite

2:07 pm

Vinayakam Mani

Done.

Done.

2:07 pm

Vinayakam Mani

Done.

Done.

2:07 pm

Vinayakam Mani

Done.

Done.

2:06 pm

Vinayakam Mani

Done.

Done.

1:18 pm

Vinayakam Mani

Done

Done

1:16 pm

Sean Nash

Same as Gen Dialysate - this should be else if and switch statement should be in a final else.

Same as Gen Dialysate - this should be else if and switch statement should be in a final else.

1:14 pm

Sean Nash

stop should be capitalized.

stop should be capitalized.

1:14 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

1:13 pm

Sean Nash

I think these two conditions above the switch statement should end the state processing. So the second condition should be an else if and combined i.e. if ( ( genDialysateState != DD_GEND_DIALYSATE...

I think these two conditions above the switch statement should end the state processing.
So the second condition should be an else if and combined i.e. if ( ( genDialysateState != DD_GEND_DIALYSATE_DELIVERY_PAUSE ) && ( TRUE == areInletWaterConditionsAlarmsActive() ) ).
And then another else where the switch statement should go.
Hydraulic chamber and updating treatment settings should maybe be moved above all of this so they always happen.

11:43 am

Vinayakam Mani

Done.

Done.

10:34 am

Sean Nash

Want Gen Dialysate mode state machine to handle the mode change - so request function should set a flag that the state machine will act on in next pass.

Want Gen Dialysate mode state machine to handle the mode change - so request function should set a flag that the state machine will act on in next pass.

10:33 am

Sean Nash

Want Pre Gen mode state machine to handle the mode change - so request function should set a flag that the state machine will act on in next pass.

Want Pre Gen mode state machine to handle the mode change - so request function should set a flag that the state machine will act on in next pass.

8:57 am

Sean Nash

Signal Pre Gen mode and let it request standby mode.

Signal Pre Gen mode and let it request standby mode.