leahi-fwcommon

PIControllers.h

Clone Tools

Stats

Commits this week: 1
Total Committers: 4
Last Commit: 13 Mar
Commits this week: 1

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 13 Mar
9:33 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

9:31 am

Sean Nash

Should we create a structure for these moving average filters and make an array of them based on enum of temp sensors? It looks kind of messy having separate handling for each sensor - can we conso...

Should we create a structure for these moving average filters and make an array of them based on enum of temp sensors?
It looks kind of messy having separate handling for each sensor - can we consolidate some of this code?

9:28 am

Sean Nash

Should we maybe just have a constant array of sample counts based on enum of temp sensors?

Should we maybe just have a constant array of sample counts based on enum of temp sensors?

9:24 am

Sean Nash

Should min and max be properties of the controller instead of global (assumes all controllers will want same min/max)? Controller properties already include a min and max field - can we use those?

Should min and max be properties of the controller instead of global (assumes all controllers will want same min/max)?
Controller properties already include a min and max field - can we use those?

9:16 am

Sean Nash

Remove blank line.

Remove blank line.

Thursday 12 Mar
3:43 pm

Vinayakam Mani

Done.

Done.

3:42 pm

Vinayakam Mani

Done.

Done.

Wednesday 25 Feb
12:49 pm

Vendor - TEL - Sameer Poyil

mis aligned ?

mis aligned ?

12:48 pm

Vendor - TEL - Sameer Poyil

mis aligned ?

mis aligned ?

Monday 23 Feb
6:29 pm

Vendor - TEL - Sameer Poyil

need a brief description about this feature and how it is implemented/logic/math etc - also comment on the previous logic

need a brief description about this feature and how it is implemented/logic/math etc - also comment on the previous logic

6:27 pm

Vendor - TEL - Sameer Poyil

its a reverse logic - is it OK to make positive instead of not defined ?

its a reverse logic - is it OK to make positive instead of not defined ?

Friday 13 Feb
3:47 pm

Sean Nash

Looks like we are doing a lot of the dialysate temp control in Gen Dialysate mode. Do we not do any heating in PreGen mode? Even if all dialysate heating is done in this mode, should we consider cr...

Looks like we are doing a lot of the dialysate temp control in Gen Dialysate mode. Do we not do any heating in PreGen mode?
Even if all dialysate heating is done in this mode, should we consider creating a service controller (like BC controller) to manage this complex temperature control?

3:38 pm

Sean Nash

Resolve merge conflicts.

Resolve merge conflicts.

Tuesday 10 Feb
5:03 pm

Sean Nash

Add blank line between declarations and rest of code.

Add blank line between declarations and rest of code.

5:02 pm

Sean Nash

Add comment to right listing which math functions we're using.

Add comment to right listing which math functions we're using.

12:04 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3352_DD - revisit D3 level control logic
LEAHI-DD-FIRMWARE-LDT-3352_DD - revisit D3 level control logic
Friday 09 Jan
10:08 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    /PIControllers.h
  2. … 28 more files in changeset.
Friday 05 Dec 2025
1:26 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -4
    • +4
    /PIControllers.h
  2. … 28 more files in changeset.
Tuesday 07 Oct 2025
9:46 am

Sean Nash

Monday 06 Oct 2025
11:00 am

Raghu Kallala , Michael Garthwaite and Vinayakam Mani

Friday 03 Oct 2025
2:45 pm

Vinayakam Mani

Done.

Done.

Thursday 25 Sep 2025
8:48 am

Sean Nash

Why the extra leading zeroes? If you want to ensure the literal is treated like a U32, you can do 0x00000001 or simply 1U, but I suspect the compiler will default to 32 bits anyway.

Why the extra leading zeroes? If you want to ensure the literal is treated like a U32, you can do 0x00000001 or simply 1U, but I suspect the compiler will default to 32 bits anyway.

Wednesday 24 Sep 2025
9:10 am

Sean Nash

I believe baro is being moved to the TD firmware. DD will have to get baro readings from TD broadcasts.

I believe baro is being moved to the TD firmware. DD will have to get baro readings from TD broadcasts.

Tuesday 23 Sep 2025
10:23 am

jpaguio  (deleted user)

Do you want to add a space for the baro pressure sensor from which we receive from the TD?

Do you want to add a space for the baro pressure sensor from which we receive from the TD?

Thursday 18 Sep 2025
9:38 am

Vinayakam Mani

I have removed multiple M4 valve control across in DD. IO/FP will govern the M4 valve control.

I have removed multiple M4 valve control across in DD. IO/FP will govern the M4 valve control.

Tuesday 16 Sep 2025
2:34 pm

Michael Garthwaite

fixed. thanks

fixed. thanks

2:34 pm

Michael Garthwaite

fixed. thanks

fixed. thanks

2:34 pm

Michael Garthwaite

fixed. thanks

fixed. thanks

2:33 pm

Michael Garthwaite

fixed. removed m4 from dd side

fixed. removed m4 from dd side

1:46 pm

Vinayakam Mani

Align comments.

Align comments.