dd-firmware / firmware / App / Modes

ModeService.c

Clone Tools

Stats

Commits this week: 0
Total Committers: 3
Last Commit: 24 Mar
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
13 mins ago

Sean Nash

13 mins ago

Sean Nash

27 mins ago

Vendor - TEL - Arpita Srivastava

I tried the suggested change and tested. But it did not provide the expected results. If a on was requested while an off was still pending to be processed, the off-request flag gets cleared without...

I tried the suggested change and tested. But it did not provide the expected results.
If a on was requested while an off was still pending to be processed, the off-request flag gets cleared without the actual request being processed and the off request was never executed.

Wednesday 25 Mar
4:01 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
Thursday 19 Mar
3:47 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
Wednesday 11 Mar
2:07 pm

Sean Nash

Remove blank line and comment saying we're not doing anything (because now we're doing something).

Remove blank line and comment saying we're not doing anything (because now we're doing something).

2:05 pm

Sean Nash

isBalChamberSwitchingOffRequested is an output.

isBalChamberSwitchingOffRequested is an output.

2:03 pm

Sean Nash

Should we set the other switch to FALSE, just in case?

Should we set the other switch to FALSE, just in case?

Wednesday 25 Feb
3:31 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-1195_DD: Request for a variable for balancing chamber switching to be active (T/F)
LEAHI-DD-FIRMWARE-LDT-1195_DD: Request for a variable for balancing chamber switching to be active (T/F)
Friday 09 Jan
10:07 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./ModeService.c
  2. … 121 more files in changeset.
Friday 05 Dec 2025
1:26 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -3
    • +3
    ./ModeService.c
  2. … 121 more files in changeset.
Friday 15 Nov 2024
1:04 pm

Vinayakam Mani

11:27 am

Dara Navaei and Sean Nash

Thursday 14 Nov 2024
3:39 pm

Vinayakam Mani

Done.

Done.

3:39 pm

Vinayakam Mani

Done.

Done.

3:38 pm

Vinayakam Mani

Done.

Done.

3:38 pm

Vinayakam Mani

Done.

Done.

3:38 pm

Vinayakam Mani

Done.

Done.

3:38 pm

Vinayakam Mani

Done.

Done.

3:37 pm

Vinayakam Mani

Done.

Done.

3:36 pm

Vinayakam Mani

Done.

Done.

3:36 pm

Vinayakam Mani

Done.

Done.

3:36 pm

Vinayakam Mani

Done.

Done.

9:20 am

Sean Nash

Change "&&" to "||". Also, I think we need another condition added here because I don't think we should be setting all of these values if things above aren't right.

Change "&&" to "||". Also, I think we need another condition added here because I don't think we should be setting all of these values if things above aren't right.

9:18 am

Sean Nash

I don't think the "|=" is accomplishing anything useful here - this is effectively setting result to TRUE in all cases. And I don't think we should be setting result to TRUE here necessarily. If we...

I don't think the "|=" is accomplishing anything useful here - this is effectively setting result to TRUE in all cases.
And I don't think we should be setting result to TRUE here necessarily. If we set result to FALSE above, it should stay FALSE.

9:12 am

Sean Nash

ModeGenDialysate should move up before ModeInitPOST to be in alphabetical order.

ModeGenDialysate should move up before ModeInitPOST to be in alphabetical order.

9:11 am

Sean Nash

Indent function name more to align like others.

Indent function name more to align like others.

9:08 am

Sean Nash

Fix "Dialysatey" (remove y). And I think "Gend" should be GenD" in all of these function names.

Fix "Dialysatey" (remove y). And I think "Gend" should be GenD" in all of these function names.

9:07 am

Sean Nash

Who is calling this function? If this function is not doing anything other than changing modes, do we really need this function? Caller can just call requestNewOperationMode().

Who is calling this function? If this function is not doing anything other than changing modes, do we really need this function? Caller can just call requestNewOperationMode().

9:01 am

Sean Nash

If no inputs or outpus, say "none".

If no inputs or outpus, say "none".